GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update email to reflect affiliation by anonrig · Pull Request #50856 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Nov 22, 2023

Copy link
Copy Markdown
Member

Updating my email address on README to reflect my affiliation with Sentry (https://sentry.io). They're sponsoring my work to Node.js starting from November 20.

cc @nodejs/tsc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig
doc: update email to reflect affiliation
025569c
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Nov 22, 2023
aduh95
aduh95 reviewed Nov 22, 2023
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to also change the MAILMAP so your previous commit can still be attributed to you – otherwise the bot will open a PR to remove you from collaborators as soon as this is merged 😅

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tniessen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
mcollina
mcollina approved these changes Nov 22, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig
fixup! doc: update email to reflect affiliation
3872be6
@anonrig

anonrig commented Nov 22, 2023

Copy link
Copy Markdown
Member Author

You'd need to also change the MAILMAP so your previous commit can still be attributed to you – otherwise the bot will open a PR to remove you from collaborators as soon as this is merged 😅

I updated .mailmap as well. Can you validate @aduh95?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Nov 22, 2023

Copy link
Copy Markdown
Contributor

You can validate by running git log -1 --format=%aE <some-hash-of-a-commit-made-with-your-previous-address:

$ git fetch https://github.com/nodejs/node.git main && git reset FETCH_HEAD --hard
$ git log -1 --format=%aE 4cfc188f872ba766f6e1a019165e1cd428a9f6cb
[email protected]
$ curl -L https://github.com/nodejs/node/pull/50856.patch | git am
$ git log -1 --format=%aE 4cfc188f872ba766f6e1a019165e1cd428a9f6cb
[email protected]

As you can see, the mailmap is backward: it maps all the commits to your personal address, and none to your Sentry one.
anonrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 reviewed Nov 23, 2023
View reviewed changes
Comment thread .mailmap Resolved

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Nov 23, 2023
View reviewed changes
@anonrig @aduh95
Update .mailmap
221a4af 
Co-authored-by: Antoine du Hamel <[email protected]>
@anonrig anonrig added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Nov 23, 2023
jasnell
jasnell approved these changes Nov 24, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 24, 2023
ruyadorno
ruyadorno approved these changes Nov 24, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 41e225c into nodejs:main Nov 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 41e225c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@anonrig Lei Shi
doc: update email to reflect affiliation
33009c7 
PR-URL: nodejs#50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @RafaelGSS
doc: update email to reflect affiliation
02a963e 
PR-URL: #50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@anonrig @RafaelGSS
doc: update email to reflect affiliation
6485687 
PR-URL: #50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
76942c0 
PR-URL: #50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
af5b726 
PR-URL: #50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
45ff564 
PR-URL: #50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@anonrig @UlisesGascon
doc: update email to reflect affiliation
fe31505 
PR-URL: #50856
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@mcollina mcollina mcollina approved these changes
@ruyadorno ruyadorno ruyadorno approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @aduh95 @nodejs-github-bot @mcollina @ruyadorno @jasnell @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.