GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: cherry-pick 0f9ebbc672c7 by legendecas · Pull Request #50867 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Nov 23, 2023

Copy link
Copy Markdown
Member

Original commit message:

[flags] Remove --harmony-string-is-well-formed

The String.prototype.isWellFormed and toWellFormed have shipped
since M111.

Bug: v8:13557
Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
Reviewed-by: Shu-yu Guo <[email protected]>
Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc

This patch has been released in v8 12.0. Cherry-pick to unblock #47342.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@legendecas
deps: V8: cherry-pick 0f9ebbc672c7
4217167 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Nov 23, 2023
@legendecas legendecas mentioned this pull request Nov 23, 2023
lib,src: replace toUSVString with toWellFormed() #47342
Merged
targos
targos approved these changes Nov 23, 2023
View reviewed changes
gengjiawen
gengjiawen approved these changes Nov 23, 2023
View reviewed changes
@gengjiawen gengjiawen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 23, 2023
@github-actions

github-actions Bot commented Nov 23, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.
targos, gengjiawen, bricss, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 23, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55873/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5684/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2023 •
edited by legendecas
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

✅V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5684/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 23, 2023 •
edited by legendecas
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

✅ V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5684/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Nov 23, 2023
View reviewed changes
anonrig
anonrig approved these changes Nov 23, 2023
View reviewed changes
@gengjiawen gengjiawen added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fbfa77b into nodejs:main Nov 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in fbfa77b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
legendecas deleted the v8/string-well-formed branch November 24, 2023 03:42
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@legendecas Lei Shi
deps: V8: cherry-pick 0f9ebbc672c7
4e92c1c 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Nov 27, 2023
@legendecas @RafaelGSS
deps: V8: cherry-pick 0f9ebbc672c7
fa988b0 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
v21.3.0 proposal #50954
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@legendecas @RafaelGSS
deps: V8: cherry-pick 0f9ebbc672c7
e02f304 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
1d5eebd 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
e2aa879 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
db663b7 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
02faaba 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2023
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
bd28509 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Jan 4, 2024
@legendecas @targos
deps: V8: cherry-pick 0f9ebbc672c7
481a901 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #50115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
@legendecas @UlisesGascon
deps: V8: cherry-pick 0f9ebbc672c7
ec67890 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@legendecas @Medhansh404
deps: V8: cherry-pick 0f9ebbc672c7
f031466 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Chengzhong Wu (legendecas) <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: v8/v8@0f9ebbc
PR-URL: nodejs#50867
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: nodejs#50115
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@legendecas @nodejs-github-bot @anonrig @targos @gengjiawen @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.