GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: format coverage report for tap reporter by pulkit-30 · Pull Request #51119 · nodejs/node

Conversation

@pulkit-30

@pulkit-30 pulkit-30 commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

this PR enhances the tap coverage report output (similar to the spec reporter).

code:

import assert from "node:assert";
import { test } from "node:test";

test("some test", () => {
    assert.strictEqual(1,1)
})

before:

TAP version 13
# Subtest: some test
ok 1 - some test
  ---
  duration_ms: 1.008875
  ...
1..1
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 9.619875
# start of coverage report
# file | line % | branch % | funcs % | uncovered lines
# index.mjs | 100.00 | 100.00 | 100.00 | 
# all files | 100.00 | 100.00 | 100.00 |
# end of coverage report

now:

TAP version 13
# Subtest: some test
ok 1 - some test
  ---
  duration_ms: 1.41925
  ...
1..1
# tests 1
# suites 0
# pass 1
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 12.865292
# start of coverage report
# ----------------------------------------------------------
# file      | line % | branch % | funcs % | uncovered lines
# ----------------------------------------------------------
# index.mjs | 100.00 |   100.00 |  100.00 | 
# ----------------------------------------------------------
# all files | 100.00 |   100.00 |  100.00 |
# ----------------------------------------------------------
# end of coverage report

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@pulkit-30
test_runner: format coverage report for tap reporter
e9d638f
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 11, 2023
rluvaton
rluvaton approved these changes Dec 11, 2023
View reviewed changes

@rluvaton rluvaton left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this change still follows the tap specification and other tap parsers are working with this as well

Great job

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pulkit-30 and ljharb reacted with hooray emoji
All reactions
  • 🎉 2 reactions
Comment thread test/parallel/test-runner-coverage.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pulkit-30
fix lint
eb98b15
rluvaton
rluvaton approved these changes Dec 11, 2023
View reviewed changes
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56234/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Dec 11, 2023
View reviewed changes
@rluvaton rluvaton added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Dec 11, 2023
MoLow
MoLow approved these changes Dec 11, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56246/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 13, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51119
✔  Done loading data for nodejs/node/pull/51119
----------------------------------- PR info ------------------------------------
Title      test_runner: format coverage report for tap reporter (#51119)
Author     Pulkit Gupta  (@pulkit-30)
Branch     pulkit-30:tap-coverage -> nodejs:main
Labels     author ready, needs-ci, test_runner
Commits    2
 - test_runner: format coverage report for tap reporter
 - fix lint
Committers 1
 - pulkit-30 
PR-URL: https://github.com/nodejs/node/pull/51119
Reviewed-By: Raz Luvaton 
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51119
Reviewed-By: Raz Luvaton 
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 11 Dec 2023 16:35:48 GMT
   ✔  Approvals: 3
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/51119#pullrequestreview-1776094670
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51119#pullrequestreview-1776238268
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51119#pullrequestreview-1776345233
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-12T12:11:28Z: https://ci.nodejs.org/job/node-test-pull-request/56246/
- Querying data for job/node-test-pull-request/56246/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51119
From https://github.com/nodejs/node
 * branch                  refs/pull/51119/merge -> FETCH_HEAD
✔  Fetched commits as 228bc5c457a9..eb98b15f1352
--------------------------------------------------------------------------------
[main 787445b822] test_runner: format coverage report for tap reporter
 Author: pulkit-30 
 Date: Mon Dec 11 22:02:35 2023 +0530
 2 files changed, 20 insertions(+), 18 deletions(-)
[main e1358436fb] fix lint
 Author: pulkit-30 
 Date: Mon Dec 11 23:33:41 2023 +0530
 1 file changed, 2 insertions(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: format coverage report for tap reporter


PR-URL: #51119

Reviewed-By: Raz Luvaton [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Moshe Atlow [email protected]


[detached HEAD caac4b4984] test_runner: format coverage report for tap reporter

Author: pulkit-30 [email protected]

Date: Mon Dec 11 22:02:35 2023 +0530

2 files changed, 20 insertions(+), 18 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix lint


PR-URL: #51119

Reviewed-By: Raz Luvaton [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Moshe Atlow [email protected]


[detached HEAD 2079f69752] fix lint

Author: pulkit-30 [email protected]

Date: Mon Dec 11 23:33:41 2023 +0530

1 file changed, 2 insertions(+)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/7198280065
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Dec 15, 2023
debadree25
debadree25 approved these changes Dec 15, 2023
View reviewed changes
@debadree25 debadree25 added the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 15, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Dec 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/51119
✔  Done loading data for nodejs/node/pull/51119
----------------------------------- PR info ------------------------------------
Title      test_runner: format coverage report for tap reporter (#51119)
Author     Pulkit Gupta  (@pulkit-30)
Branch     pulkit-30:tap-coverage -> nodejs:main
Labels     author ready, needs-ci, test_runner
Commits    2
 - test_runner: format coverage report for tap reporter
 - fix lint
Committers 1
 - pulkit-30 
PR-URL: https://github.com/nodejs/node/pull/51119
Reviewed-By: Raz Luvaton 
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
Reviewed-By: Debadree Chatterjee 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51119
Reviewed-By: Raz Luvaton 
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
Reviewed-By: Debadree Chatterjee 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 11 Dec 2023 16:35:48 GMT
   ✔  Approvals: 4
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/51119#pullrequestreview-1776094670
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51119#pullrequestreview-1776238268
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/51119#pullrequestreview-1776345233
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/51119#pullrequestreview-1783172811
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-13T16:38:46Z: https://ci.nodejs.org/job/node-test-pull-request/56246/
- Querying data for job/node-test-pull-request/56246/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51119
From https://github.com/nodejs/node
 * branch                  refs/pull/51119/merge -> FETCH_HEAD
✔  Fetched commits as 5ac658102d8f..eb98b15f1352
--------------------------------------------------------------------------------
[main 867deb34eb] test_runner: format coverage report for tap reporter
 Author: pulkit-30 
 Date: Mon Dec 11 22:02:35 2023 +0530
 2 files changed, 20 insertions(+), 18 deletions(-)
[main 43b7a78955] fix lint
 Author: pulkit-30 
 Date: Mon Dec 11 23:33:41 2023 +0530
 1 file changed, 2 insertions(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test_runner: format coverage report for tap reporter


PR-URL: #51119

Reviewed-By: Raz Luvaton [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Moshe Atlow [email protected]

Reviewed-By: Debadree Chatterjee [email protected]


[detached HEAD dced0311b4] test_runner: format coverage report for tap reporter

Author: pulkit-30 [email protected]

Date: Mon Dec 11 22:02:35 2023 +0530

2 files changed, 20 insertions(+), 18 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix lint


PR-URL: #51119

Reviewed-By: Raz Luvaton [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Moshe Atlow [email protected]

Reviewed-By: Debadree Chatterjee [email protected]


[detached HEAD 95f42e504f] fix lint

Author: pulkit-30 [email protected]

Date: Mon Dec 11 23:33:41 2023 +0530

1 file changed, 2 insertions(+)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/7218561408
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Dec 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Dec 15, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 452d29c into nodejs:main Dec 15, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 15, 2023

Copy link
Copy Markdown
Collaborator

Landed in 452d29c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@pulkit-30 @RafaelGSS
test_runner: format coverage report for tap reporter
3ccd5fa 
PR-URL: #51119
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
@richardlau richardlau added the backport-requested-v20.x label Mar 25, 2024
@richardlau

richardlau commented Mar 25, 2024

Copy link
Copy Markdown
Member

This doesn't land cleanly on v20.x-staging and will need a manual backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi atlowChemi mentioned this pull request Mar 29, 2024
[v20.x backport] test_runner: format coverage report for tap reporter #52260
Closed
@atlowChemi atlowChemi added the backport-open-v20.x label Mar 29, 2024
@atlowChemi

atlowChemi commented Mar 29, 2024

Copy link
Copy Markdown
Member

@richardlau backported in #52260
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi pushed a commit to atlowChemi/node that referenced this pull request Mar 29, 2024
@pulkit-30 @atlowChemi
test_runner: format coverage report for tap reporter
d2ac2e4 
PR-URL: nodejs#51119
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@pulkit-30 @marco-ippolito
test_runner: format coverage report for tap reporter
d5ac979 
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
v20.13.0 proposal #52793
Merged
@targos targos added backported-to-v20.x and removed backport-requested-v20.x labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@rluvaton rluvaton rluvaton approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@pulkit-30 @nodejs-github-bot @richardlau @atlowChemi @lpinca @MoLow @rluvaton @debadree25 @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.