GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v20.x backport] test_runner: format coverage report for tap reporter by atlowChemi · Pull Request #52260 · nodejs/node

Conversation

@atlowChemi

@atlowChemi atlowChemi commented Mar 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR is a backport of #51119

PR-URL: #51119
Reviewed-By: Raz Luvaton [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Moshe Atlow [email protected]
Reviewed-By: Debadree Chatterjee [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
H4ad and others added 3 commits March 28, 2024 16:35
@H4ad @richardlau
perf_hooks: reduce overhead of createHistogram
1daccf5 
PR-URL: nodejs#50074
Backport-PR-URL: nodejs#51306
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@H4ad @richardlau
test: avoid v8 deadcode on performance function
5ff73f3 
PR-URL: nodejs#50074
Backport-PR-URL: nodejs#51306
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@pulkit-30 @atlowChemi
test_runner: format coverage report for tap reporter
d2ac2e4 
PR-URL: nodejs#51119
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. v20.x labels Mar 29, 2024
@atlowChemi atlowChemi mentioned this pull request Mar 29, 2024
test_runner: format coverage report for tap reporter #51119
Merged
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 29, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57996/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Mar 29, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57997/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Mar 29, 2024
View reviewed changes
mertcanaltin
mertcanaltin approved these changes Mar 30, 2024
View reviewed changes
@RafaelGSS
RafaelGSS force-pushed the v20.x-staging branch from 5ff73f3 to ae243ec Compare April 3, 2024 13:49
@RafaelGSS
RafaelGSS force-pushed the v20.x-staging branch from ae243ec to 32014f5 Compare April 10, 2024 16:18
@marco-ippolito
marco-ippolito force-pushed the v20.x-staging branch from 4fd1691 to ecadd63 Compare April 29, 2024 13:22
marco-ippolito pushed a commit that referenced this pull request Apr 29, 2024
@pulkit-30 @marco-ippolito
test_runner: format coverage report for tap reporter
d5ac979 
PR-URL: #51119
Backport-PR-URL: #52260
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@marco-ippolito

marco-ippolito commented Apr 29, 2024

Copy link
Copy Markdown
Member

Landed in d5ac979
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito added the backported-to-v20.x label Apr 29, 2024
@richardlau

richardlau commented Apr 29, 2024

Copy link
Copy Markdown
Member

Landed in d5ac979

@marco-ippolito There were three commits in this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito

marco-ippolito commented Apr 29, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Landed in d5ac979

@marco-ippolito There were three commits in this PR.

they we already pulled in v20 by another backport so I didnt duplicate them
v20.x...v20.x-staging
Is it alright?
richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@marco-ippolito marco-ippolito closed this Apr 29, 2024
@atlowChemi
atlowChemi deleted the backport-51119-to-20 branch August 27, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@mertcanaltin mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@atlowChemi @nodejs-github-bot @marco-ippolito @richardlau @lpinca @MoLow @mertcanaltin @H4ad @pulkit-30
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.