GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib,src: remove --experimental-policy by RafaelGSS · Pull Request #52583 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Apr 18, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: #52575

Summary: We are dropping the --experimental-policy feature from Node.js.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr, marco-ippolito, gurgunday, bricss, H4ad, avivkeller, and wesleytodd reacted with thumbs up emoji bricss and H4ad reacted with eyes emoji
All reactions
  • 👍 7 reactions
  • 👀 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/security-wg
  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Apr 18, 2024
anonrig
anonrig approved these changes Apr 18, 2024
View reviewed changes
Comment thread lib/internal/modules/run_main.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr reviewed Apr 19, 2024
View reviewed changes

@benjamingr benjamingr left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau

richardlau commented Apr 19, 2024

Copy link
Copy Markdown
Member

Generally in favor of this PR, we should probably warn people against using it in the meantime in a smaller semver-ptch PR

We should doc deprecate it immediately -- even if it's not a requirement for experimental features to go through a full deprecation cycle the earlier we inform users that the feature is going away the better.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added the tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. label Apr 19, 2024
@MoLow

MoLow commented Apr 19, 2024

Copy link
Copy Markdown
Member

added to tsc-agenda Issues and PRs to discuss during Technical Steering Committee meetings. just for awareness
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow reviewed Apr 19, 2024
View reviewed changes
Comment thread lib/internal/process/pre_execution.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
RafaelGSS force-pushed the drop-experimental-policy branch 3 times, most recently from e0004d1 to f4a190e Compare April 19, 2024 19:24
@RafaelGSS
RafaelGSS marked this pull request as ready for review April 19, 2024 19:24
@RafaelGSS RafaelGSS added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 19, 2024
@RafaelGSS

RafaelGSS commented Apr 19, 2024

Copy link
Copy Markdown
Member Author

This is now ready to review. I'm adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here's the plan:

  • I'll open a new PR to update the doc to doc-deprecated
  • Merge that PR
  • Land doc-deprecation in all release lines
  • Merge this PR
  • Land this PR in all release lines
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 19, 2024
doc: deprecate --experimental-policy #52602
Closed
aduh95
aduh95 reviewed Apr 19, 2024
View reviewed changes
Comment thread doc/api/errors.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
RafaelGSS force-pushed the drop-experimental-policy branch from f4a190e to 077fd72 Compare April 19, 2024 20:15
@GeoffreyBooth

GeoffreyBooth commented Apr 19, 2024

Copy link
Copy Markdown
Member

I’m adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:

I thought we never deprecated experimental features?

Ideally we would land this as part of 22.0.0.
4xpl0r3r reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes Apr 19, 2024
View reviewed changes
@GeoffreyBooth GeoffreyBooth removed the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Apr 19, 2024
@richardlau

richardlau commented Apr 19, 2024

Copy link
Copy Markdown
Member

I’m adding the dont-land labels as requested by @richardlau to follow the deprecation cycle. So, here’s the plan:

I thought we never deprecated experimental features?

Ideally we would land this as part of 22.0.0.

We have in the past: #12243
I don't believe it is a requirement for experimental features to go through a full deprecation cycle, but that doesn't stop us doc-deprecating things. For example, I'd be much more hesitant to backport this PR (with 89 touched files) to LTS immediately -- I'd probably want to wait longer than the usual "two weeks in current" policy just due to the number of files touched whereas I'd have no issue with landing doc deprecations in line with the two week policy.
4xpl0r3r reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth

GeoffreyBooth commented Apr 20, 2024

Copy link
Copy Markdown
Member

I think it's less disruptive to remove this as part of 22.0.0 than later in the 22 line, or in 23.
4xpl0r3r and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller

avivkeller commented Apr 20, 2024

Copy link
Copy Markdown
Member

This is more of a meta note, but if we remove the experimental policy, we should also remove the issue label (policy) as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@joyeecheung

joyeecheung commented Apr 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Can we fast-track a doc-deprecation in 22? Maybe changing the experimental warning into deprecation warning too if that's not too much hassle? Then we can proceed with this PR for later versions of 22, or 23.

EDIT: oh I see #52602 now
MoLow and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson mentioned this pull request Apr 22, 2024
Node.js Technical Steering Committee (TSC) Meeting 2024-04-24 nodejs/TSC#1535
Closed
@RafaelGSS

RafaelGSS commented Apr 22, 2024

Copy link
Copy Markdown
Member Author

doc-deprecation has been merged. I will wait for it to land on v22/v21 then I will proceed with this PR as it will hard conflict if I just merge it with dont-land-*.
avivkeller and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8976580157
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58994/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59003/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes May 7, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented May 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59006/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels May 7, 2024
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label May 7, 2024
marco-ippolito
marco-ippolito approved these changes May 7, 2024
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 7, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 951af83 into nodejs:main May 7, 2024
@nodejs-github-bot

nodejs-github-bot commented May 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in 951af83
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller

avivkeller commented May 7, 2024

Copy link
Copy Markdown
Member

The policy label should also be removed from the issue tracker
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request May 7, 2024
Remove --experimental-policy #52575
Closed
targos pushed a commit that referenced this pull request May 8, 2024
@RafaelGSS @targos
lib,src: remove --experimental-policy
9a7ae9b 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: #52583
Refs: #52575
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
targos added a commit that referenced this pull request May 13, 2024
@targos
2024-05-14, Version 22.2.0 (Current)
f8eb8d9 
Notable changes:

doc:
  * add pimterry to collaborators (Tim Perry) #52874
lib,src:
  * remove --experimental-policy (Rafael Gonzaga) #52583
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692

PR-URL: TODO
targos added a commit that referenced this pull request May 13, 2024
@targos
2024-05-14, Version 22.2.0 (Current)
7d92816 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
@targos targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged
targos added a commit that referenced this pull request May 15, 2024
@targos
2024-05-15, Version 22.2.0 (Current)
d57af10 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
targos added a commit that referenced this pull request May 15, 2024
@targos
2024-05-15, Version 22.2.0 (Current)
28b0a58 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    #52766
doc:
  * add pimterry to collaborators (Tim Perry)
    #52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) #52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    #52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    #52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) #51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    #52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    #52692

PR-URL: #52971
@marco-ippolito

marco-ippolito commented Jun 17, 2024

Copy link
Copy Markdown
Member

Do we want to backport it to v20?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Jun 17, 2024

Copy link
Copy Markdown
Member Author

Do we want to backport it to v20?

Yes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@RafaelGSS @soophoo
lib,src: remove --experimental-policy
ca1fadb 
Signed-off-by: RafaelGSS <[email protected]>
PR-URL: nodejs#52583
Refs: nodejs#52575
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos @soophoo
2024-05-15, Version 22.2.0 (Current)
eccd98f 
Notable changes:

cli:
  * (SEMVER-MINOR) allow running wasm in limited vmem with
    --disable-wasm-trap-handler (Joyee Cheung)
    nodejs#52766
doc:
  * add pimterry to collaborators (Tim Perry)
    nodejs#52874
fs:
  * (SEMVER-MINOR) allow 'withFileTypes' to be used with globs
    (Aviv Keller) nodejs#52837
inspector:
  * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno)
    nodejs#52734
lib,src:
  * remove --experimental-policy (Rafael Gonzaga)
    nodejs#52583
perf_hooks:
  * (SEMVER-MINOR) add `deliveryType` and `responseStatus` fields
    (Matthew Aitken) nodejs#51589
test_runner:
  * (SEMVER-MINOR) support test plans (Colin Ihrig)
    nodejs#52860
zlib:
  * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung)
    nodejs#52692

PR-URL: nodejs#52971
@marco-ippolito marco-ippolito added the dont-land-on-v20.x label Jul 19, 2024
@RafaelGSS RafaelGSS mentioned this pull request Aug 8, 2024
doc: remove module-based permission doc #54266
Merged
@dario-piotrowicz dario-piotrowicz mentioned this pull request May 11, 2025
src: remove unused internalVerifyIntegrity internal binding #58285
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments
@aduh95 aduh95 aduh95 left review comments
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. deprecations Issues and PRs related to deprecations. experimental Issues and PRs related to experimental features. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. policy Historical issues and PRs related to the removed policy-manifest feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@RafaelGSS @nodejs-github-bot @richardlau @MoLow @GeoffreyBooth @avivkeller @joyeecheung @marco-ippolito @benjamingr @anonrig @BridgeAR @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.