GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove module-based permission doc by RafaelGSS · Pull Request #54266 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Aug 8, 2024

Copy link
Copy Markdown
Member

Follow up #52583

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS
doc: remove module-based permission doc
69bcbaf
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Aug 8, 2024
marco-ippolito
marco-ippolito approved these changes Aug 8, 2024
View reviewed changes
@avivkeller avivkeller added policy Historical issues and PRs related to the removed policy-manifest feature. permission Issues and PRs related to the Permission Model. labels Aug 8, 2024
lpinca
lpinca approved these changes Aug 8, 2024
View reviewed changes
@RafaelGSS RafaelGSS removed the permission Issues and PRs related to the Permission Model. label Aug 8, 2024
trivikr
trivikr approved these changes Aug 9, 2024
View reviewed changes
anonrig
anonrig approved these changes Aug 9, 2024
View reviewed changes
@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 9, 2024
aymen94
aymen94 approved these changes Aug 9, 2024
View reviewed changes
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 10, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d708281 into nodejs:main Aug 10, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 10, 2024

Copy link
Copy Markdown
Collaborator

Landed in d708281
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Aug 14, 2024
@RafaelGSS @targos
doc: remove module-based permission doc
26c37f7 
PR-URL: #54266
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@trivikr trivikr trivikr approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. policy Historical issues and PRs related to the removed policy-manifest feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@RafaelGSS @nodejs-github-bot @lpinca @anonrig @aymen94 @trivikr @marco-ippolito @targos @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.