GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove buffered flag from performance hooks examples by pavel-romanov8 · Pull Request #52607 · nodejs/node

Conversation

@pavel-romanov8

@pavel-romanov8 pavel-romanov8 commented Apr 20, 2024

Copy link
Copy Markdown
Contributor

The actual implementation of the observe method does not count the buffered flag if we use the entryTypes with it. Therefore, examples with both entryTypes and buffered are confusing because it doesn't have any effect on the actual behaviour.

I see that we have somewhat similar PR on the same topic. However, it doesn't provide changes to the examples. Also, I'm not sure at what stage the PR I linked is. If it stuck and not going anywhere I can work on it and deliver the whole fix instead of just examples.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pavel-romanov8
doc: remove buffered flag from performance hooks examples
9600ce3
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. labels Apr 20, 2024
aduh95
aduh95 approved these changes Feb 23, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 23, 2025
jasnell
jasnell approved these changes Feb 23, 2025
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 23, 2025
@nodejs-github-bot
nodejs-github-bot merged commit bc8c6f8 into nodejs:main Feb 23, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 23, 2025

Copy link
Copy Markdown
Collaborator

Landed in bc8c6f8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@pavel-romanov8 @acidiney
doc: remove buffered flag from performance hooks examples
b3adfc5
PR-URL: nodejs#52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
@pavel-romanov8 @targos
doc: remove buffered flag from performance hooks examples
ca65106
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 25, 2025
2025-02-26, Version 23.9.0 (Current) #57207
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@pavel-romanov8 @targos
doc: remove buffered flag from performance hooks examples
587112c
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@pavel-romanov8 @aduh95
doc: remove buffered flag from performance hooks examples
3a37ad6
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@pavel-romanov8 @aduh95
doc: remove buffered flag from performance hooks examples
ccf6cf7
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@pavel-romanov8 @RafaelGSS
doc: remove buffered flag from performance hooks examples
e187fa5
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@pavel-romanov8 @RafaelGSS
doc: remove buffered flag from performance hooks examples
7243c17
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@pavel-romanov8 @marco-ippolito
doc: remove buffered flag from performance hooks examples
7280fe0
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2025
2025-09-03, Version 20.19.5 'Iron' (LTS) #59551
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@pavel-romanov8 @marco-ippolito
doc: remove buffered flag from performance hooks examples
8063cd9
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@pavel-romanov8 @marco-ippolito
doc: remove buffered flag from performance hooks examples
0c0daea
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@pavel-romanov8 @marco-ippolito
doc: remove buffered flag from performance hooks examples
0186b1a
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@pavel-romanov8 @marco-ippolito
doc: remove buffered flag from performance hooks examples
1db42b7
PR-URL: #52607
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pavel-romanov8 @nodejs-github-bot @jasnell @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.