GeezerVison is showing github.com — 2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS by RafaelGSS · Pull Request #57840 · nodejs/node
Conversation
RafaelGSS
commented
Apr 11, 2025
•
edited by aduh95
Loading
Uh oh!
There was an error while loading. Please reload this page.
Notable Changes
- [
3c88f3938b] - (SEMVER-MINOR) assert: implement partial error comparison (Ruben Bridgewater) #57370
- [
db19a3f9fc] - (SEMVER-MINOR) assert: improve partialDeepStrictEqual (Ruben Bridgewater) #57370
- [
b0c162dbe3] - (SEMVER-MINOR) assert,util: improve performance (Ruben Bridgewater) #57370
- [
159b9cf79b] - (SEMVER-MINOR) benchmark: adjust assert runtimes (Ruben Bridgewater) #57370
- [
073b15d52d] - (SEMVER-MINOR) benchmark: skip running some assert benchmarks by default (Ruben Bridgewater) #57370
- [
1922cb1042] - (SEMVER-MINOR) benchmark: add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
- [
1ee5f840b4] - (SEMVER-MINOR) cli: allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
- [
872ee0f2ac] - crypto: update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
- [
03a0f3a56b] - (SEMVER-MINOR) crypto: support --use-system-ca on Windows (Joyee Cheung) #56833
- [
94647bbdb2] - (SEMVER-MINOR) crypto: added support for reading certificates from macOS system store (Tim Jacomb) #56599
- [
8f7b86a6e7] - deps: update timezone to 2025a (Node.js GitHub Bot) #56876
- [
f9f611fb58] - (SEMVER-MINOR) deps,tools: add zstd 1.5.6 (Jan Martin) #52100
- [
07a6d5f8cf] - (SEMVER-MINOR) dns: add TLSA record query and parsing (Rithvik Vibhu) #52983
- [
d8a83ef2f3] - doc: add @geeksilva97 to collaborators (Edy Silva) #57241
- [
6b93ba723b] - (SEMVER-MINOR) module: use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
- [
b2e44a8079] - (SEMVER-MINOR) module: implement module.registerHooks() (Joyee Cheung) #55698
- [
dc91ae7471] - (SEMVER-MINOR) process: add execve (Paolo Insogna) #56496
- [
bc672fcfdd] - (SEMVER-MINOR) sqlite: allow returning ArrayBufferViews from user-defined functions (René) #56790
- [
5edee197ab] - (SEMVER-MINOR) tls: implement tls.getCACertificates() (Joyee Cheung) #57107
- [
f9fe0e09ee] - (SEMVER-MINOR) util: expose diff function used by the assertion errors (Giovanni Bucci) #57462
- [
673a424180] - (SEMVER-MINOR) v8: add v8.getCppHeapStatistics() method (Aditi) #57146
- [
4991e5d826] - (SEMVER-MINOR) zlib: add zstd support (Jan Martin) #52100
List of included PRs
- assert: improve partialDeepStrictEqual #57509
- assert: improve partialDeepStrictEqual #57370
- assert: improve partialDeepStrictEqual #57370
- assert: improve myers diff performance #57279
- assert: improve partialDeepStrictEqual #57370
- assert: improve partialDeepStrictEqual #57370
- assert: improve partialDeepStrictEqual #57370
- assert: improve partialDeepStrictEqual #57370
- benchmark: add a warmup on bench-openSync #57051
- build: fix update-wpt workflow #57468
- build: fix compatibility with V8's
depot_tools #57330
- build: print 'Formatting Markdown...' for long task markdown formatting #57108
- build: fix GN build failure #57013
- build: fix GN build of uv #56955
- build: remove explicit linker call to libm on macOS #56901
- build: remove explicit linker call to libm on macOS #56901
- build: link with Security.framework in GN build #56895
- build: do not put commands in sources variables #56885
- build: add double quotes around <(python) #56826
- build: add build option suppress_all_error_on_warn #56647
- build,win: disable node pch with ccache #57224
- Enable ccache on Windows v2 #56847
- doc: clarify --cpu-prof-name allowed values #57433
- cli: allow --cpu-prof* in NODE_OPTIONS #57018
- crypto: ensure expected JWK alg in SubtleCrypto.importKey RSA imports #57450
- crypto: update root-certificates to 3.108 #57381
- crypto: add support for intermediate certs in --use-system-ca #57164
- crypto: support --use-system-ca on non-Windows and non-macOS #57009
- crypto: fix missing
OPENSSL_NO_ENGINE guard #57012
- crypto: cleanup root certificates and skip PEM deserialization #56999
- crypto: support --use-system-ca on Windows #56833
- crypto: fix X509* leak in --use-system-ca #56832
- Expose security levels #56601
- feat: added support for reading certificates from macOS system store #56599
- debugger: fix behavior of plain object exec in debugger repl #57498
- deps: update c-ares to v1.34.5 #57792
- [v23.x] deps: update undici to 6.21.2 #57442
- deps: V8: cherry-pick c172ffc5bf54 #57437
- deps: update googletest to 0bdccf4 #57380
- deps: update acorn to 8.14.1 #57382
- deps: update amaro to 0.4.1 #57121
- deps: update amaro to 0.3.2 #56916
- deps: update amaro to 0.3.1 #56785
- deps: update simdjson to 3.12.2 #57084
- deps: update OpenSSL to 3.0.16 #57335
- deps: update OpenSSL to 3.0.16 #57335
- deps: update corepack to 0.32.0 #57265
- Fix
--with-quic builds #57225
- deps: update cjs-module-lexer to 2.1.0 #57180
- deps: update ngtcp2 to 1.11.0 #57179
- deps: update sqlite to 3.49.1 #57178
- deps: update zlib to 1.3.0.1-motley-788cb3c #56655
- deps: update sqlite to 3.49.0 #56654
- deps: V8: cherry-pick 9ab40592f697 #56781
- deps: update cjs-module-lexer to 2.0.0 #56855
- deps: update timezone to 2025a #56876
- deps: update simdjson to 3.12.0 #56874
- deps: update googletest to e235eb3 #56873
- deps: update simdjson to 3.11.6 #56250
- zlib: add zstd support #52100
- dns: restore dns query cache ttl #57640
- dns: remove redundant code using common variable #57386
- dns: add TLSA record query support #52983
- doc: add gurgunday as triager #57594
- doc: clarify behaviour of node-api adjust function #57463
- doc: remove Corepack documentation #57635
- Update
--require docs #57620
- doc: mention reports should align with Node.js CoC #57607
- doc: add section stating that very stale PRs should be closed #57541
- docs: add bjohansebas as triager #57564
- doc: update support channels #57538
- doc: remove cryptoStream API reference #57579
- docs: module resolution pseudocode corrections #57080
- doc: add history entry for DEP0190 in
child_process.md #57544
- doc: remove deprecated pattern in
child_process.md #57568
- doc: mark multiple long-time experimental APIs as stable #57510
- doc: remove @mertcanaltin from Triagers #57531
- doc: recommend watching the collaborators repo in the onboarding doc #57527
- doc: remove mention of visa fees from onboarding doc #57526
- doc: deprecate passing
args to spawn and execFile #57389
- doc: remove some inconsistencies in
deprecations.md #57512
- doc: run license-builder #57511
- doc: add new writing-docs contributing md #57502
- doc: add node.js streams references to Web Streams doc #57393
- doc: prefer to sign commits under nodejs repository #57311
- doc: fix the incorrect splitting of multiple words #57454
- doc: add review guidelines for collaborator nominations #57449
- doc: add history info for --use-system-ca #57432
- doc: remove typo YAML snippet from tls.getCACertificates doc #57459
- doc: fix typo in sqlite.md #57473
- doc: explicit mention arbitrary code execution as a vuln #57426
- doc: update maintaining-openssl.md for openssl #57413
- doc: add deprecation mark to some documents in fs module #57384
- doc: add note about sync nodejs-private branches #57404
- doc: update Xcode version used for arm64 and pkg #57104
- deps: update amaro to 0.3.2 #56916
- deps: update amaro to 0.3.2 #56916
- doc: make first parameter optional in
util.getCallSites #57387
- doc: fix usage of module.registerSync in comment #57328
- doc: add Darshan back as voting TSC member #57402
- doc: revise webcrypto.md types, interfaces, and added versions #57376
- doc: add info on how project manages social media #57318
- doc: revise
tsconfig.json note #57353
- doc: use more clear name in getSystemErrorMessage's example #57310
- doc: recommend setting
noEmit: true in tsconfig.json #57320
- doc: ping nodejs/tsc for each security pull request #57309
- doc: fix Windows ccache section position #57326
- doc: update node-api version matrix #57287
- doc: TypeScript docs should recommend
erasableSyntaxOnly #57271
- doc: clarify path.isAbsolute is not enough for mitigating path traversals #57073
- doc: fix rendering of DEP0174 description #56835
- doc: add 1ilsang to triage team #57183
- doc: add @geeksilva97 to collaborators #57241
- doc: add missing assert return types #57219
- #57169 fix/streamResetBurst-and-streamResetRate-options-are-missing-in-the-documentation-of-http2.CreateSecureServer #57195
- doc: add esm examples to
node:util #56793
- docs: update options in filehandle.appendFile() #56972
- doc: add additional caveat for fs.watch #57150
- doc: fix typo in Windows building instructions #57158
- doc fix web.libera.chat link in pull-requests.md #57076
- doc: remove buffered flag from performance hooks examples #52607
- doc,test: fix docs/api copy #57109
- doc: fix link and history of
SourceMap sections #57098
- doc: add
module namespace object links #57093
- doc: disambiguate pseudo-code statement #57092
- doc: update clang-cl on Windows building guide #57087
- doc: fix wrong articles used to address modules #57090
- doc:
modules.md: fix distance definition #57046
- doc: fix wrong verb form #57091
- doc: fix transpiler loader hooks documentation #57037
- doc: update testing documentation #56953
- doc: recommend writing tests in new files and including comments #57028
- doc: improve documentation on argument validation #56954
- doc: buffer: fix typo on
Buffer.copyBytesFrom( offset option #57015
- doc: update cleanup to trust on vuln db automation #57004
- doc: move stability index after history section for consistency #56997
- doc: update options to include signal in filehandle.writeFile() #56804
- doc: run license-builder #56985
- doc: update history of stream.Readable.toWeb() #56928
- doc: make MDN links to global classes more consistent in other files #56924
- doc: make MDN links to global classes more consistent in
assert.md #56920
- doc: make MDN links to global classes more consistent in
worker_threads.md #56923
- doc: make MDN links to global classes more consistent in
util.md #56922
- doc: make MDN links to global classes more consistent in
buffer.md #56921
- doc: update post sec release process #56907
- doc: update websocket link to avoid linking to self #56897
- doc: mark
--env-file-if-exists flag as experimental #56893
- doc: fix typo in cjs example of
util.styleText #56769
- doc: clarify sqlite user-defined function behaviour #56786
- doc: correct customization hook types & clarify descriptions #56454
- events: getMaxListeners detects 0 listeners #56807
- fs: apply exclude function to root path #57420
- fs: handle UV_ENOTDIR in
is_uv_error_except_no_entry #56996
- fs: make
FileHandle.readableWebStream always create byte streams #55461
- http: coerce content-length to number #57458
- http: be more generational GC friendly #56767
- inspector: convert event params to protocol without json #57027
- inspector: skip promise hook in the inspector async hook #57148
- inspector: add Network.Initiator in inspector protocol #56805
- inspector: fix GN build #56798
- inspector: fix StringUtil::CharacterCount for unicodes #56788
- lib: add warning when binding inspector to public IP #55736
- lib: limit split function calls to prevent excessive array length #57501
- lib: make getCallSites sourceMap option truly optional #57388
- lib: optimize priority queue #57100
- lib: fixup incorrect argument order in assertEncoding #57177
- meta: add some clarification to the nomination process #57503
- meta: remove collaborator self-nomination #57537
- meta: edit collaborator nomination process #57483
- meta: remove ovflowd as collaborator #57443
- meta: bump codecov/codecov-action from 5.3.1 to 5.4.0 #57257
- meta: bump github/codeql-action from 3.28.8 to 3.28.10 #57254
- meta: bump ossf/scorecard-action from 2.4.0 to 2.4.1 #57253
- meta: move RaisinTen back to collaborators, triagers and SEA champion #57292
- meta: bump actions/download-artifact from 4.1.8 to 4.1.9 #57260
- meta: bump peter-evans/create-pull-request from 7.0.6 to 7.0.7 #57259
- meta: bump step-security/harden-runner from 2.10.4 to 2.11.0 #57258
- meta: bump actions/cache from 4.2.0 to 4.2.2 #57256
- meta: bump actions/upload-artifact from 4.6.0 to 4.6.1 #57255
- meta: Bump actions/setup-python from 5.3.0 to 5.4.0 #56867
- meta: Bump peter-evans/create-pull-request from 7.0.5 to 7.0.6 #56866
- meta: Bump mozilla-actions/sccache-action from 0.0.6 to 0.0.7 #56865
- meta: Bump codecov/codecov-action from 5.0.7 to 5.3.1 #56864
- meta: Bump step-security/harden-runner from 2.10.2 to 2.10.4 #56863
- meta: Bump actions/cache from 4.1.2 to 4.2.0 #56862
- meta: Bump actions/stale from 9.0.0 to 9.1.0 #56860
- meta: Bump github/codeql-action from 3.27.5 to 3.28.8 #56859
- meta: add CODEOWNERS for SQLite #57147
- meta: update last name for jkrems #57006
- meta: Bump actions/upload-artifact from 4.4.3 to 4.6.0 #56861
- meta: Bump actions/setup-node from 4.1.0 to 4.2.0 #56868
- meta: move one or more collaborators to emeritus #56889
- meta: add @nodejs/url as codeowner #56783
- module: handle cached linked async jobs in require(esm) #57187
- module: add dynamic file-specific ESM warnings #56628
- module: improve error message from asynchronicity in require(esm) #57126
- module: allow omitting context in synchronous next hooks #57056
- module: prevent crashes in require.resolve() when path is not a string #56942
- module: fixing url change in load sync hook chain #56402
- implement module.registerHooks() to run synchronous module customization hooks in thread #55698
- implement module.registerHooks() to run synchronous module customization hooks in thread #55698
- net: validate non-string host for
socket.connect #57198
- net: replace brand checks with identity checks #57341
- net: emit an error when custom lookup resolves a non-string address #57192
- process: add execve #56496
- readline: add support for
Symbol.dispose #57276
- readline: fix unresolved promise on abortion #54030
- sea: suppress builtin warning with disableExperimentalSEAWarning option #57086
- sqlite: add support for unknown named parameters #57552
- sqlite: add DatabaseSync.prototype.isOpen #57522
- sqlite: add DatabaseSync.prototype[Symbol.dispose]() #57506
- sqlite: restore changes from #55373 #56908
- sqlite: allow returning
ArrayBufferViews from user-defined functions #56790
- sqlite,test,doc: accept Buffer and URL as paths #56991
- src: cleanup aliased_buffer.h #57395
- src: do not pass
nullptr to std::string ctor #57354
- src: fix process exit listeners not receiving unsettled tla codes #56872
- src: refactor SubtleCrypto algorithm and length validations #57319
- src: allow embedder customization of
OOMErrorHandler #57325
- src: use Maybe<void> in ProcessEmitWarningSync #57250
- src: make even more improvements to error handling #57264
- src: use cached
emit string #57249
- src: refactor SubtleCrypto algorithm and length validations #57273
- src: make more error handling improvements #57262
- src: fix typo in comment #57291
- src: improve error handling in tcp_wrap.cc #57211
- src: improve error handling in tcp_wrap.cc #57211
- src: improve error handling in tcp_wrap.cc #57211
- src: fix ThrowInvalidURL call in PathToFileURL #57141
- src: improve error handling in buffer and dotenv #57189
- src: improve error handling in module_wrap #57188
- src: improve error handling in spawn_sync #57185
- src: add a method to get string encoding info #56147
- src: fix crash when lazy getter is invoked in a vm context #57168
- module: improve error message from asynchronicity in require(esm) #57126
- src: move instead of copy shared pointer in node_blob #57120
- src: replace NewFromUtf8 with OneByteString where appropriate #57096
- src: port
defineLazyProperties to native code #57081
- src: improve error handling in node_blob #57078
- src: fix accessing empty string #57014
- src: lock the isolate properly in IsolateData destructor #57031
- src: add self-assigment memcpy checks #56986
- src: improve node::Dotenv trimming #56983
- src: improve error handling in string_bytes/decoder #56978
- src: improve error handling in process_wrap #56977
- src: use
args.This() in zlib #56988
- src: add nullptr handling for
NativeKeyObject #56900
- src: disallow copy/move fns/constructors #56811
- inspector: add Network.Initiator in inspector protocol #56805
- src: improve error handling in multiple c++ files #56915
- src: improve error handling in permission.cc #56904
- src: improve error handling in node_sqlite #56891
- src: improve error handling in node_os by removing ToLocalChecked #56888
- src: improve error handling in node_url #56886
- src: add check for Bignum in GroupOrderSize #56702
- src: reduce string allocations on sqlite #57227
- stream: fix
sizeAlgorithm validation in WritableStream #57280
- test: buffer.indexOf: add more number cases #57200
- test: update parallel/test-tls-dhe for OpenSSL 3.5 #57477
- deps: update amaro to 0.4.1 #57121
- deps: update amaro to 0.3.2 #56916
- test: refactor test runner run plan tests #57304
- test: update WPT for WebCryptoAPI to edd42c005c #57365
- test: simplify test-tls-connect-abort-controller.js #57338
- test: use
assert.match in test-esm-import-meta #57290
- test: update compression wpt #56960
- Revert "test: temporary remove resource check from fs read-write" #56906
- test: more common.mustNotCall in net #57246
- test: swap assert.strictEqual() parameters #57217
- test: assert write return values in buffer-bigint64 #57212
- test: allow embedder running async context frame test #57193
- test: resolve race condition in test-net-write-fully-async-* #57022
- docs: update options in filehandle.appendFile() #56972
- test: fix test-without-async-context-frame.mjs in debug mode #57034
- test: make eval snapshot comparison more flexible #57020
- test: simplify test-http2-client-promisify-connect-error #57144
- test: improve error output of test-http2-client-promisify-connect-error #57135
- test: add case for unrecognised fields within pjson "exports" #57026
- test: remove unnecessary assert requiring from tests #57008
- test: remove flakiness on macOS test #56971
- test: remove flakiness on macOS test #56971
- test: improve timeout duration for debugger events #56970
- test: remove unnecessary syscall to cpuinfo #56968
- test: update webstorage wpt #56963
- test: execute shell directly for refresh() #55051
- test: change jenkins reporter #56808
- test: fix race condition in test-child-process-bad-stdio #56845
- test: adjust check to use OpenSSL sec level #56819
- test: test-crypto-scrypt.js doesn't need internals #56673
- test: set
test-fs-cp as flaky #56799
- test: convert test_encoding_binding.cc to a JS test #56791
- test: convert test_encoding_binding.cc to a JS test #56791
- test: test-crypto-prime.js doesn't use internals anymore #56675
- test: temporary remove resource check from fs read-write #56789
- test: mark test-without-async-context-frame flaky on windows #56753
- test: remove unnecessary code #56784
- test: mark
test-esm-loader-hooks-inspect-wait flaky #56803
- test: update WPT for url to a23788b77a #56779
- Chore/remove test reporter duplicate #56739
- test,crypto: make tests work for BoringSSL #57021
- test_runner: add timeout support to test plan #56765
- test_runner: differentiate test types in enqueue dequeue events #54049
- test_runner: print formatted errors on summary #56911
- test_runner: allow special characters in snapshot keys #57017
- timers: optimize timer functions with improved argument handling #57072
- timers: remove unnecessary allocation of _onTimeout #57497
- timers: remove unused parameter from insertGuarded #57251
- timers: simplify the compareTimersLists function #57110
- tls: remove unnecessary type check on normalize #57336
- tls: implement tls.getCACertificates() #57107
- tools: fix WPT update cron string #57665
- tools: remove stalled label on unstalled issues and PRs #57630
- tools: update sccache to support GH cache changes #57573
- tools: bump @babel/helpers from 7.26.9 to 7.26.10 in /tools/eslint #57444
- tools: add config subsystem #57239
- tools: import rather than require ESLint plugins #57315
- tools: switch back to official OpenSSL #57301
- tools: revert to use @stylistic/eslint-plugin-js v3 #57314
- tools: add more details about rolling inspector_protocol #57167
- tools: bump the eslint group in /tools/eslint with 5 updates #57261
- tools: remove deps/zlib/GN-scraper.py #57238
- tools: run Linux tests on GitHub arm64 runners as well #57162
- doc,test: fix docs/api copy #57109
- tools: do not run major-release workflow on forks #57064
- tools: fix release URL computation in update-root-certs.mjs #56843
- tools: add support for
import source syntax in linter #56992
- tools: Bump the eslint group in /tools/eslint with 5 updates #56869
- tools: remove test-asan/ubsan workflows #56823
- tools: run macOS test workflow with Xcode 16.1 #56831
- tools: update sccache and sccache-action #56815
- tools: fix license-builder for inspector_protocol #56814
- lib: fix ImportModuleDynamicallyCallback return type declaration #57160
- util: avoid run debug when enabled is false #57494
- util: expose diff function used by the assertion errors #57462
- util: enforce shouldColorize in styleText array arg #56722
- v8: add v8.getCppHeapStatistics() method #57146
- win,build: add option to enable cfg #56605
- win,test: disable test case failing with ClangCL #57397
- zlib: use modern class syntax for zstd classes #56965
- zlib: make all zstd functions experimental #56964
- zlib: add zstd support #52100
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Review requested:
- @nodejs/actions
- @nodejs/releasers
- @nodejs/security-wg
- @nodejs/tsc
- @nodejs/v8-update
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
added
release
Issues and PRs related to Node.js releases.
v22.x
Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
labels
Apr 11, 2025
RafaelGSS
added a commit
that referenced
this pull request
Apr 11, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
assert,util:
* (SEMVER-MINOR) improve performance (Ruben Bridgewater) #57370
benchmark:
* (SEMVER-MINOR) adjust assert runtimes (Ruben Bridgewater) #57370
* (SEMVER-MINOR) skip running some assert benchmarks by default (Ruben Bridgewater) #57370
* (SEMVER-MINOR) add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
* (SEMVER-MINOR) update ada to v3.0.1 (Yagiz Nizipli) #56452
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
test:
* (SEMVER-MINOR) add WPT for URLPattern (Yagiz Nizipli) #56452
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
url:
* (SEMVER-MINOR) add URLPattern implementation (Yagiz Nizipli) #56452
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It seems #57289 is the commit that broke the build on v22.x-staging. I'll drop it
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
added a commit
that referenced
this pull request
Apr 14, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
assert,util:
* (SEMVER-MINOR) improve performance (Ruben Bridgewater) #57370
benchmark:
* (SEMVER-MINOR) adjust assert runtimes (Ruben Bridgewater) #57370
* (SEMVER-MINOR) skip running some assert benchmarks by default (Ruben Bridgewater) #57370
* (SEMVER-MINOR) add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
* (SEMVER-MINOR) update ada to v3.0.1 (Yagiz Nizipli) #56452
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
test:
* (SEMVER-MINOR) add WPT for URLPattern (Yagiz Nizipli) #56452
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
url:
* (SEMVER-MINOR) add URLPattern implementation (Yagiz Nizipli) #56452
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
RafaelGSS
changed the title
2025-04-15, Version 22.15.0 'Jod' (LTS), @RafaelGSS
2025-04-16, Version 22.15.0 'Jod' (LTS), @RafaelGSS
Apr 15, 2025
RafaelGSS
added a commit
that referenced
this pull request
Apr 15, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
assert,util:
* (SEMVER-MINOR) improve performance (Ruben Bridgewater) #57370
benchmark:
* (SEMVER-MINOR) adjust assert runtimes (Ruben Bridgewater) #57370
* (SEMVER-MINOR) skip running some assert benchmarks by default (Ruben Bridgewater) #57370
* (SEMVER-MINOR) add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
* (SEMVER-MINOR) update ada to v3.0.1 (Yagiz Nizipli) #56452
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
test:
* (SEMVER-MINOR) add WPT for URLPattern (Yagiz Nizipli) #56452
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
url:
* (SEMVER-MINOR) add URLPattern implementation (Yagiz Nizipli) #56452
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
commented
Apr 16, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
added a commit
that referenced
this pull request
Apr 16, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
assert,util:
* (SEMVER-MINOR) improve performance (Ruben Bridgewater) #57370
benchmark:
* (SEMVER-MINOR) adjust assert runtimes (Ruben Bridgewater) #57370
* (SEMVER-MINOR) skip running some assert benchmarks by default (Ruben Bridgewater) #57370
* (SEMVER-MINOR) add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
the trimming functionality that the dotenv parsing uses currently
only takes into consideration plain spaces (' '), other type of
space characters such as tabs and newlines are not trimmed, this
can cause subtle bugs, so the changes here make sure that such
characters get trimmed as well
Co-authored-by: Yagiz Nizipli <[email protected]>
PR-URL: #56983
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS
added a commit
that referenced
this pull request
Apr 18, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
assert,util:
* (SEMVER-MINOR) improve performance (Ruben Bridgewater) #57370
benchmark:
* (SEMVER-MINOR) adjust assert runtimes (Ruben Bridgewater) #57370
* (SEMVER-MINOR) skip running some assert benchmarks by default (Ruben Bridgewater) #57370
* (SEMVER-MINOR) add assert partialDeepStrictEqual benchmark (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
RafaelGSS
changed the title
2025-04-16, Version 22.15.0 'Jod' (LTS), @RafaelGSS
2025-04-16, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS
Apr 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
RafaelGSS
changed the title
2025-04-16, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS
Apr 18, 2025
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the hard work preparing this release @RafaelGSS ❤️.
I will do the promotion early on my morning 👍
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
richardlau and mhdawson reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
UlisesGascon
pushed a commit
that referenced
this pull request
Apr 23, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
This was referenced Apr 24, 2025
RafaelGSS
added a commit
that referenced
this pull request
May 1, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
RafaelGSS
added a commit
that referenced
this pull request
May 2, 2025
Notable changes:
assert:
* (SEMVER-MINOR) implement partial error comparison (Ruben Bridgewater) #57370
* (SEMVER-MINOR) improve partialDeepStrictEqual (Ruben Bridgewater) #57370
cli:
* (SEMVER-MINOR) allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018
crypto:
* update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381
* (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
* (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
* update timezone to 2025a (Node.js GitHub Bot) #56876
deps,tools:
* (SEMVER-MINOR) add zstd 1.5.6 (Jan Martin) #52100
dns:
* (SEMVER-MINOR) add TLSA record query and parsing (Rithvik Vibhu) #52983
doc:
* add @geeksilva97 to collaborators (Edy Silva) #57241
module:
* (SEMVER-MINOR) use synchronous hooks for preparsing in import(cjs) (Joyee Cheung) #55698
* (SEMVER-MINOR) implement module.registerHooks() (Joyee Cheung) #55698
process:
* (SEMVER-MINOR) add execve (Paolo Insogna) #56496
* (SEMVER-MINOR) add threadCpuUsage (Paolo Insogna) #56467
sqlite:
* (SEMVER-MINOR) add StatementSync.prototype.columns() (Colin Ihrig) #57490
* (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
* set signal inspector io thread name (RafaelGSS) #56416
* set thread name for main thread and v8 worker (RafaelGSS) #56416
* set worker thread name using worker.name (RafaelGSS) #56416
* use a default thread name for inspector (RafaelGSS) #56416
tls:
* (SEMVER-MINOR) implement tls.getCACertificates() (Joyee Cheung) #57107
util:
* (SEMVER-MINOR) expose diff function used by the assertion errors (Giovanni Bucci) #57462
v8:
* (SEMVER-MINOR) add v8.getCppHeapStatistics() method (Aditi) #57146
zlib:
* (SEMVER-MINOR) add zstd support (Jan Martin) #52100
PR-URL: #57840
Reviewers
aduh95
aduh95 approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Labels
release
Issues and PRs related to Node.js releases.
v22.x
Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|