GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update `buffer.constants.MAX_LENGTH` size by samuliasmala · Pull Request #54207 · nodejs/node

Conversation

@samuliasmala

@samuliasmala samuliasmala commented Aug 4, 2024

Copy link
Copy Markdown
Contributor

Starting from Node v22.0.0 (which uses V8 12.4) the buffer.constants.MAX_LENGTH has been increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14. If I read it right the change was done in this commit to V8 engine.

The change is also easy to verify manually:

Welcome to Node.js v21.7.3.
Type ".help" for more information.
> (require('buffer').constants.MAX_LENGTH) / 2**30
4

Welcome to Node.js v22.0.0.
Type ".help" for more information.
> (require('buffer').constants.MAX_LENGTH + 1) / 2**30
8388608
> (require('buffer').constants.MAX_LENGTH + 1) / 2**40
8192
>

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and avivkeller reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Aug 4, 2024
@samuliasmala
doc: update buffer.constants.MAX_LENGTH size
5b72f63 
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been
increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.
@samuliasmala
samuliasmala force-pushed the doc-update-buffer-max-length branch from 7c5af98 to 5b72f63 Compare August 5, 2024 05:32
@samuliasmala

samuliasmala commented Aug 5, 2024

Copy link
Copy Markdown
Contributor Author

Updated the commit message to adhere 72 characters per line limit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jakecastelli
jakecastelli approved these changes Aug 6, 2024
View reviewed changes
trivikr
trivikr approved these changes Aug 9, 2024
View reviewed changes
lpinca
lpinca approved these changes Aug 9, 2024
View reviewed changes
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 9, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 19bf154 into nodejs:main Aug 9, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

Landed in 19bf154
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Aug 14, 2024
@samuliasmala @targos
doc: update buffer.constants.MAX_LENGTH size
971b9f3 
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been
increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.

PR-URL: #54207
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
v22.7.0 proposal #54452
Merged
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
@coderabbitai coderabbitai Bot mentioned this pull request Jun 26, 2026
feat(protocol,onebot): raise video size limit to 1.5GB with Highway-first fallback Stlara-F/SnowLuma#35
Merged
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@trivikr trivikr trivikr approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@samuliasmala @nodejs-github-bot @lpinca @trivikr @jakecastelli @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.