GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update V8 to 12.4 by targos · Pull Request #52465 · nodejs/node

Conversation

@targos

@targos targos commented Apr 11, 2024

Copy link
Copy Markdown
Member

May replace #52293 directly if it doesn't introduce more build issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, MomenNano, avivkeller, melroy89, derhuerst, alexnault, Jokero, and maRci002 reacted with hooray emoji bricss, MomenNano, and tonivj5 reacted with heart emoji bricss and MomenNano reacted with rocket emoji bricss reacted with eyes emoji
All reactions
  • 🎉 8 reactions
  • ❤️ 3 reactions
  • 🚀 2 reactions
  • 👀 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 11, 2024
@targos targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 11, 2024
@targos targos mentioned this pull request Apr 11, 2024
deps: update V8 to 12.3 #52293
Closed
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 11, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58270/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5914/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5914/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5914/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos mentioned this pull request Apr 13, 2024
2024-04-24, Version 22.0.0 (Current) #52505
Merged
@melroy89

melroy89 commented Apr 17, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Uh, is Windows build now failing in CICD now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added 10 commits April 19, 2024 12:51
@targos
deps: update V8 to 12.4.254.14
d887f85
@targos
build: reset embedder string to "-node.0"
e4c6f08
@targos
src: update NODE_MODULE_VERSION to 127
8d1bbf8
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 12.4.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
@targos
deps: always define V8_EXPORT_PRIVATE as no-op
88a4285
dllexport introduces issues when compiling with MSVC.

PR-URL: nodejs#47251
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos
deps: silence irrelevant V8 warning
a41d78c
PR-URL: nodejs#45579
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
deps: disable V8 concurrent sparkplug compilation
1999abf
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.

Refs: nodejs#47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: nodejs#47450
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
deps: avoid compilation error with ASan
6be9104
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=14221
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos
deps: remove usage of a C++20 feature from V8
915255b
We are not ready to compile with C++20 support yet.
This is only a DCHECK that can be removed without affecting the behavior
of release builds.

PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos
deps: patch V8 to avoid duplicated zlib symbol
c09d25f
PR-URL: nodejs#49639
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@targos
deps: silence internal V8 deprecation warning
2aa1874
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@targos
targos force-pushed the v8-124 branch from 4236aff to 3cf6888 Compare April 19, 2024 10:56
@targos

targos commented Apr 19, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@StefanStojanovic I updated the PR after #52293 landed.

StefanStojanovic reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 19, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 19, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58521/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5927/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
@targos @RafaelGSS
deps: silence internal V8 deprecation warning
5bde9e6
PR-URL: #52293
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
@StefanStojanovic @RafaelGSS
build: compile with C++20 support on Windows
2b1e7c2
Our Linux build infra is not ready for it yet,
but V8 is making it difficult to compile on Windows
without it.

Refs: #45402
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
@StefanStojanovic @RafaelGSS
deps: patch V8 to support compilation with MSVC
3795e97
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
@targos @RafaelGSS
deps: V8: revert CL 5331688
521b629
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
@joyeecheung @RafaelGSS
deps: V8: cherry-pick cd10ad7cdbe5
30801b8
Original commit message:

    [compiler] reset script details in functions deserialized from code cache

    During the serialization of the code cache, V8 would wipe out the
    host-defined options, so after a script id deserialized from the
    code cache, the host-defined options need to be reset on the script
    using what's provided by the embedder when doing the deserializing
    compilation, otherwise the HostImportModuleDynamically callbacks
    can't get the data it needs to implement dynamic import().

    Change-Id: I33cc6a5e43b6469d3527242e083f7ae6d8ed0c6a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5401780
    Reviewed-by: Leszek Swirski <[email protected]>
    Commit-Queue: Joyee Cheung <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#93323}

Refs: v8/v8@cd10ad7
PR-URL: #52535
Refs: #47472
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 22, 2024
@targos @RafaelGSS
tools: update V8 gypfiles for 12.4
5def801
Refs: v8/v8@6196de8
Refs: v8/v8@4af6461
Refs: v8/v8@7ba16ea
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS added a commit that referenced this pull request Apr 22, 2024
@RafaelGSS @marco-ippolito
2024-04-24, Version 22.0.0 (Current)
b069af2
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Apr 23, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
0234865
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos added a commit that referenced this pull request Apr 23, 2024
@targos
deps: V8: revert CL 5331688
305963a
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 23, 2024
@StefanStojanovic @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
8493c83
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 23, 2024
@targos @nodejs-github-bot
deps: V8: revert CL 5331688
2eb13f7
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito added a commit that referenced this pull request Apr 23, 2024
@RafaelGSS @marco-ippolito
2024-04-24, Version 22.0.0 (Current)
12fb157
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <[email protected]>
targos pushed a commit that referenced this pull request Apr 24, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
16c825c
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos added a commit that referenced this pull request Apr 24, 2024
@targos
deps: V8: revert CL 5331688
bfefc6c
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 24, 2024
@StefanStojanovic @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
efa6aed
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 24, 2024
@targos @nodejs-github-bot
deps: V8: revert CL 5331688
3c67b13
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS added a commit that referenced this pull request Apr 24, 2024
@RafaelGSS @marco-ippolito
2024-04-24, Version 22.0.0 (Current)
d40d21c
Semver-Major Commits:

build:
  * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362
  * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115
console:
  * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722
crypto:
  * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071
  * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880
  * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973
deps:
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465
  * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293
  * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293
  * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362
  * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362
  * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115
  * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115
  * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115
  * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115
  * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115
  * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115
  * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115
doc:
  * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179
  * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231
  * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488
fs:
  * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067
  * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037
  * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908
http:
  * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394
lib:
  * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594
lib,test:
  * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362
process:
  * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172
src:
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293
  * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362
  * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115
  * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115
  * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115
stream:
  * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037
test:
  * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362
  * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362
  * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115
  * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115
  * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115
test_runner:
  * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221
  * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577
tools:
  * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465
  * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362
  * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362
trace_events:
  * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180
util:
  * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488
  * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488
v8:
  * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360

PR-URL: #52505
Co-Authored-By: Marco Ippolito <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 25, 2024
@StefanStojanovic @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
ab212f2
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 25, 2024
@targos @nodejs-github-bot
deps: V8: revert CL 5331688
db631b7
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 26, 2024
@StefanStojanovic @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
f91c776
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 26, 2024
@targos @nodejs-github-bot
deps: V8: revert CL 5331688
fc2a2d5
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 27, 2024
@StefanStojanovic @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
d44c112
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 27, 2024
@targos @nodejs-github-bot
deps: V8: revert CL 5331688
1b2db61
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit that referenced this pull request Apr 27, 2024
@StefanStojanovic @targos
deps: patch V8 to support compilation with MSVC
66f4821
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos added a commit that referenced this pull request Apr 27, 2024
@targos
deps: V8: revert CL 5331688
dfd4b9b
On Windows debug builds, it is not allowed to dereference empty
iterators.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5331688
PR-URL: #52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Apr 27, 2024
@StefanStojanovic @nodejs-github-bot
deps: patch V8 to support compilation with MSVC
e38b493
After enabling -std:c++20 on Windows, patch is now much smaller.

PR-URL: nodejs/node#52465
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@samuliasmala samuliasmala mentioned this pull request Aug 4, 2024
doc: update buffer.constants.MAX_LENGTH size #54207
Merged
@robobun robobun mentioned this pull request Sep 6, 2026
node:buffer: match Node on fill/compare start offsets, detached indexOf, and inspect extras oven-sh/bun#41498
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@targos @nodejs-github-bot @melroy89 @StefanStojanovic @Liljz8 @avivkeller @mcollina @mhdawson @RafaelGSS @joyeecheung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.