GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — os: improve `tmpdir` performance by anonrig · Pull Request #54709 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Sep 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Improves the performance of tmpdir() by moving the implementation to C++ and reducing the communication count between C++ and JS.

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1632/

                       confidence improvement accuracy (*)   (**)  (***)
os/tmpdir.js n=1000000        ***      6.27 %       ±0.22% ±0.29% ±0.38%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CarlosEduR, bricss, tonivj5, Jayllyz, daniellockyer, pi0, and szmarczak reacted with rocket emoji
All reactions
  • 🚀 7 reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Sep 2, 2024
@anonrig
anonrig force-pushed the yagiz/improve-tmpdir-performance branch from 402ecf4 to 00cae50 Compare September 2, 2024 00:34
@avivkeller avivkeller added the needs-benchmark-ci PRs that need a benchmark CI run. label Sep 2, 2024
@codecov

codecov Bot commented Sep 2, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.90%. Comparing base (22ea302) to head (dfe018e).
Report is 162 commits behind head on main.

Files with missing lines Patch % Lines
src/node_credentials.cc 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54709   +/-   ##
=======================================
  Coverage   87.89%   87.90%           
=======================================
  Files         651      651           
  Lines      183364   183375   +11     
  Branches    35714    35714           
=======================================
+ Hits       161171   161194   +23     
+ Misses      15465    15459    -6     
+ Partials     6728     6722    -6
Files with missing lines Coverage Δ
lib/os.js 97.34% <100.00%> (-0.04%) ⬇️
src/node_credentials.cc 70.69% <94.11%> (+1.55%) ⬆️

... and 19 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the yagiz/improve-tmpdir-performance branch 3 times, most recently from 9e8c1be to 7b5f0c9 Compare September 2, 2024 02:07
@avivkeller

This comment was marked as outdated.

Sign in to view
@anonrig

This comment was marked as outdated.

Sign in to view
@anonrig
anonrig force-pushed the yagiz/improve-tmpdir-performance branch 2 times, most recently from 2824662 to 111828d Compare September 5, 2024 14:56
@anonrig
anonrig requested review from RafaelGSS, jasnell, mcollina and targos September 5, 2024 15:47
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig

anonrig commented Sep 5, 2024

Copy link
Copy Markdown
Member Author

cc @nodejs/cpp-reviewers
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Sep 5, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell
jasnell approved these changes Sep 5, 2024
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Sep 5, 2024
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62114/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62231/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
os: improve tmpdir performance
dfe018e
@anonrig
anonrig force-pushed the yagiz/improve-tmpdir-performance branch from 111828d to dfe018e Compare September 10, 2024 15:03
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62291/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62296/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr reviewed Sep 11, 2024
View reviewed changes
Comment thread lib/os.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig requested a review from jasnell September 11, 2024 13:52
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 11, 2024
trivikr
trivikr approved these changes Sep 11, 2024
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 1d2603b into nodejs:main Sep 11, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in 1d2603b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig @aduh95
os: improve tmpdir performance
48c9ae5 
PR-URL: #54709
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 13, 2024
@anonrig @aduh95
os: improve tmpdir performance
461e523 
PR-URL: #54709
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@trivikr trivikr mentioned this pull request Sep 16, 2024
os: use const with early return for path #54959
Merged
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
v22.9.0 proposal #54966
Merged
@targos targos added the dont-land-on-v20.x label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@trivikr trivikr trivikr approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@targos targos Awaiting requested review from targos
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-benchmark-ci PRs that need a benchmark CI run. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@anonrig @avivkeller @nodejs-github-bot @mcollina @jasnell @trivikr @RafaelGSS @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.