GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add resource to internal module stat test by RafaelGSS · Pull Request #55157 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Sep 28, 2024

Copy link
Copy Markdown
Member

This was missing from #51344

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS
test: add resource to internal module stat test
ee3f3ac
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2024 •
edited by RafaelGSS
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model. label Sep 28, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 28, 2024
@codecov

codecov Bot commented Sep 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (3ac5b49) to head (ee3f3ac).
Report is 175 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55157      +/-   ##
==========================================
+ Coverage   88.07%   88.24%   +0.17%     
==========================================
  Files         652      651       -1     
  Lines      183653   183855     +202     
  Branches    35856    35825      -31     
==========================================
+ Hits       161753   162249     +496     
+ Misses      15146    14921     -225     
+ Partials     6754     6685      -69

see 152 files with indirect coverage changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 28, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62833/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62846/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
RafaelGSS requested a review from anonrig September 30, 2024 14:32
anonrig
anonrig approved these changes Sep 30, 2024
View reviewed changes
@RafaelGSS
fixup! test: add resource to internal module stat test
f02e159
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2024
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62857/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Sep 30, 2024
View reviewed changes
@anonrig
anonrig requested a review from jasnell September 30, 2024 15:12
@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 2, 2024
RafaelGSS added a commit that referenced this pull request Oct 7, 2024
@RafaelGSS
test: add resource to internal module stat test
6c92c13 
PR-URL: #55157
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS

RafaelGSS commented Oct 7, 2024

Copy link
Copy Markdown
Member Author

Landed in 6c92c13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS closed this Oct 7, 2024
aduh95 pushed a commit that referenced this pull request Oct 9, 2024
@RafaelGSS @aduh95
test: add resource to internal module stat test
1b1104e 
PR-URL: #55157
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
V22.10.0 proposal #55343
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@RafaelGSS @nodejs-github-bot @anonrig @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.