GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: add fast api for `InternalModuleStat` by anonrig · Pull Request #51344 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Jan 2, 2024

Copy link
Copy Markdown
Member

Adds V8 Fast API to InternalModuleStat

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
antongolub and bricss reacted with thumbs up emoji bricss reacted with hooray emoji gurgunday, tonivj5, GeoffreyBooth, daniellockyer, and bricss reacted with heart emoji gurgunday, tonivj5, GeoffreyBooth, daniellockyer, and bricss reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 🎉 1 reaction
  • ❤️ 5 reactions
  • 🚀 5 reactions
@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Jan 2, 2024
@nodejs-github-bot

nodejs-github-bot commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jan 2, 2024
H4ad
H4ad approved these changes Jan 2, 2024
View reviewed changes
Comment thread src/node_file.cc Outdated
Comment on lines 1065 to 1058

@H4ad H4ad Jan 2, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking about this, if this is true, it will:

  • ignore the value -1.
  • re-run InternalModuleStat but in the slower version.
  • throw error since the permission is not granted.

I don't know if worthy but maybe one test just to ensure this behavior, maybe a loop and then pass a value that is not allowed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@anonrig anonrig Jun 13, 2024

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test (6 months later)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@H4ad

H4ad commented Jan 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member 
Error: --- stderr ---
npm WARN cli npm v10.2.4 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)
npm ERR! code MODULE_NOT_FOUND
npm ERR! path /home/runner/work/node/node/deps/npm/node_modules/walk-up-path/package.json
npm ERR! Cannot find module '/home/runner/work/node/node/deps/npm/node_modules/walk-up-path/dist/cjs/index.js'

Failing because of the Node version: https://github.com/nodejs/node/actions/runs/7390448695/job/20105393172?pr=51344#step:6:5719

Who we should ping to solve this kind of issue?
anonrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Jan 3, 2024

Copy link
Copy Markdown
Member Author 
Error: --- stderr ---
npm WARN cli npm v10.2.4 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at [https://nodejs.org/.](https://nodejs.org/)
npm ERR! code MODULE_NOT_FOUND
npm ERR! path /home/runner/work/node/node/deps/npm/node_modules/walk-up-path/package.json
npm ERR! Cannot find module '/home/runner/work/node/node/deps/npm/node_modules/walk-up-path/dist/cjs/index.js'

Failing because of the Node version: https://github.com/nodejs/node/actions/runs/7390448695/job/20105393172?pr=51344#step:6:5719

Who we should ping to solve this kind of issue?

cc @nodejs/build @nodejs/npm Any suggestions on how to fix the error?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GeoffreyBooth
GeoffreyBooth approved these changes Jan 3, 2024
View reviewed changes
@wraithgar

wraithgar commented Jan 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There are two separate items in that log. First is a warning that will always show up when you're using a prerelease version of node. This is intentional to remind folks that they're in an unsupported prerelease version of node. npm still will install just fine, the part of npm that prevents itself from being installed globally in an unsupported node version throws a different exception and allows prereleases in its semver check against npm's engines field.

The second error has to do with a missing file that is being required. As to why that file is missing, that's another mystery. It's definitely in the tarball of the published module, and in source control.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Jan 3, 2024

Copy link
Copy Markdown
Member

The error must be related to the changes made in this PR. In other words, there's a bug in the implementation.
wraithgar, richardlau, anonrig, and H4ad reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
fhinkel
fhinkel approved these changes Jan 28, 2024
View reviewed changes
Qard
Qard approved these changes Jan 31, 2024
View reviewed changes
@aduh95

aduh95 commented May 11, 2024

Copy link
Copy Markdown
Contributor

This needs a rebase.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the fast-api-internal-module-stat branch from 11cea33 to 3f32a24 Compare June 13, 2024 21:59
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59772/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the fast-api-internal-module-stat branch from 3f32a24 to 9b6a9f8 Compare June 13, 2024 22:13
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59773/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad approved these changes Jun 13, 2024
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59775/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jun 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59776/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
fs: add fast api for InternalModuleStat
1a71169
@anonrig
anonrig force-pushed the fast-api-internal-module-stat branch from 9b6a9f8 to 1a71169 Compare June 14, 2024 13:22
@nodejs-github-bot

nodejs-github-bot commented Jun 14, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59783/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Jun 16, 2024
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

is this improving startup time in any way?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig

anonrig commented Jun 16, 2024

Copy link
Copy Markdown
Member Author

is this improving startup time in any way?

I don't know, but better ask our friend "benchmark ci": https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1570/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Jun 16, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@mcollina

misc/startup-cli-version.js count=30 cli='deps/corepack/dist/corepack.js'                        ***      0.14 %       ±0.08% ±0.11% ±0.14%
misc/startup-cli-version.js count=30 cli='deps/npm/bin/npm-cli.js'                                        0.07 %       ±0.19% ±0.25% ±0.33%
misc/startup-cli-version.js count=30 cli='deps/npm/bin/npx-cli.js'                               ***      0.31 %       ±0.17% ±0.23% ±0.30%
misc/startup-cli-version.js count=30 cli='tools/node_modules/eslint/bin/eslint.js'               ***     -0.12 %       ±0.05% ±0.06% ±0.08%
misc/startup-core.js count=30 mode='process' script='benchmark/fixtures/require-builtins'          *     -0.45 %       ±0.36% ±0.48% ±0.62%
misc/startup-core.js count=30 mode='process' script='test/fixtures/semicolon'                             2.38 %       ±3.17% ±4.22% ±5.50%
misc/startup-core.js count=30 mode='process' script='test/fixtures/snapshot/typescript'          ***      0.55 %       ±0.05% ±0.06% ±0.08%
misc/startup-core.js count=30 mode='worker' script='benchmark/fixtures/require-builtins'                 -0.20 %       ±0.23% ±0.31% ±0.40%
misc/startup-core.js count=30 mode='worker' script='test/fixtures/semicolon'                              0.06 %       ±0.37% ±0.49% ±0.65%
misc/startup-core.js count=30 mode='worker' script='test/fixtures/snapshot/typescript'                    0.69 %       ±0.85% ±1.13% ±1.47%```
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jun 16, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 1aa8a78 into nodejs:main Jun 16, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

Landed in 1aa8a78
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jun 20, 2024
@anonrig @targos
fs: add fast api for InternalModuleStat
fad1793 
PR-URL: #51344
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@anonrig @soophoo
fs: add fast api for InternalModuleStat
ce8388d 
PR-URL: nodejs#51344
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Jun 25, 2024
v22.4.0 release proposal #53583
Merged
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
## 2024-07-02, Version 22.4.0 (Current), @targos Karliz24/Marley-#16
Open
@targos targos added the dont-land-on-v20.x label Sep 21, 2024
@RafaelGSS RafaelGSS mentioned this pull request Sep 28, 2024
test: add resource to internal module stat test #55157
Closed
codebytere added a commit to electron/electron that referenced this pull request Oct 16, 2024
@codebytere
fs: add fast api for InternalModuleStat
fc6bdce 
nodejs/node#51344
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
@codebytere
fs: add fast api for InternalModuleStat
ce93695 
nodejs/node#51344
codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024
@codebytere
fs: add fast api for InternalModuleStat
2efdd35 
nodejs/node#51344
codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024
@codebytere
fs: add fast api for InternalModuleStat
3253c5b 
nodejs/node#51344
codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024
@codebytere
fs: add fast api for InternalModuleStat
44af7a5 
nodejs/node#51344
codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024
@codebytere
fs: add fast api for InternalModuleStat
884446b 
nodejs/node#51344
codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024
@codebytere
fs: add fast api for InternalModuleStat
638d530 
nodejs/node#51344
jkleinsc pushed a commit to electron/electron that referenced this pull request Nov 4, 2024
@codebytere
chore: bump Node.js to v22.9.0 (#44281)
c63d0d6 
* chore: bump Node.js to v22.9.0

* build: drop base64 dep in GN build

nodejs/node#52856

* build,tools: make addons tests work with GN

nodejs/node#50737

* fs: add fast api for InternalModuleStat

nodejs/node#51344

* src: move package_json_reader cache to c++

nodejs/node#50322

* crypto: disable PKCS#1 padding for privateDecrypt

nodejs-private/node-private#525

* src: move more crypto code to ncrypto

nodejs/node#54320

* crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey

nodejs/node#50234

* src: shift more crypto impl details to ncrypto

nodejs/node#54028

* src: switch crypto APIs to use Maybe<void>

nodejs/node#54775

* crypto: remove DEFAULT_ENCODING

nodejs/node#47182

* deps: update libuv to 1.47.0

nodejs/node#50650

* build: fix conflict gyp configs

nodejs/node#53605

* lib,src: drop --experimental-network-imports

nodejs/node#53822

* esm: align sync and async load implementations

nodejs/node#49152

* esm: remove unnecessary toNamespacedPath calls

nodejs/node#53656

* module: detect ESM syntax by trying to recompile as SourceTextModule

nodejs/node#52413

* test: adapt debugger tests to V8 11.4

nodejs/node#49639

* lib: update usage of always on Atomics API

nodejs/node#49639

* test: adapt test-fs-write to V8 internal changes

nodejs/node#49639

* test: adapt to new V8 trusted memory spaces

nodejs/node#50115

* deps: update libuv to 1.47.0

nodejs/node#50650

* src: use non-deprecated v8::Uint8Array::kMaxLength

nodejs/node#50115

* src: update default V8 platform to override functions with location

nodejs/node#51362

* src: add missing TryCatch

nodejs/node#51362

* lib,test: handle new Iterator global

nodejs/node#51362

* src: use non-deprecated version of CreateSyntheticModule

nodejs/node#50115

* src: remove calls to recently deprecated V8 APIs

nodejs/node#52996

* src: use new V8 API to define stream accessor

nodejs/node#53084

* src: do not use deprecated V8 API

nodejs/node#53084

* src: do not use soon-to-be-deprecated V8 API

nodejs/node#53174

* src: migrate to new V8 interceptors API

nodejs/node#52745

* src: use supported API to get stalled TLA messages

nodejs/node#51362

* module: print location of unsettled top-level await in entry points

nodejs/node#51999

* test: make snapshot comparison more flexible

nodejs/node#54375

* test: do not set concurrency on parallelized runs

nodejs/node#52177

* src: move FromNamespacedPath to path.cc

nodejs/node#53540

* test: adapt to new V8 trusted memory spaces

nodejs/node#50115

* build: add option to enable clang-cl on Windows

nodejs/node#52870

* chore: fixup patch indices

* chore: add/remove changed files

* esm: drop support for import assertions

nodejs/node#54890

* build: compile with C++20 support

nodejs/node#52838

* deps: update nghttp2 to 1.62.1

nodejs/node#52966

* src: parse inspector profiles with simdjson

nodejs/node#51783

* build: add GN build files

nodejs/node#47637

* deps,lib,src: add experimental web storage

nodejs/node#52435

* build: add missing BoringSSL dep

* src: rewrite task runner in c++

nodejs/node#52609

* fixup! build: add GN build files

* src: stop using deprecated fields of v8::FastApiCallbackOptions

nodejs/node#54077

* fix: shadow variable

* build: add back incorrectly removed SetAccessor patch

* fixup! fixup! build: add GN build files

* crypto: fix integer comparison in crypto for BoringSSL

* src,lib: reducing C++ calls of esm legacy main resolve

nodejs/node#48325

* src: move more crypto_dh.cc code to ncrypto

nodejs/node#54459

* chore: fixup GN files for previous commit

* src: move more crypto code to ncrypto

nodejs/node#54320

* Fixup Perfetto ifdef guards

* fix: missing electron_natives dep

* fix: node_use_node_platform = false

* fix: include src/node_snapshot_stub.cc in libnode

* 5507047: [import-attributes] Remove support for import assertions

https://chromium-review.googlesource.com/c/v8/v8/+/5507047

* fix: restore v8-sandbox.h in filenames.json

* fix: re-add original-fs generation logic

* fix: ngtcp2 openssl dep

* test: try removing NAPI_VERSION undef

* chore(deps): bump @types/node

* src: move more crypto_dh.cc code to ncrypto

nodejs/node#54459

* esm: remove unnecessary toNamespacedPath calls

nodejs/node#53656

* buffer: fix out of range for toString

nodejs/node#54553

* lib: rewrite AsyncLocalStorage without async_hooks

nodejs/node#48528

* module: print amount of load time of a cjs module

nodejs/node#52213

* test: skip reproducible snapshot test on 32-bit

nodejs/node#53592

* fixup! src: move more crypto_dh.cc code to ncrypto

* test: adjust emittedUntil return type

* chore: remove redundant wpt streams patch

* fixup! chore(deps): bump @types/node

* fix: gn executable name on Windows

* fix: build on Windows

* fix: rename conflicting win32 symbols in //third_party/sqlite

On Windows otherwise we get:

lld-link: error: duplicate symbol: sqlite3_win32_write_debug
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_sleep
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_is_nt
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2
>>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550
>>>            obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj
>>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj

* docs: remove unnecessary ts-expect-error after types bump

* src: move package resolver to c++

nodejs/node#50322

* build: set ASAN detect_container_overflow=0

nodejs/node#55584

* chore: fixup rebase

* test: disable failing ASAN test

* win: almost fix race detecting ESRCH in uv_kill

libuv/libuv#4341
joyeecheung
joyeecheung reviewed May 28, 2025
View reviewed changes
Comment thread src/node_file.cc
return -1;
}

switch (std::filesystem::status(path).type()) {

@joyeecheung joyeecheung May 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect: the path should be converted to UTF-16 on windows if it's using std::filesystem::path, otherwise it could crash - this could be the cause of #56670

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@joyeecheung

joyeecheung commented May 28, 2025

Copy link
Copy Markdown
Member

It seems removing the fast API locally improves performance now (due to the handle scope creation, which would be necessary to get the Environment if this were to be implemented correctly e.g. to name spacing it using env->exec_path)

                                                                                      confidence improvement accuracy (*)   (**)  (***)
misc/startup-cli-version.js n=30 cli='deps/corepack/dist/corepack.js'                                -0.16 %       ±1.46% ±1.95% ±2.53%
misc/startup-cli-version.js n=30 cli='deps/npm/bin/npm-cli.js'                                **      1.88 %       ±1.32% ±1.76% ±2.29%
misc/startup-cli-version.js n=30 cli='deps/npm/bin/npx-cli.js'                               ***      2.37 %       ±1.04% ±1.39% ±1.81%
misc/startup-cli-version.js n=30 cli='tools/eslint/node_modules/eslint/bin/eslint.js'                -0.94 %       ±1.12% ±1.49% ±1.94%
misc/startup-core.js n=30 mode='process' script='benchmark/fixtures/require-builtins'                 0.68 %       ±1.69% ±2.25% ±2.92%
misc/startup-core.js n=30 mode='process' script='test/fixtures/semicolon'                             0.79 %       ±1.08% ±1.44% ±1.88%
misc/startup-core.js n=30 mode='process' script='test/fixtures/snapshot/typescript'                  -0.21 %       ±0.88% ±1.17% ±1.53%
misc/startup-core.js n=30 mode='worker' script='benchmark/fixtures/require-builtins'                 -0.29 %       ±1.04% ±1.39% ±1.80%
misc/startup-core.js n=30 mode='worker' script='test/fixtures/semicolon'                              2.43 %       ±2.98% ±4.01% ±5.32%
misc/startup-core.js n=30 mode='worker' script='test/fixtures/snapshot/typescript'                    0.12 %       ±0.70% ±0.93% ±1.21%
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas mentioned this pull request May 28, 2025
src: remove fast API for InternalModuleStat #58489
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments
@mcollina mcollina mcollina approved these changes
@Qard Qard Qard approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@H4ad H4ad H4ad approved these changes
+1 more reviewer
@fhinkel fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@anonrig @nodejs-github-bot @H4ad @wraithgar @targos @aduh95 @joyeecheung @mcollina @fhinkel @Qard @GeoffreyBooth
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.