GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 2024-11-11, Version 23.2.0 (Current) by aduh95 · Pull Request #55741 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Nov 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • [535f1b0d4c] - crypto: update root certificates to NSS 3.104 (Richard Lau) #55681
  • [fa61dced44] - doc: move typescript support to active development (Marco Ippolito) #55536
  • [9dcca5441b] - doc: add jazelly to collaborators (Jason Zhang) #55531
  • [f628fc43cb] - (SEMVER-MINOR) fs: make dirent.path writable (Antoine du Hamel) #55547
  • [25b1422337] - (SEMVER-MINOR) http: add diagnostic channel http.client.request.created (Marco Ippolito) #55586
  • [adda37f00c] - (SEMVER-MINOR) module: add findPackageJSON util (Jacob Smith) #55412
  • [69dd1e13c3] - (SEMVER-MINOR) module: add module.stripTypeScriptTypes (Marco Ippolito) #55282
  • [8fc962f1af] - tools: fix root certificate updater (Richard Lau) #55681
Commits
  • [9dbb255efb] - assert: fix deepStrictEqual on errors when cause is not undefined (Edigleysson Silva (Edy)) #55406
  • [7af76ef0b3] - assert: fix the string length check for printing the simple diff (Giovanni Bucci) #55474
  • [34483a299b] - benchmark: add nodeTiming.uvmetricsinfo bench (RafaelGSS) #55614
  • [b79e4835ab] - build: use rclone instead of aws CLI (Michaël Zasso) #55617
  • [7ab1f46b8a] - build: stop pre-compiling lint-md (Aviv Keller) #55266
  • [4887214e23] - build: fix building with system icu 76 (Michael Cho) #55563
  • [f8df27aa5a] - build: fix GN arg used in generate_config_gypi.py (Shelley Vohr) #55530
  • [bb78904548] - build: fix GN build for sqlite and nghttp2 (Shelley Vohr) #55529
  • [535f1b0d4c] - crypto: update root certificates to NSS 3.104 (Richard Lau) #55681
  • [9b351b0749] - crypto: fix RSA_PKCS1_PADDING error message (Richard Lau) #55629
  • [4b192daac0] - deps: update acorn to 8.14.0 (Node.js GitHub Bot) #55699
  • [dfb764cbc6] - deps: update sqlite to 3.47.0 (Node.js GitHub Bot) #55557
  • [3477492588] - deps: update amaro to 0.2.0 (Node.js GitHub Bot) #55601
  • [3a1d490535] - deps: update nghttp2 to 1.64.0 (Node.js GitHub Bot) #55559
  • [50552fdc92] - deps: update acorn to 8.13.0 (Node.js GitHub Bot) #55558
  • [1b82013f06] - deps: update undici to 6.20.1 (Node.js GitHub Bot) #55503
  • [09060045b1] - dns: stop using deprecated ares_query (Aviv Keller) #55430
    • [2d0914f337] - doc: consolidate history table of CustomEvent (Edigleysson Silva) #55758
  • [cbe09b579f] - doc: add path aliases typescript doc (Carlos Espa) #55766
  • [89aa83842a] - doc: add esm example in path.md (Aviv Keller) #55745
  • [ee12431298] - doc: consistent use of word child process (Gireesh Punathil) #55654
  • [20cb52d1d8] - doc: clarity to available addon options (Preveen P) #55715
  • [bffbaa13a2] - doc: update --max-semi-space-size description (Joe Bowbeer) #55495
  • [505ff199b6] - doc: broken PerformanceObserver code sample (Dom Harrington) #54227
  • [b8ca9d89f4] - doc: add write flag when open file as the demo code's intention (robberfree) #54626
  • [6662752b62] - doc: add a note on console stream behavior (Gireesh Punathil) #55616
  • [9743fa44ed] - doc: remove mention of ECDH-ES in crypto.diffieHellman (Filip Skokan) #55611
  • [5de2567644] - doc: improve c++ embedder API doc (Gireesh Punathil) #55597
  • [f355054ec7] - doc: capitalize "MIT License" (Aviv Keller) #55575
  • [fa61dced44] - doc: move typescript support to active development (Marco Ippolito) #55536
  • [f77bf65059] - doc: add suggested tsconfig for type stripping (Marco Ippolito) #55534
  • [f00ad27132] - doc: add esm examples to node:string_decoder (Alfredo González) #55507
  • [9dcca5441b] - doc: add jazelly to collaborators (Jason Zhang) #55531
  • [f628fc43cb] - (SEMVER-MINOR) fs: make dirent.path writable (Antoine du Hamel) #55547
  • [dd9b6833c7] - Revert "fs,win: fix bug in paths with trailing slashes" (Rod Vagg) #55527
  • [8d0526f1f4] - http: add diagnostic channel http.server.response.created (Marco Ippolito) #55622
  • [25b1422337] - (SEMVER-MINOR) http: add diagnostic channel http.client.request.created (Marco Ippolito) #55586
  • [f92f20b930] - http: don't emit error after destroy (Robert Nagy) #55457
  • [137aa5c9f6] - http2: fix client async storage persistence (Orgad Shaneh) #55460
  • [d1965f9f5b] - lib: implement webidl dictionary converter and use it in structuredClone (Jason Zhang) #55489
  • [bf552fa3cc] - lib: prefer number to string in webidl type function (Jason Zhang) #55489
  • [7bfd295416] - meta: bump actions/setup-python from 5.2.0 to 5.3.0 (dependabot[bot]) #55688
  • [21e3b7b2f4] - meta: bump actions/setup-node from 4.0.4 to 4.1.0 (dependabot[bot]) #55687
  • [2ae8d3b2ff] - meta: bump rtCamp/action-slack-notify from 2.3.0 to 2.3.2 (dependabot[bot]) #55686
  • [42e6c47086] - meta: bump actions/upload-artifact from 4.4.0 to 4.4.3 (dependabot[bot]) #55685
  • [9042e9acc9] - meta: bump actions/cache from 4.0.2 to 4.1.2 (dependabot[bot]) #55684
  • [5c2e4729cc] - meta: bump actions/checkout from 4.2.0 to 4.2.2 (dependabot[bot]) #55683
  • [d79c8bf7a1] - meta: bump github/codeql-action from 3.26.10 to 3.27.0 (dependabot[bot]) #55682
  • [d0ea9815f6] - meta: make review-wanted message minimal (Aviv Keller) #55607
  • [b1ca7ab0a1] - meta: show PR/issue title on review-wanted (Aviv Keller) #55606
  • [19b1edfc5c] - module: simplify --inspect-brk handling (Joyee Cheung) #55679
  • [869e88c6a8] - module: simplify findPackageJSON implementation (Antoine du Hamel) #55543
  • [56c46ab686] - module: unify TypeScript and .mjs handling in CommonJS (Joyee Cheung) #55590
  • [d3be3da6f8] - module: fix error thrown from require(esm) hitting TLA repeatedly (Joyee Cheung) #55520
  • [b3971bbf13] - module: trim off internal stack frames for require(esm) warnings (Joyee Cheung) #55496
  • [a9e08cfe6d] - module: allow ESM that failed to be required to be re-imported (Joyee Cheung) #55502
  • [adda37f00c] - (SEMVER-MINOR) module: add findPackageJSON util (Jacob Smith) #55412
  • [69dd1e13c3] - (SEMVER-MINOR) module: add module.stripTypeScriptTypes (Marco Ippolito) #55282
  • [6ab59c81b6] - os: improve path check with direct index access (Mert Can Altin) #55434
  • [038ac01d26] - path,win: fix bug in resolve and normalize (Hüseyin Açacak) #55623
  • [7aa250afda] - sqlite: improve error handling using MaybeLocal (Tobias Nießen) #55571
  • [2ec4ae7c16] - sqlite: add readOnly option (Tobias Nießen) #55567
  • [88c7f5b489] - sqlite: refactor open options (Tobias Nießen) #55442
  • [7853462a61] - src: provide workaround for container-overflow (Daniel Lemire) #55591
  • [0302efe4b2] - src: move more key related stuff to ncrypto (James M Snell) #55368
  • [d26dedf41d] - src: refactor ECDHBitsJob signature (Filip Skokan) #55610
  • [4c34891454] - src: fix dns crash when failed to create NodeAresTask (theanarkh) #55521
  • [467618418a] - src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT (Charles Kerr) #55581
  • [016baaebbe] - src: do not run IsWindowsBatchFile on non-windows (Yagiz Nizipli) #55560
  • [efa142c108] - src: migrate String::Value to String::ValueView (Aviv Keller) #55458
  • [cfa4d960c8] - src,lib: optimize nodeTiming.uvMetricsInfo (RafaelGSS) #55614
  • [19da4de475] - test: update performance-timeline wpt (RedYetiDev) #55197
  • [10b68ed975] - test: ignore unrelated events in FW watch tests (Carlos Espa) #55605
  • [7d93c0c3ae] - test: refactor some esm tests (Antoine du Hamel) #55472
  • [815e2524a6] - test: split up test-runner-mock-timers test (Julian Gassner) #55506
  • [6aa797de4e] - test: remove unneeded listeners (Luigi Pinca) #55486
  • [649d767a40] - test: increase coverage of pathToFileURL (Antoine du Hamel) #55493
  • [71cc20a3a5] - test: avoid apply() calls with large amount of elements (Livia Medeiros) #55501
  • [2d19614020] - test: increase test coverage for http.OutgoingMessage.appendHeader() (Juan José) #55467
  • [aebf676569] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #55703
  • [53a7d8e75b] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #55512
  • [0ea74f3d02] - test,crypto: make crypto tests work with BoringSSL (Shelley Vohr) #55491
  • [3234dc6100] - test_runner: pass options directly to TestCoverage (Aviv Keller) #55578
  • [15028dd073] - tools: update ESLint to 9.14.0 (dependabot[bot]) #55689
  • [961cbc9c0f] - tools: use util.parseArgs in lint-md (Aviv Keller) #55694
  • [8fc962f1af] - tools: fix root certificate updater (Richard Lau) #55681
  • [d0b2d6be84] - tools: compact jq output in daily-wpt-fyi.yml action (Filip Skokan) #55695
  • [cba05cda38] - tools: run daily WPT.fyi report on all supported releases (Filip Skokan) #55619
  • [7ce7eab324] - tools: lint README lists more strictly (Antoine du Hamel) #55625
  • [c2fcda45ca] - typings: fix ModulesBinding types (Antoine du Hamel) #55549
  • [2b9928561d] - url: refactor pathToFileURL to native (Antoine du Hamel) #55476
  • [4129bc72e2] - util: do not catch on circular @@toStringTag errors (Aviv Keller) #55544

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and tryb3l reacted with thumbs up emoji bricss and tryb3l reacted with hooray emoji bricss and tryb3l reacted with heart emoji bricss and tryb3l reacted with rocket emoji
All reactions
  • 👍 2 reactions
  • 🎉 2 reactions
  • ❤️ 2 reactions
  • 🚀 2 reactions
codebytere and others added 30 commits November 1, 2024 16:00
@codebytere @RafaelGSS
test,crypto: make crypto tests work with BoringSSL
0ea74f3
PR-URL: #55491
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@marco-ippolito @RafaelGSS
module: add module.stripTypeScriptTypes
69dd1e1
PR-URL: #55282
Fixes: #54300
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@jazelly @RafaelGSS
doc: add jazelly to collaborators
9dcca54
PR-URL: #55531
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@juanarbol @RafaelGSS
test: increase test coverage for http.OutgoingMessage.appendHeader()
2d19614
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #55467
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@JakobJingleheimer @RafaelGSS
module: add findPackageJSON util
adda37f
PR-URL: #55412
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@tniessen @RafaelGSS
sqlite: refactor open options
88c7f5b
Move options that are only relevant for opening the database into a
self-contained class.

PR-URL: #55442
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@panva @RafaelGSS
test,crypto: update WebCryptoAPI WPT
53a7d8e
PR-URL: #55512
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot @RafaelGSS
deps: update undici to 6.20.1
1b82013
PR-URL: #55503
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@LiviaMedeiros @RafaelGSS
test: avoid apply() calls with large amount of elements
71cc20a
PR-URL: #55501
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@mfdebian @RafaelGSS
doc: add esm examples to node:string_decoder
f00ad27
PR-URL: #55507
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@aduh95 @RafaelGSS
test: increase coverage of pathToFileURL
649d767
PR-URL: #55493
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
@codebytere @RafaelGSS
build: fix GN build for sqlite and nghttp2
bb78904
PR-URL: #55529
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Cheng Zhao <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito @RafaelGSS
doc: add suggested tsconfig for type stripping
f77bf65
PR-URL: #55534
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@marco-ippolito @RafaelGSS
doc: move typescript support to active development
fa61dce
PR-URL: #55536
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@aduh95 @RafaelGSS
fs: make dirent.path writable
f628fc4
PR-URL: #55547
Refs: #55538
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@codebytere @RafaelGSS
build: fix GN arg used in generate_config_gypi.py
f8df27a
PR-URL: #55530
Reviewed-By: Cheng Zhao <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@joyeecheung @RafaelGSS
module: allow ESM that failed to be required to be re-imported
a9e08cf
When a ESM module cannot be loaded by require due to the presence
of TLA, its module status would be stopped at kInstantiated. In
this case, when it's imported again, we should allow it to be
evaluated asynchronously, as it's also a common pattern for users
to retry with dynamic import when require fails.

PR-URL: #55502
Fixes: #55500
Refs: #52697
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@ronag @RafaelGSS
http: don't emit error after destroy
f92f20b
PR-URL: #55457
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@avivkeller @RafaelGSS
src: migrate String::Value to String::ValueView
efa142c
Fixes #54417
Ref: #55452

PR-URL: #55458
Refs: #55452
Reviewed-By: Vladimir Morozov <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@nodejs-github-bot @RafaelGSS
deps: update acorn to 8.13.0
50552fd
PR-URL: #55558
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@nodejs-github-bot @RafaelGSS
deps: update nghttp2 to 1.64.0
3a1d490
PR-URL: #55559
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@anonrig @RafaelGSS
src: do not run IsWindowsBatchFile on non-windows
016baae
PR-URL: #55560
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
@joyeecheung @RafaelGSS
module: trim off internal stack frames for require(esm) warnings
b3971bb
Trim off irrelevant internal stack frames for require(esm) warnings
so it's easier to locate where the call comes from when
--trace-warnings is used.

PR-URL: #55496
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@joyeecheung @RafaelGSS
module: fix error thrown from require(esm) hitting TLA repeatedly
d3be3da
This tracks the asynchronicity in the ModuleWraps when they turn out to
contain TLA after instantiation, and throw the right error
(ERR_REQUIRE_ASYNC_MODULE) when it's required again. It removes
the freezing of ModuleWraps since it's not meaningful to freeze
this when the rest of the module loader is mutable, and we
can record the asynchronicity in the ModuleWrap right after
compilation after we get a V8 upgrade that contains
v8::Module::HasTopLevelAwait() instead of searching through
the module graph repeatedly which can be slow.

PR-URL: #55520
Fixes: #55516
Refs: #52697
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
@lpinca @RafaelGSS
test: remove unneeded listeners
6aa797d
Unhandled `'error'` events will make the process exit with an unclean
exit code anyway.

PR-URL: #55486
Reviewed-By: Jake Yuesong Li <[email protected]>
@cho-m @RafaelGSS
build: fix building with system icu 76
4887214
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer
add `icu-uc` when linking to shared libraries. This results in undefined
symbols/references when trying to build with system ICU 76.

[^1]: unicode-org/icu@199bc82

PR-URL: #55563
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@badkeyy @RafaelGSS
test: split up test-runner-mock-timers test
815e252
PR-URL: #55506
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@avivkeller @RafaelGSS
doc: capitalize "MIT License"
f355054
PR-URL: #55575
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@avivkeller @RafaelGSS
dns: stop using deprecated ares_query
0906004
PR-URL: #55430
Refs: #52464
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@ckerr @RafaelGSS
src: use NewFromUtf8Literal in NODE_DEFINE_CONSTANT
4676184
Small efficiency improvement over NewFromUtf8(): the literal's
length is known at compile time, so V8 doesn't have to call
strlen() or ToLocalChecked().

PR-URL: #55581
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@aduh95
aduh95 force-pushed the v23.2.0-proposal branch from 2c07f86 to 69c6bf2 Compare November 6, 2024 11:01
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2024 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63449/
CITGM (v23.x): https://ci.nodejs.org/job/citgm-smoker/3503/
CITGM (v23.2.0-proposal): https://ci.nodejs.org/job/citgm-smoker/3504/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Nov 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 91.16638% with 103 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (17fae65) to head (a83fbdb).
Report is 95 commits behind head on v23.x.

Files with missing lines Patch % Lines
src/crypto/crypto_keys.cc 78.40% 12 Missing and 15 partials ⚠️
src/node_sqlite.cc 74.19% 8 Missing and 8 partials ⚠️
lib/internal/webidl.js 83.33% 14 Missing ⚠️
src/node_url.cc 72.50% 1 Missing and 10 partials ⚠️
src/cares_wrap.cc 50.00% 7 Missing and 1 partial ⚠️
src/string_bytes.cc 20.00% 8 Missing ⚠️
src/crypto/crypto_ec.cc 20.00% 0 Missing and 4 partials ⚠️
lib/internal/modules/esm/module_job.js 91.17% 3 Missing ⚠️
src/crypto/crypto_keygen.h 70.00% 3 Missing ⚠️
src/crypto/crypto_util.h 66.66% 1 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v23.x   #55741      +/-   ##
==========================================
- Coverage   88.42%   88.41%   -0.01%     
==========================================
  Files         653      654       +1     
  Lines      187479   187665     +186     
  Branches    36089    36125      +36     
==========================================
+ Hits       165769   165930     +161     
- Misses      14955    14965      +10     
- Partials     6755     6770      +15     
Files with missing lines Coverage Δ
lib/_http_client.js 97.97% <100.00%> (+0.01%) ⬆️
lib/_http_outgoing.js 95.23% <100.00%> (+0.17%) ⬆️
lib/_http_server.js 96.66% <100.00%> (+0.01%) ⬆️
lib/fs.js 98.14% <100.00%> (+0.02%) ⬆️
lib/internal/assert/assertion_error.js 95.35% <100.00%> (+0.21%) ⬆️
lib/internal/crypto/diffiehellman.js 97.52% <ø> (-0.01%) ⬇️
lib/internal/errors.js 96.99% <100.00%> (+<0.01%) ⬆️
lib/internal/fs/promises.js 98.24% <100.00%> (ø)
lib/internal/fs/streams.js 93.63% <100.00%> (ø)
lib/internal/fs/utils.js 99.69% <100.00%> (-0.01%) ⬇️
... and 46 more

... and 28 files with indirect coverage changes

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@avivkeller avivkeller added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. labels Nov 6, 2024
@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2024 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63462/
📦: https://ci-release.nodejs.org/job/iojs+release/10601/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau
richardlau approved these changes Nov 6, 2024
View reviewed changes
RafaelGSS
RafaelGSS approved these changes Nov 6, 2024
View reviewed changes
avivkeller and others added 3 commits November 9, 2024 22:41
@avivkeller @aduh95
doc: add esm example in path.md
89aa838
PR-URL: #55745
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
@Ceres6 @aduh95
doc: add path aliases typescript doc
cbe09b5
PR-URL: #55766
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
@geeksilva97 @aduh95
doc: consolidate history table of CustomEvent
355af0f
PR-URL: #55758
Fixes: #55733
Refs: #55733
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@aduh95
aduh95 force-pushed the v23.2.0-proposal branch from 69c6bf2 to f2bac99 Compare November 9, 2024 21:50
aduh95 added a commit that referenced this pull request Nov 9, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
f2bac99
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
@aduh95 aduh95 changed the title 2024-11-07, Version 23.2.0 (Current) 2024-11-11, Version 23.2.0 (Current) Nov 9, 2024
targos
targos reviewed Nov 11, 2024
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V23.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
2024-11-11, Version 23.2.0 (Current)
a83fbdb
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
@aduh95
aduh95 force-pushed the v23.2.0-proposal branch from f2bac99 to a83fbdb Compare November 11, 2024 15:24
@aduh95
aduh95 merged commit a83fbdb into v23.x Nov 11, 2024
@aduh95
aduh95 deleted the v23.2.0-proposal branch November 11, 2024 20:22
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
Working on v23.2.1
a8657e2
PR-URL: #55741
aduh95 added a commit that referenced this pull request Nov 11, 2024
@aduh95
2024-11-11, Version 23.2.0 (Current)
c52c670
Notable changes:

crypto:
  * update root certificates to NSS 3.104 (Richard Lau) #55681
doc:
  * move typescript support to active development (Marco Ippolito) #55536
  * add jazelly to collaborators (Jason Zhang) #55531
fs:
  * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547
http:
  * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586
module:
  * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412
  * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282

PR-URL: #55741
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Nov 11, 2024
@aduh95
Blog: v23.1.0 release post (nodejs#7140)
195ee9f
Refs: nodejs/node#55741
aduh95 added a commit to aduh95/nodejs.org that referenced this pull request Nov 11, 2024
@aduh95
Blog: v23.2.0 release post
118ab6b
Refs: nodejs/node#55741
@aduh95 aduh95 mentioned this pull request Nov 11, 2024
Blog: v23.2.0 release post nodejs/nodejs.org#7213
Merged
5 tasks
github-merge-queue Bot pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 11, 2024
@aduh95
Blog: v23.2.0 release post (#7213)
2db91dc
Refs: nodejs/node#55741
Dr-Bashir
Dr-Bashir reviewed Nov 12, 2024
View reviewed changes

@Dr-Bashir Dr-Bashir left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
bmuenzenmeyer pushed a commit to nodejs/nodejs.org that referenced this pull request Nov 21, 2024
@aduh95 @bmuenzenmeyer
Blog: v23.2.0 release post (#7213)
b5e95c4
Refs: nodejs/node#55741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+2 more reviewers
@targos targos targos left review comments
@Dr-Bashir Dr-Bashir Dr-Bashir left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@aduh95 @nodejs-github-bot @targos @richardlau @RafaelGSS @Dr-Bashir @avivkeller @codebytere @marco-ippolito @jazelly @juanarbol @JakobJingleheimer @tniessen @panva @LiviaMedeiros @mfdebian @joyeecheung @ronag @anonrig @lpinca
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.