GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: add support for `import source` syntax in linter by aduh95 · Pull Request #56992 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

It's going to be useful for #56919, IMO it makes sense to put it in a separate PR to avoid backporting issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 10, 2025
legendecas
legendecas approved these changes Feb 11, 2025
View reviewed changes
targos
targos approved these changes Feb 11, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 11, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 12, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/56992
✔  Done loading data for nodejs/node/pull/56992
----------------------------------- PR info ------------------------------------
Title      tools: add support for `import source` syntax in linter (#56992)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:source-import-lint -> nodejs:main
Labels     tools, author ready
Commits    1
 - tools: add support for `import source` syntax in linter
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 10 Feb 2025 15:01:43 GMT
   ✔  Approvals: 2
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/56992#pullrequestreview-2607474292
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/56992#pullrequestreview-2608054594
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 56992
From https://github.com/nodejs/node
 * branch                  refs/pull/56992/merge -> FETCH_HEAD
✔  Fetched commits as e7626dc70dbd..50a20ea40d52
--------------------------------------------------------------------------------
Auto-merging tools/eslint/package-lock.json
CONFLICT (content): Merge conflict in tools/eslint/package-lock.json
Auto-merging tools/eslint/package.json
CONFLICT (content): Merge conflict in tools/eslint/package.json
error: could not apply 50a20ea40d... tools: add support for `import source` syntax in linter
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/13288558054
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
tools: add support for import source syntax in linter
1ede719
@aduh95
aduh95 force-pushed the source-import-lint branch from 50a20ea to 1ede719 Compare February 12, 2025 16:37
targos
targos approved these changes Feb 12, 2025
View reviewed changes
lpinca
lpinca approved these changes Feb 12, 2025
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Feb 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit a7f648c into nodejs:main Feb 12, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in a7f648c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
aduh95 deleted the source-import-lint branch February 12, 2025 21:57
targos pushed a commit that referenced this pull request Feb 17, 2025
@aduh95 @targos
tools: add support for import source syntax in linter
a9112df
PR-URL: #56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@aduh95 @acidiney
tools: add support for import source syntax in linter
5983e85
PR-URL: nodejs#56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 25, 2025
2025-02-26, Version 23.9.0 (Current) #57207
Merged
aduh95 added a commit that referenced this pull request Apr 2, 2025
@aduh95
tools: add support for import source syntax in linter
70d35cc
PR-URL: #56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 added a commit that referenced this pull request Apr 3, 2025
@aduh95
tools: add support for import source syntax in linter
2db2508
PR-URL: #56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@aduh95 @RafaelGSS
tools: add support for import source syntax in linter
f2ac0b0
PR-URL: #56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@aduh95 @RafaelGSS
tools: add support for import source syntax in linter
280316f
PR-URL: #56992
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @lpinca @targos @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.