GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — crypto: fix missing `OPENSSL_NO_ENGINE` guard by codebytere · Pull Request #57012 · nodejs/node

Conversation

@codebytere

@codebytere codebytere commented Feb 12, 2025

Copy link
Copy Markdown
Member

Refs #56526.

Fixes compilation failure when OPENSSL_NO_ENGINE is defined:

../../third_party/electron_node/src/crypto/crypto_util.cc:32:16: error: no member named 'EnginePointer' in namespace 'ncrypto'; did you mean 'ECPointPointer'?
   32 | using ncrypto::EnginePointer;
      |       ~~~~~~~~~^~~~~~~~~~~~~
      |                ECPointPointer
../../third_party/electron_node/deps/ncrypto/ncrypto.h:889:7: note: 'ECPointPointer' declared here
  889 | class ECPointPointer final {
      |       ^
1 error generated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@codebytere
codebytere requested a review from jasnell February 12, 2025 12:17
@nodejs-github-bot

nodejs-github-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 12, 2025
@codebytere
codebytere force-pushed the openssl-no-engine branch from fc30ed0 to 25f11b0 Compare February 12, 2025 12:20
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
c417004
@codebytere
codebytere force-pushed the openssl-no-engine branch from 25f11b0 to c417004 Compare February 12, 2025 12:21
richardlau
richardlau approved these changes Feb 12, 2025
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 12, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Feb 12, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
joyeecheung
joyeecheung approved these changes Feb 12, 2025
View reviewed changes
lpinca
lpinca approved these changes Feb 12, 2025
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codebytere codebytere mentioned this pull request Feb 13, 2025
chore: bump node to v22.14.0 (main) electron/electron#45578
Merged
@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2025 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65188/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Feb 14, 2025
View reviewed changes
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 14, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 14, 2025
@nodejs-github-bot
nodejs-github-bot merged commit fc7682c into nodejs:main Feb 14, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator

Landed in fc7682c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Feb 17, 2025
@codebytere @targos
crypto: fix missing OPENSSL_NO_ENGINE guard
dfdaa92 
PR-URL: #57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@codebytere @acidiney
crypto: fix missing OPENSSL_NO_ENGINE guard
a56af79 
PR-URL: nodejs#57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 25, 2025
2025-02-26, Version 23.9.0 (Current) #57207
Merged
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@codebytere @aduh95
crypto: fix missing OPENSSL_NO_ENGINE guard
90de671 
PR-URL: #57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@codebytere @aduh95
crypto: fix missing OPENSSL_NO_ENGINE guard
75088aa 
PR-URL: #57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@codebytere @RafaelGSS
crypto: fix missing OPENSSL_NO_ENGINE guard
525cee8 
PR-URL: #57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@codebytere @RafaelGSS
crypto: fix missing OPENSSL_NO_ENGINE guard
e21d126 
PR-URL: #57012
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Apr 25, 2025
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
c81e9f3 
nodejs/node#57012
codebytere added a commit to electron/electron that referenced this pull request Apr 25, 2025
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
e9f4bc9 
nodejs/node#57012
codebytere added a commit to electron/electron that referenced this pull request May 1, 2025
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
68a196f 
nodejs/node#57012
codebytere added a commit to electron/electron that referenced this pull request May 5, 2025
@electron-roller @codebytere
chore: bump node to v22.15.0 (main) (#46742)
cb445b3 
* chore: bump node in DEPS to v22.15.0

* inspector: fix GN build

nodejs/node#56798

* test: search cctest files

nodejs/node#56791

* crypto: fix missing OPENSSL_NO_ENGINE guard

nodejs/node#57012

* test,crypto: make tests work for BoringSSL

nodejs/node#57021

* module: use synchronous hooks for preparsing in import(cjs)

nodejs/node#55698

* deps: update simdjson to 3.12.0

nodejs/node#56874

* build: remove explicit linker call to libm on macOS

nodejs/node#56901

* test: make eval snapshot comparison more flexible

nodejs/node#57020

* src: allow embedder customization of OOMErrorHandler

nodejs/node#57325

* src: do not pass nullptr to std::string ctor

nodejs/node#57354

* src: lock the isolate properly in IsolateData destructor

nodejs/node#57031

* chore: shrink --trace-atomics-wait patch

* chore: fixup patch indices

* build: fix GN build failure

nodejs/node#57013

* crypto: expose security levels

nodejs/node#56601

* zlib: add zstd support

nodejs/node#52100

* test: move crypto related common utilities in common/crypto

nodejs/node#56714

* cli: move --trace-atomics-wait to eol

nodejs/node#52747

* test: disable test-https-client-renegotiation-limit

BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request May 5, 2025
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
6e9a181 
nodejs/node#57012
codebytere added a commit to electron/electron that referenced this pull request May 6, 2025
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
b7c2c9e 
nodejs/node#57012
codebytere added a commit to electron/electron that referenced this pull request May 6, 2025
@electron-roller @codebytere
chore: bump node to v22.15.0 (37-x-y) (#46869)
cd023b5 
* chore: bump node in DEPS to v22.15.0

* inspector: fix GN build

nodejs/node#56798

* test: search cctest files

nodejs/node#56791

* crypto: fix missing OPENSSL_NO_ENGINE guard

nodejs/node#57012

* test,crypto: make tests work for BoringSSL

nodejs/node#57021

* module: use synchronous hooks for preparsing in import(cjs)

nodejs/node#55698

* deps: update simdjson to 3.12.0

nodejs/node#56874

* build: remove explicit linker call to libm on macOS

nodejs/node#56901

* test: make eval snapshot comparison more flexible

nodejs/node#57020

* src: allow embedder customization of OOMErrorHandler

nodejs/node#57325

* src: do not pass nullptr to std::string ctor

nodejs/node#57354

* src: lock the isolate properly in IsolateData destructor

nodejs/node#57031

* chore: shrink --trace-atomics-wait patch

* chore: fixup patch indices

* build: fix GN build failure

nodejs/node#57013

* crypto: expose security levels

nodejs/node#56601

* zlib: add zstd support

nodejs/node#52100

* test: move crypto related common utilities in common/crypto

nodejs/node#56714

* cli: move --trace-atomics-wait to eol

nodejs/node#52747

* test: disable test-https-client-renegotiation-limit

BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request May 7, 2025
@codebytere
crypto: fix missing OPENSSL_NO_ENGINE guard
89438df 
nodejs/node#57012
deepak1556 pushed a commit to electron/electron that referenced this pull request May 13, 2025
@electron-roller @codebytere
chore: bump node to v22.15.0 (35-x-y) (#46740)
9f4e0b9 
* chore: bump node in DEPS to v22.15.0

* inspector: fix GN build

nodejs/node#56798

* test: search cctest files

nodejs/node#56791

* crypto: fix missing OPENSSL_NO_ENGINE guard

nodejs/node#57012

* test,crypto: make tests work for BoringSSL

nodejs/node#57021

* module: use synchronous hooks for preparsing in import(cjs)

nodejs/node#55698

* deps: update simdjson to 3.12.0

nodejs/node#56874

* build: remove explicit linker call to libm on macOS

nodejs/node#56901

* test: make eval snapshot comparison more flexible

nodejs/node#57020

* src: allow embedder customization of OOMErrorHandler

nodejs/node#57325

* src: do not pass nullptr to std::string ctor

nodejs/node#57354

* build: fix GN build failure

* build: fix patch indices

* crypto: expose security levels

nodejs/node#56601

* zlib: add zstd support

nodejs/node#52100

* test: move crypto related common utilities in common/crypto

nodejs/node#56714

* test: disable test-https-client-renegotiation-limit

BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631

* chore: fixup indices

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@electron-roller @codebytere @kigh-ota
chore: bump node to v22.15.0 (main) (electron#46742)
2f58fe0 
* chore: bump node in DEPS to v22.15.0

* inspector: fix GN build

nodejs/node#56798

* test: search cctest files

nodejs/node#56791

* crypto: fix missing OPENSSL_NO_ENGINE guard

nodejs/node#57012

* test,crypto: make tests work for BoringSSL

nodejs/node#57021

* module: use synchronous hooks for preparsing in import(cjs)

nodejs/node#55698

* deps: update simdjson to 3.12.0

nodejs/node#56874

* build: remove explicit linker call to libm on macOS

nodejs/node#56901

* test: make eval snapshot comparison more flexible

nodejs/node#57020

* src: allow embedder customization of OOMErrorHandler

nodejs/node#57325

* src: do not pass nullptr to std::string ctor

nodejs/node#57354

* src: lock the isolate properly in IsolateData destructor

nodejs/node#57031

* chore: shrink --trace-atomics-wait patch

* chore: fixup patch indices

* build: fix GN build failure

nodejs/node#57013

* crypto: expose security levels

nodejs/node#56601

* zlib: add zstd support

nodejs/node#52100

* test: move crypto related common utilities in common/crypto

nodejs/node#56714

* cli: move --trace-atomics-wait to eol

nodejs/node#52747

* test: disable test-https-client-renegotiation-limit

BoringSSL doesn't support caller-initiated renegotiation - see
https://source.chromium.org/chromium/chromium/src/+/main:third_party/boringssl/src/ssl/ssl_lib.cc;l=1627-1631

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@codebytere @nodejs-github-bot @jasnell @lpinca @joyeecheung @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.