GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc,test: fix docs/api copy by 1ilsang · Pull Request #57109 · nodejs/node

Conversation

@1ilsang

@1ilsang 1ilsang commented Feb 17, 2025

Copy link
Copy Markdown
Member
image

The Copy button doesn't work on page docs/api/typescript.

image

altDocs function is throwing an null properties error because introduced_in is missing.

Probably all API documentation should have <!--introduced_in=vVERSION-->, So Added a test in lint-md.mjs as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot

nodejs-github-bot commented Feb 17, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/typescript
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 17, 2025
jakecastelli
jakecastelli reviewed Feb 18, 2025
View reviewed changes
Comment thread doc/api/typescript.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

jakecastelli
jakecastelli reviewed Feb 18, 2025
View reviewed changes

@jakecastelli jakecastelli left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, except the module introduced _in version may need some confirmations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1ilsang reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@1ilsang
1ilsang requested a review from jakecastelli February 18, 2025 14:12
jakecastelli
jakecastelli approved these changes Feb 19, 2025
View reviewed changes

@jakecastelli jakecastelli left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1ilsang reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@jakecastelli
jakecastelli requested a review from marco-ippolito February 19, 2025 04:00
@jakecastelli jakecastelli added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Feb 19, 2025
marco-ippolito
marco-ippolito approved these changes Feb 19, 2025
View reviewed changes
lpinca
lpinca approved these changes Feb 19, 2025
View reviewed changes
@jakecastelli jakecastelli added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 20, 2025
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Feb 20, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57109
✔  Done loading data for nodejs/node/pull/57109
----------------------------------- PR info ------------------------------------
Title      doc,test: fix docs/api copy (#57109)
Author     1ilsang <[email protected]> (@1ilsang)
Branch     1ilsang:test/md-lint -> nodejs:main
Labels     tools, author ready
Commits    2
 - doc,test: fix docs/api copy
 - doc: fix introduced version
Committers 1
 - 1ilsang <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 17 Feb 2025 17:11:43 GMT
   ✔  Approvals: 3
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/57109#pullrequestreview-2625579028
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57109#pullrequestreview-2625750437
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57109#pullrequestreview-2628003039
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 57109
From https://github.com/nodejs/node
 * branch                  refs/pull/57109/merge -> FETCH_HEAD
✔  Fetched commits as f6ce48636b08..721e37db3758
--------------------------------------------------------------------------------
[main 6c319eff14] doc,test: fix docs/api copy
 Author: 1ilsang <[email protected]>
 Date: Tue Feb 18 01:59:41 2025 +0900
 2 files changed, 10 insertions(+)
[main d7497a1d90] doc: fix introduced version
 Author: 1ilsang <[email protected]>
 Date: Tue Feb 18 18:27:35 2025 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc,test: fix docs/api copy

PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD 4a39dbd484] doc,test: fix docs/api copy
Author: 1ilsang <[email protected]>
Date: Tue Feb 18 01:59:41 2025 +0900
2 files changed, 10 insertions(+)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: fix introduced version

PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD 03c94ae515] doc: fix introduced version
Author: 1ilsang <[email protected]>
Date: Tue Feb 18 18:27:35 2025 +0900
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/13427134365

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakecastelli

jakecastelli commented Feb 20, 2025

Copy link
Copy Markdown
Member

A miner suggestion for the commit messages:

first commit - tools: consolidate introduced_in check for docs
second commit - doc: fix introduced_in version in typescript module

1ilsang reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jakecastelli jakecastelli removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Feb 20, 2025
1ilsang added 2 commits February 20, 2025 12:39
@1ilsang
tools: consolidate 'introduced_in' check for docs
4171546
@1ilsang
doc: fix 'introduced_in' version in typescript module
dff2f62
@1ilsang
1ilsang force-pushed the test/md-lint branch from 721e37d to dff2f62 Compare February 20, 2025 03:40
jakecastelli
jakecastelli approved these changes Feb 20, 2025
View reviewed changes
@jakecastelli jakecastelli added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Feb 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 20, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

Landed in 15fec13...867a754

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot pushed a commit that referenced this pull request Feb 20, 2025
@1ilsang @nodejs-github-bot
tools: consolidate 'introduced_in' check for docs
03fdde5
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Feb 20, 2025
@1ilsang @nodejs-github-bot
doc: fix 'introduced_in' version in typescript module
867a754
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@nodejs-github-bot nodejs-github-bot closed this Feb 20, 2025
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@1ilsang @acidiney
tools: consolidate 'introduced_in' check for docs
dea1598
PR-URL: nodejs#57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
@1ilsang @acidiney
doc: fix 'introduced_in' version in typescript module
28b8d5b
PR-URL: nodejs#57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
@1ilsang @targos
tools: consolidate 'introduced_in' check for docs
07249bf
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 24, 2025
@1ilsang @targos
doc: fix 'introduced_in' version in typescript module
ba84b67
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 25, 2025
2025-02-26, Version 23.9.0 (Current) #57207
Merged
targos pushed a commit that referenced this pull request Feb 25, 2025
@1ilsang @targos
tools: consolidate 'introduced_in' check for docs
73a8514
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Feb 25, 2025
@1ilsang @targos
doc: fix 'introduced_in' version in typescript module
fdc8aeb
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@1ilsang @aduh95
tools: consolidate 'introduced_in' check for docs
5cdd08a
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 2, 2025
@1ilsang @aduh95
doc: fix 'introduced_in' version in typescript module
9043ddc
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@1ilsang @aduh95
tools: consolidate 'introduced_in' check for docs
b7e4807
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Apr 3, 2025
@1ilsang @aduh95
doc: fix 'introduced_in' version in typescript module
4b8c62d
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Apr 11, 2025
2025-04-23, Version 22.15.0 'Jod' (LTS), @UlisesGascon prepared by @RafaelGSS #57840
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@1ilsang @RafaelGSS
tools: consolidate 'introduced_in' check for docs
840da26
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 16, 2025
@1ilsang @RafaelGSS
doc: fix 'introduced_in' version in typescript module
1147a10
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@1ilsang @RafaelGSS
tools: consolidate 'introduced_in' check for docs
e65e626
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Apr 17, 2025
@1ilsang @RafaelGSS
doc: fix 'introduced_in' version in typescript module
617fe71
PR-URL: #57109
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@marco-ippolito marco-ippolito added the strip-types Issues and PRs related to TypeScript type stripping. label Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. strip-types Issues and PRs related to TypeScript type stripping. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@1ilsang @nodejs-github-bot @jakecastelli @lpinca @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.