GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix bugs and refactor NativeSymbolDebuggingContext::GetLoadedLibraries by Whitecx · Pull Request #57738 · nodejs/node

Conversation

@Whitecx

@Whitecx Whitecx commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

tldr:

GetLoadedLibraries is used in process.report.GetReport to generate a list of loaded libraries. This PR fixes the following:

  • Random failures when retrieving module file paths
  • Retrieve only up to half the max file path length intended
  • Allocating unused memory for module handles
  • Memory leak from converting file path wchar* strings to utf8 std::strings

--

Refactor:

  1. GetModuleFileNameExW can fail randomly: Microsoft's Documentation recommends using GetModuleFileNameW over GetModuleFileNameExW when a process is trying to get a list of it's own dlls. GetModuleFileNameExW can fail unexpectedly for some calls.
Sources from Docs + Raymond Chen

  • "To retrieve the name of a module in the current process, use the GetModuleFileName function" -- WinApi Docs: Remarks

  • Raymond Chen explains how GetModuleFileNameExW can fail randomly, in a way that GetModuleFileNameW avoids -- Article

Bug Fixes:

  1. Unused Buffer Memory Allocated: The constructor for modules allocates memory by multiplying the constructor arg size_t n by the sizeof it's type. In this case, modules would be allocated with size_1 * sizeof(HMODULE) bytes. But EnumProcessModules sets size_1 to the number of bytes that need to be allocated for the module buffer. Using size_1/sizeof(HMODULE) gives the constructor what it's asking for i.e the number of HMODULES to allocate space for.
Exapnd to Step through MallocedBuffer constructor behavior

src/util.h MallocedBuffer

  explicit MallocedBuffer(size_t size) : data(Malloc<T>(size)), size(size) {}

src/util-inl.h UncheckedMalloc

template <typename T>
inline T* UncheckedMalloc(size_t n) {
  return UncheckedRealloc<T>(nullptr, n);
}

src/util-inl.h UncheckedRealloc

template <typename T>
T* UncheckedRealloc(T* pointer, size_t n) {
  size_t full_size = MultiplyWithOverflowCheck(sizeof(T), n); // <- Expects n to be number of T elements
/* other code not shown... */

  void* allocated = realloc(pointer, full_size);

/* other code not shown... */

  return static_cast<T*>(allocated);
}

src/util-inl.h MultiplyWithOverflowCheck

template <typename T>
inline T MultiplyWithOverflowCheck(T a, T b) {
  auto ret = a * b;
  if (a != 0)
    CHECK_EQ(b, ret / a);

  return ret;
}

  1. Unnecessary Module path truncation: GetModuleFileName is called using array_size(module_name) / sizeof(WCHAR) for the nSize param. nSize is supposed to be the number of characters in the wchar array supplied. module_name is already a WCHAR array, so nSize should just be array_size(module_name). The current code causes GetModuleFileName to truncate after reaching half the capacity of the buffer (i.e half of MAX_PATH)

  2. Memory Leak: When converting the file path written by GetModuleFileName from a wchar array to a char array with UTF8 encoding, a char array str is added to the heap using new. Next, it's added to list, a std::vector<std::string> using emplace_back. emplace_back will pass str intro the std::string constructor. This constructor is defined to copy values from a null terminated char * array into the std::string. I assume str was created on the heap so that it could be dynamically allocated based on the number of bytes returned by WideCharToMultiByte. Once it's added to list, the memory is no longer needed, but is never deleted from the heap.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Whitecx added 3 commits April 3, 2025 13:46
@Whitecx
src: fix module buffer allocation
48d4baa
@Whitecx
src: Replace GetModuleFileNameExW with GetModuleFileNameW
0f261b5
@Whitecx
src: fix GetModuleFileName param
6584451
@Whitecx
Whitecx marked this pull request as draft April 3, 2025 18:31
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. debugger Issues and PRs related to the Node.js command-line debugger. needs-ci PRs that need a full CI run. labels Apr 3, 2025
@imronsman

This comment was marked as off-topic.

Sign in to view
@Whitecx
src: fix memory leak from string conversion
80624e0 
missing parenthesis

format c++
@Whitecx
Whitecx force-pushed the reportWin32Modules branch from 8aea264 to 80624e0 Compare April 3, 2025 20:37
@Whitecx Whitecx changed the title Report win32 modules src: Fix bugs and refactor NativeSymbolDebuggingContext::GetLoadedLibraries Apr 3, 2025
@Whitecx
Whitecx marked this pull request as ready for review April 3, 2025 22:34
@codecov

codecov Bot commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (668a0b8) to head (80624e0).
Report is 311 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57738   +/-   ##
=======================================
  Coverage   90.24%   90.25%           
=======================================
  Files         630      630           
  Lines      184949   184989   +40     
  Branches    36207    36218   +11     
=======================================
+ Hits       166902   166954   +52     
+ Misses      11002    10997    -5     
+ Partials     7045     7038    -7
Files with missing lines Coverage Δ
src/debug_utils.cc 60.90% <ø> (ø)

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 9, 2025
addaleax
addaleax approved these changes Apr 9, 2025
View reviewed changes
Comment thread src/debug_utils.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax changed the title src: Fix bugs and refactor NativeSymbolDebuggingContext::GetLoadedLibraries src: fix bugs and refactor NativeSymbolDebuggingContext::GetLoadedLibraries Apr 9, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66176/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Whitecx

Whitecx commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

@addaleax There seems to be a fair amount of Builds that failed on pummel.test-buffer-large-size due to a timeout after 12mins, like this one. Is this a test that's known to fail from time to time?

This Build Failure

Other Builds
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Whitecx

Whitecx commented Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

@H4ad if you have a moment, does the build failure I linked in the comment above look to be from a flaky test? The code I changed shouldn't have affected this test, and there's a pattern of timeout failures for this test on other builds too.

If that is the case, could you add the request-ci label again? I think it just needs to be re-run.
H4ad reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66338/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad

H4ad commented Apr 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

19:11:01 not ok 4038 pummel/test-buffer-large-size
19:11:01 ---
19:11:01 duration_ms: 720098.82500
19:11:01 severity: fail
19:11:02 exitcode: -15
19:11:02 stack: |-
19:11:02 timeout
19:11:02 (node:3252246) [DEP0030] DeprecationWarning: SlowBuffer() is deprecated. Please use Buffer.allocUnsafeSlow()
19:11:02 (Use node --trace-deprecation ... to show where the warning was created)
19:11:02 ...

Looks like a flaky test, I resume the CI in the Jenkins, you can ask to resume the CI instead of add request-ci again, adding the label again will re-run all the tests again (instead of just the one that failed)
Whitecx reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Whitecx

Whitecx commented Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

@H4ad A test that completed w/ "unstable" last time failed this time, but it seems the test never actually ran. It died while being setup. Are there some artifacts relative to the initial ci run that no longer exist? Hopefully that doesn't mean having to re-run more than what failed 😅

Build Failure

00:52:14 + git archive --format=tar [email protected]:binary_tmp.git jenkins-node-test-commit-windows-fanned-80624e0eecfa92dce184ae3d27c806a049d9cafc src/node_version.h -o node_version.h.tar
...
remote: fatal: no such ref: jenkins-node-test-commit-windows-fanned-80624e0eecfa92dce184ae3d27c806a049d9cafc        
00:52:15 remote: git upload-archive: archiver died with error
00:52:15 fatal: sent error to the client: git upload-archive: archiver died with error
H4ad reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66363/ 💛
Whitecx reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad H4ad added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Apr 19, 2025
@H4ad

H4ad commented Apr 19, 2025

Copy link
Copy Markdown
Member

friendly ping to @nodejs/platform-windows before adding commit-queue
Whitecx reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Whitecx

Whitecx commented May 9, 2025

Copy link
Copy Markdown
Contributor Author

@jasnell if you have a moment, would you mind confirming whether or not this can be commit-queued? No worries at all if you’re busy (please ignore if so!😊)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad H4ad added the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 9, 2025
@nodejs-github-bot
nodejs-github-bot merged commit e4e80c5 into nodejs:main May 9, 2025
@github-actions github-actions Bot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@Whitecx @aduh95
src: fix module buffer allocation
3f834da 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged
@codebytere codebytere mentioned this pull request Jun 26, 2025
src: -Wmismatched-new-delete in debug_utils.cc #58844
Merged
codebytere added a commit to electron/electron that referenced this pull request Jun 26, 2025
@codebytere
src: fix module buffer allocation
4401a74 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025
@codebytere
src: fix module buffer allocation
d7ace93 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 28, 2025
@electron-roller @codebytere
chore: bump node to v22.17.0 (main) (#47557)
4dcccca 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
src: fix module buffer allocation
5066736 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
src: fix module buffer allocation
9a16e0b 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
src: fix module buffer allocation
027bc76 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
src: fix module buffer allocation
92ad23b 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
src: fix module buffer allocation
d6d1bbf 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
src: fix module buffer allocation
b8b7832 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@electron-roller @codebytere @patchup
chore: bump node to v22.17.0 (38-x-y) (#47556)
f6d054f 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@electron-roller @codebytere @patchup
chore: bump node to v22.17.0 (37-x-y) (#47555)
65c062d 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
@codebytere
src: fix module buffer allocation
2c3f810 
nodejs/node#57738
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
@electron-roller @codebytere @patchup
chore: bump node to v22.17.0 (36-x-y) (#47554)
da2f4eb 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
e44a550 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
0ba36c6 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2025
2025-09-03, Version 20.19.5 'Iron' (LTS) #59551
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
7bf05c3 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 23, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
4f8580b 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
5df8511 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
b6a458c 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
0f8968e 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@Whitecx @marco-ippolito
src: fix module buffer allocation
5daa7fe 
PR-URL: #57738
Reviewed-By: Anna Henningsen <[email protected]>
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@electron-roller @codebytere @kigh-ota
chore: bump node to v22.17.0 (main) (electron#47557)
0da55c0 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
@Brooooooklyn Brooooooklyn mentioned this pull request Oct 22, 2025
npm oxc-parser: importing package in Node worker thread leads to heap corruption error on Windows oxc-project/oxc#14732
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. debugger Issues and PRs related to the Node.js command-line debugger. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Whitecx @imronsman @nodejs-github-bot @H4ad @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.