GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: use FILE_OFFSET_BITS=64 even on 32-bit arch by RafaelGSS · Pull Request #58090 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Apr 30, 2025

Copy link
Copy Markdown
Member

Refs: #57934

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS
RafaelGSS requested review from mcollina, mhdawson and richardlau April 30, 2025 20:24
@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Apr 30, 2025
mcollina
mcollina approved these changes Apr 30, 2025
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aduh95
aduh95 approved these changes Apr 30, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. lts-watch-v20.x labels Apr 30, 2025
richardlau
richardlau approved these changes Apr 30, 2025
View reviewed changes
@richardlau richardlau added the lts-watch-v22.x PRs that may need to be released in v22.x label Apr 30, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 30, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66520/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes May 1, 2025
View reviewed changes
@bnoordhuis

bnoordhuis commented May 1, 2025

Copy link
Copy Markdown
Member

s/even on/esp. on/ - on 64 bits architectures the define is a no-op because off_t is already 64 bits.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66523/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes May 1, 2025
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS @richardlau
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
2f9406d 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
@RafaelGSS
RafaelGSS force-pushed the use-file-offset-bits-64-by-default branch from 6132c85 to 2f9406d Compare May 4, 2025 16:34
@RafaelGSS

RafaelGSS commented May 6, 2025

Copy link
Copy Markdown
Member Author

CI was green. Landing it manually as I had to update commit title.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS added a commit that referenced this pull request May 6, 2025
@RafaelGSS @richardlau
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
74c8358 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@RafaelGSS

RafaelGSS commented May 6, 2025

Copy link
Copy Markdown
Member Author

Landed in 74c8358
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS closed this May 6, 2025
targos pushed a commit that referenced this pull request May 16, 2025
@RafaelGSS @richardlau @targos
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
2e54653 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged
@marco-ippolito marco-ippolito removed the lts-watch-v20.x label Jun 5, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@RafaelGSS @richardlau @marco-ippolito
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
0b1f466 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@RafaelGSS @richardlau @marco-ippolito
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
fc1fa7a 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 5, 2025
v20.19.3 proposal #58588
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@RafaelGSS @richardlau @aduh95
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
04c8f59 
Co-Authored-By: richardlau - Richard Lau <[email protected]>
PR-URL: #58090
Refs: #57934
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@aduh95 aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Jun 10, 2025
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged
codebytere added a commit to electron/electron that referenced this pull request Jun 26, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
7a3f938 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 27, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
585c65d 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 28, 2025
@electron-roller @codebytere
chore: bump node to v22.17.0 (main) (#47557)
4dcccca 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
a34cc80 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
d61e58f 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
8ec83fb 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
2651893 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
feda3b9 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
a8c9d5c 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@electron-roller @codebytere @patchup
chore: bump node to v22.17.0 (38-x-y) (#47556)
f6d054f 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jun 30, 2025
@electron-roller @codebytere @patchup
chore: bump node to v22.17.0 (37-x-y) (#47555)
65c062d 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
@codebytere
build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch
70b07bd 
nodejs/node#58090
codebytere added a commit to electron/electron that referenced this pull request Jul 2, 2025
@electron-roller @codebytere @patchup
chore: bump node to v22.17.0 (36-x-y) (#47554)
da2f4eb 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

* chore: update patches

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@electron-roller @codebytere @kigh-ota
chore: bump node to v22.17.0 (main) (electron#47557)
0da55c0 
* chore: bump node in DEPS to v22.17.0

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* chore: adjust crypto specs:

- nodejs/node#58117
- nodejs/node#58387

* deps: update libuv to 1.51.0

nodejs/node#58124

* test: fix test-buffer-tostring-range on allocation failure

nodejs/node#58416

* build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch

nodejs/node#58090

* build: use //third_party/simdutf by default in GN

nodejs/node#58115

* inspector: add protocol method Network.dataReceived

nodejs/node#58001

* test: force slow JSON.stringify path for overflow

nodejs/node#58181

* chore: fixup patch indices

* 6049967: Remove protocol::Maybe and roll inspector_protocol

https://chromium-review.googlesource.com/c/chromium/src/+/6049967

* chore: fixup crypto test patch

* src: fix module buffer allocation

nodejs/node#57738

* crypto: expose process.features.openssl_is_boringssl

nodejs/node#58387

* util: add internal assignFunctionName() function

nodejs/node#57916

* build: fix pointer compression builds

nodejs/node#58171

* chore: put back config options

* fixup! deps: update libuv to 1.51.0

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. backported-to-v22.x PRs backported to the v22.x-staging branch. build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@RafaelGSS @nodejs-github-bot @bnoordhuis @mcollina @anonrig @richardlau @mhdawson @aduh95 @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.