GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — New SQlite database options by miguelmarcondesf · Pull Request #58697 · nodejs/node

Conversation

miguelmarcondesf commented Jun 12, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This introduces new SQLite database options that can be set at the database connection level.

cc @geeksilva97

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

miguelmarcondesf added 6 commits

June 11, 2025 17:52


          sqlite: add support for readBigInts option in db connection level

6836df6


          sqlite: add readBigInts as env property

68889b1


          sqlite: add support for returnArrays option in db connection

2f589fa


          sqlite: add support for allowBareNamedParameters option in db connection

88be767


          sqlite: add support for allowUnknownNamedParameters option in db conn…

917a093

…ection


          doc: document new options for database connection

1aca01e

nodejs-github-bot commented Jun 12, 2025

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/sqlite

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Jun 12, 2025

miguelmarcondesf marked this pull request as ready for review

June 13, 2025 11:29

codecov Bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.11%. Comparing base (5457443) to head (5693d3c).
Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	92.00%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58697      +/-   ##
==========================================
+ Coverage   90.03%   90.11%   +0.07%     
==========================================
  Files         635      639       +4     
  Lines      187688   188262     +574     
  Branches    36761    36924     +163     
==========================================
+ Hits       168991   169654     +663     
+ Misses      11499    11326     -173     
- Partials     7198     7282      +84

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.67% <100.00%> (+15.67%)`	⬆️
src/node_sqlite.cc	`81.06% <92.00%> (+0.26%)`	⬆️

... and 78 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 commented Jun 17, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

~~Since it's addressing a TODO comment, you need to remove it from the code. I was unable to see it~~

I'm wrong

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 reviewed

Jun 17, 2025

View reviewed changes

Comment thread

test/parallel/test-sqlite-database-sync.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 reviewed

Jun 17, 2025

View reviewed changes

Comment thread

test/parallel/test-sqlite-database-sync.js Resolved

Uh oh!

There was an error while loading. Please reload this page.


          doc: update SQLite documentation with changes

7f0c06b

miguelmarcondesf requested a review from geeksilva97

June 17, 2025 20:05

geeksilva97 added the sqlite Issues and PRs related to the SQLite subsystem. label

Jun 18, 2025

geeksilva97 commented Jun 18, 2025

Copy link

Copy Markdown

Contributor

There are a few tests I think we don't need because they are redundant, e.g., those that handle the default scenario. Here, for example, the default is false already, which is already covered.

Other than that, I think you addressed the left comments as expected. Thank you.

I will just ping @nodejs/cpp-reviewers to get a more experienced C++ review.

miguelmarcondesf reacted with heart emoji

miguelmarcondesf reacted with rocket emoji

All reactions

❤️ 1 reaction
🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS reviewed

Jun 18, 2025

View reviewed changes

Comment thread

doc/api/sqlite.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS added semver-minor

PRs that contain new features and should be released in the next minor version.

commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels

Jun 18, 2025

RafaelGSS approved these changes

Jun 18, 2025

View reviewed changes

RafaelGSS left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpp code LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 and miguelmarcondesf reacted with heart emoji

All reactions

❤️ 2 reactions

lemire reviewed

Jun 18, 2025

View reviewed changes

Comment thread

src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

lemire reviewed

Jun 18, 2025

View reviewed changes

Comment thread

src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

lemire reviewed

Jun 18, 2025

View reviewed changes

Comment thread

src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

lemire reviewed

Jun 18, 2025

View reviewed changes

Comment thread

src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

lemire approved these changes

Jun 18, 2025

View reviewed changes

lemire left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggested changes are optional.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 and miguelmarcondesf reacted with heart emoji

All reactions

❤️ 2 reactions

miguelmarcondesf and others added 2 commits

June 18, 2025 12:28


          test: remove redundant default values tests

d7f08c0


          doc: fix replacemme

a0d04ad

Co-authored-by: Rafael Gonzaga <[email protected]>

This comment was marked as outdated.

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 20, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jun 20, 2025

This comment was marked as outdated.

geeksilva97 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Jun 20, 2025

This comment was marked as outdated.

geeksilva97 requested a review from cjihrig

June 23, 2025 13:37

nodejs-github-bot commented Jun 24, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67630/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels

Jun 24, 2025

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Jun 24, 2025

nodejs-github-bot merged commit d08513d into nodejs:main

Jun 24, 2025

nodejs-github-bot commented Jun 24, 2025

Copy link

Copy Markdown

Collaborator

Landed in d08513d

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request

Jul 3, 2025


          sqlite: add support for readBigInts option in db connection level

797ec4d

PR-URL: #58697
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

github-actions Bot mentioned this pull request

Jul 8, 2025

2025-07-09, Version 24.4.0 (Current) #58993

Merged

nodejs-github-bot added a commit that referenced this pull request

Jul 8, 2025


          2025-07-09, Version 24.4.0 (Current)

5576dec

Notable changes:

crypto:
  * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
fs:
  * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719

PR-URL: #58993

RafaelGSS pushed a commit that referenced this pull request

Jul 9, 2025


          2025-07-09, Version 24.4.0 (Current)

c4169cb

Notable changes:

crypto:
  * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
fs:
  * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719

PR-URL: #58993

aduh95 pushed a commit that referenced this pull request

Jul 21, 2025


          sqlite: add support for readBigInts option in db connection level

6929c7b

PR-URL: #58697
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

aduh95 pushed a commit that referenced this pull request

Jul 24, 2025


          sqlite: add support for readBigInts option in db connection level

ccca151

PR-URL: #58697
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Edy Silva <[email protected]>

github-actions Bot mentioned this pull request

Jul 28, 2025

2025-07-29, Version 22.18.0 'Jod' (LTS) #59256

Merged

aduh95 added a commit that referenced this pull request

Jul 28, 2025


          2025-07-29, Version 22.18.0 'Jod' (LTS)

4c1b52e

Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <[email protected]>

aduh95 added a commit that referenced this pull request

Jul 31, 2025


          2025-07-31, Version 22.18.0 'Jod' (LTS)

c9ff1ae

Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <[email protected]>

aduh95 added a commit that referenced this pull request

Jul 31, 2025


          2025-07-31, Version 22.18.0 'Jod' (LTS)

5acb923

Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <[email protected]>

mete0rfish pushed a commit to mete0rfish/node-contribute that referenced this pull request

Aug 9, 2025


          2025-07-31, Version 22.18.0 'Jod' (LTS)

159aa69

Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <[email protected]>

varanauskas mentioned this pull request

Nov 19, 2025

node:sqlite is missing options present since Node v24.4.0 (backported to v22.18.0) denoland/deno#31346

Closed

Reviewers

lemire

lemire approved these changes

geeksilva97

geeksilva97 approved these changes

RafaelGSS

RafaelGSS approved these changes

cjihrig

Awaiting requested review from cjihrig

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

c++

Issues and PRs that require attention from people who are familiar with C++.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

semver-minor

PRs that contain new features and should be released in the next minor version.

sqlite

Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

miguelmarcondesf commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 12, 2025

Uh oh!

codecov Bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geeksilva97 commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geeksilva97 commented Jun 18, 2025

Uh oh!

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemire left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jun 24, 2025

Uh oh!

nodejs-github-bot commented Jun 24, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miguelmarcondesf commented Jun 12, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

geeksilva97 commented Jun 17, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.