GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — watch: add `--watch-kill-signal` flag by dario-piotrowicz · Pull Request #58719 · nodejs/node

Conversation

@dario-piotrowicz

@dario-piotrowicz dario-piotrowicz commented Jun 15, 2025

Copy link
Copy Markdown
Member

add the new --watch-kill-signal to allow users to customize what signal is sent to the process on restarts during watch mode

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and adarshmadrecha reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jun 15, 2025
@dario-piotrowicz dario-piotrowicz added semver-minor PRs that contain new features and should be released in the next minor version. needs-ci PRs that need a full CI run. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. and removed c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Jun 15, 2025
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 1d23a46 to 96426c5 Compare June 15, 2025 18:09
anonrig
anonrig reviewed Jun 15, 2025
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation changes are missing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 96426c5 to 83894cf Compare June 15, 2025 18:18
@dario-piotrowicz

dario-piotrowicz commented Jun 15, 2025

Copy link
Copy Markdown
Member Author

Documentation changes are missing

Sorry my bad 🙇 , doc changes added 🙂👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Jun 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (eaebfab) to head (ce4776c).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58719      +/-   ##
==========================================
- Coverage   90.09%   90.08%   -0.02%     
==========================================
  Files         640      640              
  Lines      188450   188452       +2     
  Branches    36966    36963       -3     
==========================================
- Hits       169789   169766      -23     
- Misses      11364    11404      +40     
+ Partials     7297     7282      -15
Files with missing lines Coverage Δ
src/node_options.cc 84.59% <100.00%> (+0.13%) ⬆️
src/node_options.h 97.87% <100.00%> (+0.01%) ⬆️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch 2 times, most recently from 887d4b7 to f90f6be Compare June 15, 2025 20:31
anonrig
anonrig approved these changes Jun 15, 2025
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jun 15, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jun 15, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from f90f6be to 973b29c Compare June 17, 2025 21:38
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 973b29c to 3b17c10 Compare June 17, 2025 22:55
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/watch-mode-kill-signal branch from 3b17c10 to 229863f Compare June 18, 2025 00:01
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2025

Copy link
Copy Markdown
Collaborator

Landed in f0a9478...4d5ee24
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nodejs-github-bot pushed a commit that referenced this pull request Jun 28, 2025
@dario-piotrowicz @nodejs-github-bot
watch: add --watch-kill-signal flag
529967a 
add the new `--watch-kill-signal` to allow users to customize
what signal is sent to the process on restarts during watch mode

PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 28, 2025
@dario-piotrowicz @nodejs-github-bot
doc: add all watch-mode related flags to node.1
4d5ee24 
PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
@nodejs-github-bot nodejs-github-bot closed this Jun 28, 2025
@dario-piotrowicz
dario-piotrowicz deleted the dario/watch-mode-kill-signal branch June 29, 2025 00:57
targos pushed a commit that referenced this pull request Jul 3, 2025
@dario-piotrowicz @targos
watch: add --watch-kill-signal flag
fe17f5d 
add the new `--watch-kill-signal` to allow users to customize
what signal is sent to the process on restarts during watch mode

PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Jul 3, 2025
@dario-piotrowicz @targos
doc: add all watch-mode related flags to node.1
80dec98 
PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jul 8, 2025
2025-07-09, Version 24.4.0 (Current) #58993
Merged
nodejs-github-bot added a commit that referenced this pull request Jul 8, 2025
@nodejs-github-bot
2025-07-09, Version 24.4.0 (Current)
5576dec 
Notable changes:

crypto:
  * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
fs:
  * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719

PR-URL: #58993
@RafaelGSS

RafaelGSS commented Jul 8, 2025

Copy link
Copy Markdown
Member

@dario-piotrowicz we should have set the stability of this API. Usually, we start with 1.1 (Active Development), but that's not mandatory.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz

dario-piotrowicz commented Jul 8, 2025

Copy link
Copy Markdown
Member Author

@dario-piotrowicz we should have set the stability of this API. Usually, we start with 1.1 (Active Development), but that's not mandatory.

Mh... I see, yes that's a good point... although for something this small and trivial I didn't even consider that 🤔

Would you like me to open a doc PR to add the stability?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS

RafaelGSS commented Jul 8, 2025

Copy link
Copy Markdown
Member

I think that would be great. I'd say to mark it as 1.1, but no need to emit a warning on usage.
dario-piotrowicz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz dario-piotrowicz mentioned this pull request Jul 8, 2025
doc: add stability index to the --watch-kill-signal flag #58997
Merged
@dario-piotrowicz

dario-piotrowicz commented Jul 8, 2025

Copy link
Copy Markdown
Member Author

I think that would be great. I'd say to mark it as 1.1, but no need to emit a warning on usage.

#58997 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Jul 9, 2025
@nodejs-github-bot @RafaelGSS
2025-07-09, Version 24.4.0 (Current)
c4169cb 
Notable changes:

crypto:
  * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121
doc:
  * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719
fs:
  * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719

PR-URL: #58993
@ASAav123 ASAav123 mentioned this pull request Jul 9, 2025
Review requested: #59009
Closed
2 tasks done
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@dario-piotrowicz @aduh95
watch: add --watch-kill-signal flag
e090e17 
add the new `--watch-kill-signal` to allow users to customize
what signal is sent to the process on restarts during watch mode

PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@dario-piotrowicz @aduh95
doc: add all watch-mode related flags to node.1
3228382 
PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@dario-piotrowicz @aduh95
watch: add --watch-kill-signal flag
4dc6b4c 
add the new `--watch-kill-signal` to allow users to customize
what signal is sent to the process on restarts during watch mode

PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@dario-piotrowicz @aduh95
doc: add all watch-mode related flags to node.1
d80ef2a 
PR-URL: #58719
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jul 28, 2025
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256
Merged
aduh95 added a commit that referenced this pull request Jul 28, 2025
@nodejs-github-bot @aduh95
2025-07-29, Version 22.18.0 'Jod' (LTS)
4c1b52e 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95 added a commit that referenced this pull request Jul 31, 2025
@nodejs-github-bot @aduh95
2025-07-31, Version 22.18.0 'Jod' (LTS)
c9ff1ae 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95 added a commit that referenced this pull request Jul 31, 2025
@nodejs-github-bot @aduh95
2025-07-31, Version 22.18.0 'Jod' (LTS)
5acb923 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) #58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385

PR-URL: #59256
Co-authored-by: Antoine du Hamel <[email protected]>
mete0rfish pushed a commit to mete0rfish/node-contribute that referenced this pull request Aug 9, 2025
@nodejs-github-bot @aduh95 @mete0rfish
2025-07-31, Version 22.18.0 'Jod' (LTS)
159aa69 
Notable changes:

deps:
  * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350
doc:
  * add islandryu to collaborators (Shima Ryuhei) nodejs#58714
esm:
  * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804
fs:
  * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490
module:
  * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350
  * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350
permission:
  * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853
sqlite:
  * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697
src,permission:
  * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951
url:
  * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700
watch:
  * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719
worker:
  * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385

PR-URL: nodejs#59256
Co-authored-by: Antoine du Hamel <[email protected]>
@AlCalzone AlCalzone mentioned this pull request May 13, 2026
Consider further Node.js version bumps zwave-js/zwave-js#8820
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@atlowChemi atlowChemi Awaiting requested review from atlowChemi

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@dario-piotrowicz @nodejs-github-bot @RafaelGSS @anonrig @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.