GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: add percentage support to --max-old-space-size by Asaf-Federman · Pull Request #59082 · nodejs/node

Conversation

Asaf-Federman commented Jul 16, 2025

Copy link

Copy Markdown

Contributor

This commit adds support for specifying --max-old-space-size as a percentage of system memory, in addition to the existing MB format. A new HandleMaxOldSpaceSizePercentage method parses percentage values, validates that they are within the 0-100% range, and provides clear error messages for invalid input. The heap size is now calculated based on available system memory when a percentage is used.

Test coverage has been added for both valid and invalid cases. Documentation and the JSON schema for CLI options have been updated with examples for both formats.

Refs: #57447

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

daeyeon, mix4242, kirillgroshkov, daniellockyer, and styfle reacted with hooray emoji

mix4242 and Fdawgs reacted with heart emoji

All reactions

🎉 5 reactions
❤️ 2 reactions

nodejs-github-bot commented Jul 16, 2025

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/config
@nodejs/startup

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci PRs that need a full CI run. labels

Jul 16, 2025

legendecas requested changes

Jul 16, 2025

View reviewed changes

legendecas left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on re-interpreting a V8 flag with different semantic in Node.js as it could lead to confusions. I'd be open to a new flag though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax, jasnell, and MoLow reacted with thumbs up emoji

All reactions

👍 3 reactions

Comment thread

doc/api/cli.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Asaf-Federman commented Jul 16, 2025

Copy link

Copy Markdown

Contributor Author

I'm -1 on re-interpreting a V8 flag with different semantic in Node.js as it could lead to confusions. I'd be open to a new flag though.

Isn't it dangerous having two different flags for the same underlying v8 option?
If user will specify both flags, which one will take precedence? Or should we throw exception in this case?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas commented Jul 16, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

We can define that a flag will alway take precedence over another, e.g. --max-old-space-size-percentage always override --max-old-space-size. I'd only consider it is harmful if a flag conditionally take precedence.

See node --v8-options:

  --max-heap-size (max size of the heap (in Mbytes) both max_semi_space_size and max_old_space_size take precedence. All three flags cannot be specified at the same time.)

It could also be a good practice to abort if both flags are set. When all three heap size options --max-heap-size=20 --max-old-space-size=20 --max-semi-space-size=20 are set at the same time, V8 aborts.

And, like mentioned, there are three heap size options. I'm -0 on introduce 3 new flags on each of them, TBH.

MoLow reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Asaf-Federman commented Jul 16, 2025

Copy link

Copy Markdown

Contributor Author

We can define that a flag will alway take precedence over another, e.g. --max-old-space-size-percentage always override --max-old-space-size. I'd only consider it is harmful if a flag conditionally take precedence.

See node --v8-options:
  --max-heap-size (max size of the heap (in Mbytes) both max_semi_space_size and max_old_space_size take precedence. All three flags cannot be specified at the same time.)
It could also be a good practice to abort if both flags are set. When all three heap size options --max-heap-size=20 --max-old-space-size=20 --max-semi-space-size=20 are set at the same time, V8 aborts.

And, like mentioned, there are three heap size options. I'm -0 on introduce 3 new flags on each of them, TBH.

As long as there's an agreed way of action, I don't mind changing the implementation

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Asaf-Federman requested a review from legendecas

July 17, 2025 12:25

jasnell commented Jul 18, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Another approach would be to see if v8 would accept a patch adding this as an additional v8 flag... I can see it potentially being generically useful for all v8 users

MoLow reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell reviewed

Jul 18, 2025

View reviewed changes

Comment thread

src/node_options.cc Outdated

jasnell Jul 18, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why double? It's likely best to just allow integer values here between 0 and 100. Not critical, of course, I'd just find it a bit cleaner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Asaf-Federman Jul 18, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why double? It's likely best to just allow integer values here between 0 and 100. Not critical, of course, I'd just find it a bit cleaner

Should this be an integer, or would a float provide better flexibility for nodes with a large amount of memory?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

jasnell Jul 18, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really depends on how granular we want it to be. Personally I'd be fine with integer and just not worry about fractional percentages but I'd be interested in what others think

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

MoLow Jul 22, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it was a breaking change I would agree, but this is a new feature, why not support more usecases even if they are rare?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Asaf-Federman commented Jul 18, 2025

Copy link

Copy Markdown

Contributor Author

Another approach would be to see if v8 would accept a patch adding this as an additional v8 flag... I can see it potentially being generically useful for all v8 users

#57447

I have already approached the V8 team, and they have indicated that a contribution to the Node.js project would be more appropriate.
Please see here

jasnell, daeyeon, and MoLow reacted with thumbs up emoji

All reactions

👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

staskorz commented Jul 20, 2025

Copy link

Copy Markdown

This will be a huge help, appreciate you working on this!

Asaf-Federman reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Jul 21, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (6bb08f7) to head (8e5f5ea).
⚠️ Report is 395 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_options.cc	86.36%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59082      +/-   ##
==========================================
+ Coverage   90.04%   90.06%   +0.02%     
==========================================
  Files         648      648              
  Lines      190978   191006      +28     
  Branches    37434    37438       +4     
==========================================
+ Hits       171964   172028      +64     
+ Misses      11641    11606      -35     
+ Partials     7373     7372       -1

Files with missing lines	Coverage Δ
src/node.cc	`74.93% <100.00%> (+0.20%)`	⬆️
src/node_options.h	`97.87% <ø> (ø)`
src/node_options.cc	`84.65% <86.36%> (+0.04%)`	⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell approved these changes

Jul 21, 2025

View reviewed changes

legendecas reviewed

Jul 21, 2025

View reviewed changes

Comment thread

doc/api/cli.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

MoLow approved these changes

Jul 22, 2025

View reviewed changes

Asaf-Federman added 8 commits

July 23, 2025 21:19


          src: add percentage support to --max-old-space-size

c837d14

This commit adds support for specifying --max-old-space-size as a
percentage of system memory, in addition to the existing MB format.
A new HandleMaxOldSpaceSizePercentage method parses percentage values,
validates that they are within the 0-100% range, and provides clear
error messages for invalid input. The heap size is now calculated
based on available system memory when a percentage is used.

Test coverage has been added for both valid and invalid cases.
Documentation and the JSON schema for CLI options have been updated
with examples for both formats.

Refs: nodejs#57447


          doc: remove unrelated changes

90f8288


          src: introduce max-old-space-size-percentage as a new cli flag

84d3433


          doc: remove doc related to modified implementation

ebaa850


          doc: change max-old-space-size-percentage type to be number

c377756


          doc: revert max-old-space-size-percentage type to be a string

a23ece3


          doc: fix linting and doc issues

b919043


          src: handle UINT64_MAX (according to libuv doc) and remove redundant …

8e5f5ea

…validation

Asaf-Federman force-pushed the feat/max-old-space-size-percentage branch from a121c70 to 8e5f5ea Compare

July 23, 2025 18:19

Asaf-Federman commented Jul 23, 2025

Copy link

Copy Markdown

Contributor Author

I've just force-pushed an update to this branch. I had to amend the commit history to unify the author identity across all commits.

The underlying code logic has not changed.

Apologies for any inconvenience this may cause.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Asaf-Federman requested a review from legendecas

July 24, 2025 07:51

legendecas added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label

Jul 24, 2025

legendecas reviewed

Jul 24, 2025

View reviewed changes

Comment thread

test/parallel/test-max-old-space-size-percentage.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label

Sep 17, 2025

Asaf-Federman added a commit to Asaf-Federman/node that referenced this pull request

Oct 11, 2025


          src: add percentage support to --max-old-space-size

b932ba7

This commit adds support for specifying --max-old-space-size as a
percentage of system memory, in addition to the existing MB format.
A new HandleMaxOldSpaceSizePercentage method parses percentage values,
validates that they are within the 0-100% range, and provides clear
error messages for invalid input. The heap size is now calculated
based on available system memory when a percentage is used.

Test coverage has been added for both valid and invalid cases.
Documentation and the JSON schema for CLI options have been updated
with examples for both formats.

Refs: nodejs#57447
PR-URL: nodejs#59082
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>

aduh95 pushed a commit that referenced this pull request

Oct 17, 2025


          src: add percentage support to --max-old-space-size

686ac49

This commit adds support for specifying --max-old-space-size as a
percentage of system memory, in addition to the existing MB format.
A new HandleMaxOldSpaceSizePercentage method parses percentage values,
validates that they are within the 0-100% range, and provides clear
error messages for invalid input. The heap size is now calculated
based on available system memory when a percentage is used.

Test coverage has been added for both valid and invalid cases.
Documentation and the JSON schema for CLI options have been updated
with examples for both formats.

Refs: #57447
PR-URL: #59082
Backport-PR-URL: #59631
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: theanarkh <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>

aduh95 added a commit that referenced this pull request

Oct 17, 2025


          2025-10-20, Version 22.21.0 'Jod' (LTS)

f1a42f7

Notable changes:

http:
  * (SEMVER-MINOR) add shouldUpgradeCallback to let servers control HTTP upgrades (Tim Perry) #59824
src:
  * (SEMVER-MINOR) add percentage support to --max-old-space-size (Asaf Federman) #59082

PR-URL: #60230

aduh95 mentioned this pull request

Oct 17, 2025

2025-10-20, Version 22.21.0 'Jod' (LTS) #60230

Merged

aduh95 added a commit that referenced this pull request

Oct 18, 2025


          2025-10-20, Version 22.21.0 'Jod' (LTS)

54b94e1

Notable changes:

cli:
  * (SEMVER-MINOR) add `--use-env-proxy` (Joyee Cheung) #59151
http:
  * (SEMVER-MINOR) support http proxy for fetch under `NODE_USE_ENV_PROXY` (Joyee Cheung) #57165
  * (SEMVER-MINOR) add `shouldUpgradeCallback` to let servers control HTTP upgrades (Tim Perry) #59824
http,https:
  * (SEMVER-MINOR) add built-in proxy support in `http`/`https.request` and `Agent` (Joyee Cheung) #58980
src:
  * (SEMVER-MINOR) add percentage support to `--max-old-space-size` (Asaf Federman) #59082

PR-URL: #60230

aduh95 added a commit that referenced this pull request

Oct 20, 2025


          2025-10-20, Version 22.21.0 'Jod' (LTS)

b9dedf4

Notable changes:

cli:
  * (SEMVER-MINOR) add `--use-env-proxy` (Joyee Cheung) #59151
http:
  * (SEMVER-MINOR) support http proxy for fetch under `NODE_USE_ENV_PROXY` (Joyee Cheung) #57165
  * (SEMVER-MINOR) add `shouldUpgradeCallback` to let servers control HTTP upgrades (Tim Perry) #59824
http,https:
  * (SEMVER-MINOR) add built-in proxy support in `http`/`https.request` and `Agent` (Joyee Cheung) #58980
src:
  * (SEMVER-MINOR) add percentage support to `--max-old-space-size` (Asaf Federman) #59082

PR-URL: #60230

codebytere added a commit to electron/electron that referenced this pull request

Oct 23, 2025


          src: add percentage support to --max-old-space-size

b627bd4

nodejs/node#59082

codebytere added a commit to electron/electron that referenced this pull request

Oct 23, 2025


          src: add percentage support to --max-old-space-size

1238fa9

nodejs/node#59082

codebytere added a commit to electron/electron that referenced this pull request

Oct 23, 2025


          src: add percentage support to --max-old-space-size

6e197e1

nodejs/node#59082

codebytere added a commit to electron/electron that referenced this pull request

Oct 24, 2025


          src: add percentage support to --max-old-space-size

900ddde

nodejs/node#59082

codebytere added a commit to electron/electron that referenced this pull request

Oct 24, 2025


          src: add percentage support to --max-old-space-size

d7a8661

nodejs/node#59082

codebytere added a commit to electron/electron that referenced this pull request

Oct 27, 2025


          src: add percentage support to --max-old-space-size

760f477

nodejs/node#59082

codebytere added a commit to electron/electron that referenced this pull request

Oct 28, 2025


          src: add percentage support to --max-old-space-size

851df7e

nodejs/node#59082

jkleinsc pushed a commit to electron/electron that referenced this pull request

Oct 29, 2025


          src: add percentage support to --max-old-space-size

f38acf2

nodejs/node#59082
(cherry picked from commit 851df7e)

codebytere added a commit to electron/electron that referenced this pull request

Oct 30, 2025


          src: add percentage support to --max-old-space-size

nodejs/node#59082

jkleinsc added a commit to electron/electron that referenced this pull request

Oct 30, 2025


          chore: bump node to v22.21.1 (39-x-y) (#48616)

0c03766

* chore: bump node in DEPS to v22.21.0

* chore: bump node in DEPS to v22.21.1

* chore: update patches

* fixup patches/node/api_remove_deprecated_getisolate.patch

* src: add percentage support to --max-old-space-size

nodejs/node#59082
(cherry picked from commit 851df7e)

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>
Co-authored-by: Shelley Vohr <[email protected]>

jkleinsc added a commit to electron/electron that referenced this pull request

Oct 30, 2025


          src: add percentage support to --max-old-space-size

cf0122e

nodejs/node#59082

jkleinsc added a commit to electron/electron that referenced this pull request

Oct 30, 2025


          src: add percentage support to --max-old-space-size

5209bb9

nodejs/node#59082

codebytere pushed a commit to electron/electron that referenced this pull request

Oct 30, 2025


          chore: bump node to v22.21.1 (38-x-y) (#48615)

3083fab

* chore: bump node in DEPS to v22.21.0

* chore: bump node in DEPS to v22.21.1

* chore: update patches

* lib,src: refactor assert to load error source from memory

nodejs/node#59751

* src: add percentage support to --max-old-space-size

nodejs/node#59082

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>

codebytere added a commit to electron/electron that referenced this pull request

Oct 30, 2025


          chore: upgrade Node.js to v24.10.0 (#48613)

3345edd

* chore: upgrade Node.js to v24.10.0

* chore: fixup crypto patch

* chore: fixup crypto test patch

* src: prepare for v8 sandboxing

nodejs/node#58376

* esm: fix module.exports export on CJS modules

nodejs/node#57366

* chore: fixup lazyload fs patch

* esm: Source Phase Imports for WebAssembly

nodejs/node#56919

* module: remove --experimental-default-type

nodejs/node#56092

* lib,src: refactor assert to load error source from memory

nodejs/node#59751

* src: add source location to v8::TaskRunner

nodejs/node#54077

* src: remove dependency on wrapper-descriptor-based CppHeap

nodejs/node#54077

* src: do not use soon-to-be-deprecated V8 API

nodejs/node#53174

* src: stop using deprecated fields of v8::FastApiCallbackOptions

nodejs/node#54077

* test: update v8-stats test for V8 12.6

nodejs/node#54077

* esm: unflag --experimental-wasm-modules

nodejs/node#57038

* test: adapt assert tests to stack trace changes

nodejs/node#58070

* src,test: unregister the isolate after disposal and before freeing

nodejs/node#58070

* src: use cppgc to manage ContextifyContext

nodejs/node#56522

* src: replace uses of FastApiTypedArray

nodejs/node#58070

* module: integrate TypeScript into compile cache

nodejs/node#56629

* deps: update ada to 3.2.7

nodejs/node#59336

* src: make minor cleanups in encoding_binding.cc

nodejs/node#57448

* src: switch from `Get/SetPrototype` to `Get/SetPrototypeV2`

nodejs/node#55453

* src: use non-deprecated Get/SetPrototype methods

nodejs/node#59671

* src: simplify string_bytes with views

nodejs/node#54876

* src: improve utf8 string generation performance

nodejs/node#54873

* src: use non-deprecated Utf8LengthV2() method

nodejs/node#58070

* src: use non-deprecated WriteUtf8V2() method

nodejs/node#58070

* src: refactor WriteUCS2 and remove flags argument

nodejs/node#58163

* src: use String::WriteV2() in TwoByteValue

nodejs/node#58164

* node-api: use WriteV2 in napi_get_value_string_utf16

nodejs/node#58165

* node-api: use WriteOneByteV2 in napi_get_value_string_latin1

nodejs/node#58325

* src: migrate WriteOneByte to WriteOneByteV2

nodejs/node#59634

* fs: introduce dirent\.parentPath

nodejs/node#50976

* src: avoid copy by using std::views::keys

nodejs/node#56080

* chore: fixup patch indices

* fix: errant use of context->GetIsolate()

* fix: tweak BoringSSL compat patch for new changes

* fix: add back missing isolate dtor declaration

* fixup! esm: fix module.exports export on CJS modules

* cli: remove --no-experimental-fetch flag

https://github.com/nodejs/node/pull/52611/files

* esm: Source Phase Imports for WebAssembly

nodejs/node#56919

* fixup! src: prepare for v8 sandboxing

* chore: bump @types/node to v24

* chore: fix const assignment in crypto test

* fix: sandbox pointer patch issues

* chore: rework source phase import patch

* src: add percentage support to --max-old-space-size

nodejs/node#59082

* chore: fixup crypto tests

* chore: HostImportModuleWithPhaseDynamically todo

* fix: cjs esm failures

* fix: v8::Object::Wrappable issues

- v8/node@b72a615
- v8/node@490bac2
- v8/node@4896a0d

* chore: remove deleted specs

* src: use v8::ExternalMemoryAccounter

nodejs/node#58070

* fs: port SonicBoom module to fs module as FastUtf8Stream

nodejs/node#58897

* chore: tweak sandboxed pr patch

* test: disable parallel/test-os-checked-function

* test: use WHATWG URL instead of url.parse

* fix: OPENSSL_secure_zalloc doesn't work in BoringSSL

* chore: fix accidental extra line

* 7017517: [defer-import-eval] Parse import defer syntax

https://chromium-review.googlesource.com/c/v8/v8/+/7017517

trop Bot added a commit to electron/electron that referenced this pull request

Oct 30, 2025


          src: add percentage support to --max-old-space-size

0348dd2

nodejs/node#59082

Co-authored-by: Shelley Vohr <[email protected]>

ckerr pushed a commit to electron/electron that referenced this pull request

Oct 31, 2025


          chore: bump node to v22.21.1 (37-x-y) (#48614)

8647ef3

* chore: bump node in DEPS to v22.21.0

* chore: bump node in DEPS to v22.21.1

* chore: update patches

* lib,src: refactor assert to load error source from memory

nodejs/node#59751

* src: add percentage support to --max-old-space-size

nodejs/node#59082

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>

evrial commented Dec 3, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Is that difficult to come up with a better name? v8-gc-memlimit-percentage?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung commented Dec 4, 2025

Copy link

Copy Markdown

Member

Please be respectful in this issue tracker. Whether a name is better or not is subjective, and there's no supporting evidence that the suggested name is universally accepted as being better.

(Also, yes, naming things is one of the hardest problems in computer science).

Asaf-Federman reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AlCalzone mentioned this pull request

May 13, 2026

Consider further Node.js version bumps zwave-js/zwave-js#8820

Closed

Reviewers

jasnell

jasnell approved these changes

daeyeon

daeyeon approved these changes

MoLow

MoLow approved these changes

legendecas

legendecas approved these changes

theanarkh

theanarkh approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

backport-open-v22.x

Indicate that the PR has an open backport

c++

Issues and PRs that require attention from people who are familiar with C++.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

lib / src

Issues and PRs involving general changes in the lib/ or src/ directories.

needs-ci

PRs that need a full CI run.

semver-minor

PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

Asaf-Federman commented Jul 16, 2025

Uh oh!

nodejs-github-bot commented Jul 16, 2025

Uh oh!

legendecas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Asaf-Federman commented Jul 16, 2025

Uh oh!

legendecas commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Asaf-Federman commented Jul 16, 2025

Uh oh!

jasnell commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Asaf-Federman Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

jasnell Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

MoLow Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Asaf-Federman commented Jul 18, 2025

Uh oh!

staskorz commented Jul 20, 2025

Uh oh!

codecov Bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Asaf-Federman commented Jul 23, 2025

Uh oh!

Uh oh!

evrial commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Dec 4, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

legendecas left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

legendecas commented Jul 16, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

jasnell commented Jul 18, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Jul 21, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

evrial commented Dec 3, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.