GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: add perfetto sdk by legendecas · Pull Request #62397 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Mar 22, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This adds Perfetto SDK as a dependency of Node.js. Notably, this does not add the full Perfetto library as the dependency. The full perfetto library contains Perfetto data pipeline processing support. The Perfetto SDK only supports emitting tracing data.

This is part of the nodejs/diagnostics#654 discussion that V8 moves away from the legacy tracing library.

Key points:

  • The Perfetto support in Node.js would only support binary protobuf data emission.
  • The support does not emit JSON trace data (as the perfetto library uses libjsoncpp to translate protobuf data to JSON at runtime. The Perfetto library does not emit JSON directly)
  • Smaller dependency and produced library size.

This PR only adds the Perfetto SDK. The actual adoption is blocked on #61898 with patches in https://issues.chromium.org/issues/457135433.

Commit efdce9a can be fully reproduced with tools/dep_updaters/update-perfetto.sh.

Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell and TheOneTheOnlyJJ reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
legendecas added 3 commits March 22, 2026 14:57
@legendecas
deps: add perfetto build files
31d9833
@legendecas
tools: add perfetto updater
52ed2f7
@legendecas
deps: update perfetto to 54.0
efdce9a
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 22, 2026
jasnell
jasnell approved these changes Mar 22, 2026
View reviewed changes
anonrig
anonrig approved these changes Mar 22, 2026
View reviewed changes
@legendecas legendecas added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Mar 22, 2026
mcollina
mcollina approved these changes Mar 23, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
RafaelGSS
RafaelGSS reviewed Mar 24, 2026
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing adding update-perfetto.sh to workflows/tools.yml and adding nodejs/diagnostics as codeowner of this updater.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@legendecas

legendecas commented Mar 24, 2026

Copy link
Copy Markdown
Member Author

@RafaelGSS I didn't add the workflow because there is no CI covering the build. I plan to add the workflow automate the update when V8 changes landed and with CI setup.
RafaelGSS reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Mar 26, 2026
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71950/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joyeecheung
joyeecheung approved these changes Mar 26, 2026
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72098/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72104/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72388/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 1, 2026
@avivkeller avivkeller added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 9, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 9, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/62397
✔  Done loading data for nodejs/node/pull/62397
----------------------------------- PR info ------------------------------------
Title      deps: add perfetto sdk (#62397)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     legendecas:perfetto-sdk -> nodejs:main
Labels     tools, author ready, needs-ci, dependencies, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x
Commits    3
 - deps: add perfetto build files
 - tools: add perfetto updater
 - deps: update perfetto to 54.0
Committers 1
 - Chengzhong Wu <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/62397
Refs: https://github.com/nodejs/diagnostics/issues/654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62397
Refs: https://github.com/nodejs/diagnostics/issues/654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 22 Mar 2026 19:09:05 GMT
   ✔  Approvals: 4
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-3988575643
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-3988649093
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-3990158875
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62397#pullrequestreview-4010914467
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-04-01T14:53:38Z: https://ci.nodejs.org/job/node-test-pull-request/72388/
- Querying data for job/node-test-pull-request/72388/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62397
From https://github.com/nodejs/node
 * branch                  refs/pull/62397/merge -> FETCH_HEAD
✔  Fetched commits as e6ef4774c202..efdce9a74e10
--------------------------------------------------------------------------------
[main 6304553d8c] deps: add perfetto build files
 Author: Chengzhong Wu <[email protected]>
 Date: Sun Mar 22 14:56:02 2026 -0400
 4 files changed, 59 insertions(+)
 create mode 100644 deps/perfetto/BUILD.gn
 create mode 100644 deps/perfetto/VERSION
 create mode 100644 deps/perfetto/perfetto.gyp
 create mode 100644 deps/perfetto/unofficial.gni
[main b3b488e6a1] tools: add perfetto updater
 Author: Chengzhong Wu <[email protected]>
 Date: Sun Mar 22 14:49:41 2026 -0400
 2 files changed, 82 insertions(+)
 create mode 100755 tools/dep_updaters/update-perfetto.sh
[main 4b09ab3281] deps: update perfetto to 54.0
 Author: Chengzhong Wu <[email protected]>
 Date: Sun Mar 22 14:56:37 2026 -0400
 4 files changed, 279764 insertions(+), 1 deletion(-)
 create mode 100644 deps/perfetto/LICENSE
 create mode 100644 deps/perfetto/sdk/perfetto.cc
 create mode 100644 deps/perfetto/sdk/perfetto.h
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
(node:997) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps: add perfetto build files

PR-URL: #62397

Refs: nodejs/diagnostics#654

Refs: https://issues.chromium.org/issues/457135433

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Joyee Cheung <[email protected]>


[detached HEAD 836681b7ae] deps: add perfetto build files

Author: Chengzhong Wu <[email protected]>

Date: Sun Mar 22 14:56:02 2026 -0400

4 files changed, 59 insertions(+)

create mode 100644 deps/perfetto/BUILD.gn

create mode 100644 deps/perfetto/VERSION

create mode 100644 deps/perfetto/perfetto.gyp

create mode 100644 deps/perfetto/unofficial.gni

Rebasing (3/6)

Rebasing (4/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: add perfetto updater


PR-URL: #62397

Refs: nodejs/diagnostics#654

Refs: https://issues.chromium.org/issues/457135433

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Joyee Cheung <[email protected]>


[detached HEAD b21cb03738] tools: add perfetto updater

Author: Chengzhong Wu <[email protected]>

Date: Sun Mar 22 14:49:41 2026 -0400

2 files changed, 82 insertions(+)

create mode 100755 tools/dep_updaters/update-perfetto.sh

Rebasing (5/6)

Rebasing (6/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update perfetto to 54.0


PR-URL: #62397

Refs: nodejs/diagnostics#654

Refs: https://issues.chromium.org/issues/457135433

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Joyee Cheung <[email protected]>


[detached HEAD 7245547f8e] deps: update perfetto to 54.0

Author: Chengzhong Wu <[email protected]>

Date: Sun Mar 22 14:56:37 2026 -0400

4 files changed, 279764 insertions(+), 1 deletion(-)

create mode 100644 deps/perfetto/LICENSE

create mode 100644 deps/perfetto/sdk/perfetto.cc

create mode 100644 deps/perfetto/sdk/perfetto.h

Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/24207909791
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Apr 9, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 9, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Landed in f01f79e...f1ed8d6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nodejs-github-bot pushed a commit that referenced this pull request Apr 9, 2026
@legendecas @nodejs-github-bot
deps: add perfetto build files
ec45b95 
PR-URL: #62397
Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Apr 9, 2026
@legendecas @nodejs-github-bot
tools: add perfetto updater
ac618fc 
PR-URL: #62397
Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Apr 9, 2026
@legendecas @nodejs-github-bot
deps: update perfetto to 54.0
f1ed8d6 
PR-URL: #62397
Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@nodejs-github-bot nodejs-github-bot closed this Apr 9, 2026
@legendecas
legendecas deleted the perfetto-sdk branch April 9, 2026 21:54
aduh95 pushed a commit that referenced this pull request May 5, 2026
@legendecas @aduh95
deps: add perfetto build files
944ed9b 
PR-URL: #62397
Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
aduh95 pushed a commit that referenced this pull request May 5, 2026
@legendecas @aduh95
tools: add perfetto updater
1587a60 
PR-URL: #62397
Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
aduh95 pushed a commit that referenced this pull request May 5, 2026
@legendecas @aduh95
deps: update perfetto to 54.0
2f3eca8 
PR-URL: #62397
Refs: nodejs/diagnostics#654
Refs: https://issues.chromium.org/issues/457135433
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@aduh95 aduh95 mentioned this pull request May 5, 2026
2026-05-07, Version 26.1.0 #63137
Merged
@aduh95 aduh95 mentioned this pull request Aug 18, 2026
perfetto: init at 58.2 NixOS/nixpkgs#553888
Merged
5 of 13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSS RafaelGSS RafaelGSS left review comments
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dependencies PRs that add, update, or configure Node.js dependencies. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@legendecas @nodejs-github-bot @mcollina @jasnell @anonrig @joyeecheung @RafaelGSS @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.