GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reland AIX V8 fixes for clang by richardlau · Pull Request #62894 · nodejs/node

Conversation

@richardlau

@richardlau richardlau commented Apr 22, 2026

Copy link
Copy Markdown
Member

The V8 cherry-pick in #62656 contains a typo that is breaking our V8 CI (and instead of && in the conditional). Also the commit message title refers to the chromium-review reference and not the commit sha that the change landed as.

Revert the V8 cherry-pick from https://github.com/nodejs/node/pull/62656/commits and re-cherry-pick.

The correct change is already in #61898, so this is only necessary to fix V8 CI runs on current main and some open PRs that touch V8 (which is where I spotted the failures):
https://github.com/nodejs/node/blob/d065ae8be1a4d2592ec7f5c6d357c7b2f3d6cf77/deps/v8/BUILD.gn#L1630

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
richardlau and others added 2 commits April 22, 2026 14:19
@richardlau
Revert "deps: V8: cherry-pick 7107287"
014c3bd 
This reverts commit 142b593.
@abmusse @richardlau
deps: V8: cherry-pick fcf8b990c73c
5d7272d 
Original commit message:

    aix: add required changes to build with clang

    Change-Id: Icc78c58831306aa2f227843b0b4ec2321585fa64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107287
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#104364}

Refs: v8/v8@fcf8b99
@richardlau richardlau added aix Issues and PRs related to the AIX platform. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Apr 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2026
Renegade334
Renegade334 approved these changes Apr 22, 2026
View reviewed changes

@Renegade334 Renegade334 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Renegade334 Renegade334 added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 22, 2026
@github-actions

github-actions Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Renegade334. Please 👍 to approve.
abmusse, IlyasShabi, and panva reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 22, 2026
abmusse
abmusse approved these changes Apr 22, 2026
View reviewed changes

@abmusse abmusse left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this up!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72863/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7139/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7139/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7139/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva
panva approved these changes Apr 22, 2026
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72865/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72869/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72871/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72873/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 22, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in 9531947...acb1bd7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2026
@richardlau @nodejs-github-bot
Revert "deps: V8: cherry-pick 7107287"
c028766 
This reverts commit 142b593.

PR-URL: #62894
Reviewed-By: René <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Apr 22, 2026
@abmusse @nodejs-github-bot
deps: V8: cherry-pick fcf8b990c73c
acb1bd7 
Original commit message:

    aix: add required changes to build with clang

    Change-Id: Icc78c58831306aa2f227843b0b4ec2321585fa64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107287
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#104364}

Refs: v8/v8@fcf8b99
PR-URL: #62894
Reviewed-By: René <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
@nodejs-github-bot nodejs-github-bot closed this Apr 22, 2026
@richardlau richardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Apr 23, 2026
@richardlau richardlau added dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels Apr 23, 2026
@richardlau richardlau mentioned this pull request Apr 27, 2026
2026-05-05, Version 26.0.0 (Current) #62526
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 27, 2026
@richardlau @RafaelGSS
Revert "deps: V8: cherry-pick 7107287"
6ad154c 
This reverts commit 142b593.

PR-URL: #62894
Reviewed-By: René <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
(cherry picked from commit c028766)
RafaelGSS pushed a commit that referenced this pull request Apr 27, 2026
@abmusse @RafaelGSS
deps: V8: cherry-pick fcf8b990c73c
9c40dc8 
Original commit message:

    aix: add required changes to build with clang

    Change-Id: Icc78c58831306aa2f227843b0b4ec2321585fa64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107287
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#104364}

Refs: v8/v8@fcf8b99
PR-URL: #62894
Reviewed-By: René <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
(cherry picked from commit acb1bd7)
@richardlau richardlau mentioned this pull request Apr 27, 2026
deps: V8: cherry-pick 0f024d4e66e0 #62408
Closed
RafaelGSS pushed a commit that referenced this pull request Apr 28, 2026
@richardlau @RafaelGSS
Revert "deps: V8: cherry-pick 7107287"
b7fab70 
This reverts commit 142b593.

PR-URL: #62894
Reviewed-By: René <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
(cherry picked from commit c028766)
RafaelGSS pushed a commit that referenced this pull request Apr 28, 2026
@abmusse @RafaelGSS
deps: V8: cherry-pick fcf8b990c73c
ce0f498 
Original commit message:

    aix: add required changes to build with clang

    Change-Id: Icc78c58831306aa2f227843b0b4ec2321585fa64
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7107287
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#104364}

Refs: v8/v8@fcf8b99
PR-URL: #62894
Reviewed-By: René <[email protected]>
Reviewed-By: Abdirahim Musse <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
(cherry picked from commit acb1bd7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes
@abmusse abmusse abmusse approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@richardlau @nodejs-github-bot @panva @Renegade334 @abmusse
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.