GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: backport IsValid changes from 4e8736d in V8 by targos · Pull Request #6544 · nodejs/node

Conversation

@targos

@targos targos commented May 3, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Description of change

V8 erroneously did null pointer checks on this.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from 1 that fix this issue.

Fixes: #6272

cc @nodejs/v8

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label May 3, 2016
@bnoordhuis

bnoordhuis commented May 3, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 3, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/2475/

Do we have a CI job to run V8 tests ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jeisinger

jeisinger commented May 3, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented May 3, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@targos ... yes... https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/
But it is limited a bit still
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 3, 2016

Copy link
Copy Markdown
Member Author

V8 tests run: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/75/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny

indutny commented May 3, 2016

Copy link
Copy Markdown
Member

Rubber-stamp LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added the lts-watch-v4.x label May 4, 2016
@targos

targos commented May 4, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Labelling lts-watch-v4.x. I have the backport ready in my fork if necessary. There are other occurrences of this != NULL in the V8 version we have in v4.x, though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
deps: backport IsValid changes from 4e8736d in V8
96198d5 
V8 erroneously did null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from [1] that fix this issue.

[1]: https://codereview.chromium.org/1900423002

Fixes: nodejs#6272
PR-URL: nodejs#6544
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@targos
targos force-pushed the fix2-6272 branch from 8afb065 to 96198d5 Compare May 4, 2016 08:20
@targos
targos merged commit 96198d5 into nodejs:master May 4, 2016
@targos
targos deleted the fix2-6272 branch May 4, 2016 08:23
@bnoordhuis

bnoordhuis commented May 4, 2016

Copy link
Copy Markdown
Member

There are other occurrences of this != NULL in the V8 version we have in v4.x

Interesting. The compiler is only allowed to elide the first check and I don't think the initial FrameStateDescriptor can be NULL, going by the code in deps/v8/src/compiler.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 4, 2016

Copy link
Copy Markdown
Member Author

I don't think the initial FrameStateDescriptor can be NULL, going by the code in deps/v8/src/compiler.

It apparently can. At least one of our tests crashes at FrameStateDescriptor::GetTotalSize()
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented May 4, 2016

Copy link
Copy Markdown
Member

Oh, okay. I'll review your changes if you're willing to work on it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
@targos @joelostrowski
deps: backport IsValid changes from 4e8736d in V8
739327f 
V8 erroneously did null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from [1] that fix this issue.

[1]: https://codereview.chromium.org/1900423002

Fixes: nodejs#6272
PR-URL: nodejs#6544
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 4, 2016
@targos @Fishrock123
deps: backport IsValid changes from 4e8736d in V8
65b6574 
V8 erroneously did null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from [1] that fix this issue.

[1]: https://codereview.chromium.org/1900423002

Fixes: nodejs#6272
PR-URL: nodejs#6544
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request May 4, 2016
Propose v6.1.0 (Openssl update) #6557
Merged
@targos targos mentioned this pull request May 10, 2016
deps: backport IsValid changes from 4e8736d in V8 (v4.x) #6669
Closed
2 tasks done
@MylesBorins MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels May 18, 2016
targos added a commit to targos/node that referenced this pull request Jun 3, 2016
@targos
deps: backport IsValid changes from 4e8736d in V8
1608559 
V8 erroneously did null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from [1] that fix this issue.

[1]: https://codereview.chromium.org/1900423002

Fixes: nodejs#6272
PR-URL: nodejs#6544
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
targos added a commit to targos/node that referenced this pull request Jun 29, 2016
@targos
deps: backport IsValid changes from 4e8736d in V8
6dfa533 
V8 erroneously did null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from [1] that fix this issue.

[1]: https://codereview.chromium.org/1900423002

Fixes: nodejs#6272
PR-URL: nodejs#6544
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
ofrobots pushed a commit to ofrobots/node that referenced this pull request Aug 25, 2016
@targos @ofrobots
deps: backport IsValid changes from 4e8736d in V8
a91f6b8 
V8 erroneously did null pointer checks on `this`.
It can lead to a SIGSEGV crash if node is compiled with GCC 6.
Backport relevant changes from [1] that fix this issue.

[1]: https://codereview.chromium.org/1900423002

Fixes: nodejs#6272
PR-URL: nodejs#6544
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 26, 2016
2016-08-26, Version 6.5.0 (Current) #8253
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v6 has buffer issues on Fedora 24

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @bnoordhuis @jeisinger @jasnell @indutny @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.