GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 2016-08-26, Version 6.5.0 (Current) by evanlucas · Pull Request #8253 · nodejs/node

Conversation

@evanlucas

@evanlucas evanlucas commented Aug 24, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

2016-08-26, Version 6.5.0 (Current), @evanlucas

Notable changes

  • buffer: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154
  • deps: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054
  • inspector:
    • fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021
    • add support for uncaught exception (Aleksei Koziatinskii) #8043
  • repl: Fix saving editor mode text in .save (Prince J Wesley) #8145
  • _Revert_ "repl,util: insert carriage returns in output" (Evan Lucas) #8143

Commits

  • [5bc311909f] - assert: remove code that is never reached (Rich Trott) #8132
  • [e371545dfe] - buffer: allow .write() offset to be at buffer end (Anna Henningsen) #8154
  • [dcd065522e] - (SEMVER-MINOR) build: don't include V8 from node.gyp (Michaël Zasso) #7016
  • [92ecbc4edc] - build: cherry pick V8 change for windows DLL support (Stefan Budeanu) #8084
  • [4e4c091542] - build: windows sharedlib support (Stefan Budeanu) #8084
  • [f4c3456610] - build: do not lint src dir for JS errors (Rich Trott) #8128
  • [71343b6caa] - child_process: reuse existing no-op function (cjihrig) #8164
  • [0884c70535] - child_process: workaround fd passing issue on OS X (Santiago Gimeno) #7572
  • [8eb6e71758] - configure: reword help for --without-npm (BlackYoup) #7471
  • [c406ad8258] - debugger: use arrow function for lexical this (Guy Fraser) #7415
  • [723fa9637c] - deps: cherry-pick de5aaad from V8's upstream (Michaël Zasso) #8099
  • [fc2a89ccb7] - deps: V8: cherry-pick 588e15c, c0d4bb8 (epertoso) #8038
  • [cd77ca397a] - deps: cherry-pick 6f68f30 from v8 upstream (Stefan Budeanu) #7802
  • [b4f11efafa] - deps: cherry-pick a51f429 from V8 upstream (Franziska Hinkelmann) #7833
  • [4a20869714] - deps: cherry-pick a76d133 from v8 upstream (Matt Loring) #7689
  • [3b2f692b23] - deps: cherry-pick b93c80a from v8 upstream (Matt Loring) #7689
  • [c4401d283b] - deps: cherry-pick 2b4c9c1 from v8 upstream (Joran Siu) #7771
  • [0ac21bc860] - deps: cherry-pick 1f53e42 from v8 upstream (Ben Noordhuis) #7612
  • [fc442e0f43] - deps: cherry-pick d721121 from v8 upstream (Ben Noordhuis) #7632
  • [9a4b338f0c] - deps: remove extra field from v8::HeapStatistics (Anna Henningsen) #7526
  • [2c46e23969] - (SEMVER-MINOR) deps: bring in V8 5.1 - 5.0 ABI compatibility (Matt Loring) #7016
  • [06a6c03e57] - (SEMVER-MINOR) deps: revert removal of V8::PromiseEvent (Matt Loring) #7016
  • [a91f6b8433] - deps: backport IsValid changes from 4e8736d in V8 (Michaël Zasso) #6544
  • [b2f7c32a9f] - deps: cherry-pick 1ef7487b from v8 upstream (Michael Dawson) #6218
  • [7af2f63f10] - deps: limit regress/regress-crbug-514081 v8 test (Michael Dawson) #6678
  • [abbad66126] - (SEMVER-MINOR) deps: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054
  • [08e2b0408a] - deps: cherry-pick 7bd24767 from v8 upstream (v6.x) (Franziska Hinkelmann) #8078
  • [d0cb52b967] - dns: remove makeAsync() function check (cjihrig) #8170
  • [70648f47ca] - dns: lookupService() callback must be a function (cjihrig) #8170
  • [d9142b4bd6] - doc: add added: information for util (Luigi Pinca) #8206
  • [c2f5471f6d] - doc: remove "feature branch" jargon (Rich Trott) #8194
  • [7f34cc3e03] - doc: correct argument type for process.cpuUsage (Simen Bekkhus) #8158
  • [0c9960b3c5] - doc: remove outdated LTS info from ROADMAP.md (Rich Trott) #8161
  • [afbe4d8ebd] - doc: add es6 code example in util.md (Shahid Shaikh) #8183
  • [4a8aca7f94] - doc: script with spaces spawn example for windows (Bartosz Sosnowski) #8035
  • [82329b6e8f] - doc: fix variable scoping bug in server example code (lazlojuly) #8124
  • [d7ab1baed2] - doc: update release announce instruction to tweet (Tracy Hinds) #8126
  • [5d37b49f90] - doc: add @joshgav to collaborators (Josh Gavant) #8146
  • [31653a5006] - doc: update Reviewing section of onboarding doc (Rich Trott)
  • [bf5c5f3ce0] - doc: fix "hashOwnProperty" typo in querystring (Ben Gourley) #8107
  • [b1922e7b5b] - dtrace: fix ustack helper for V8 5.1 (Ali Ijaz Sheikh) #6482
  • [92de0bc1a6] - inspector: fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021
  • [bfd8265ec2] - inspector: add support for uncaught exception (Aleksei Koziatinskii) #8043
  • [089a1cbecb] - net: add length check when normalizing args (Brian White) #8112
  • [17b8381585] - net: remove unnecessary variables (Brian White) #8112
  • [fbc5805e65] - readline: keypress trigger for escape character (Prince J Wesley) #7382
  • [66e66e59a4] - (SEMVER-MINOR) repl: fix repl after V8 upgrade (Ali Ijaz Sheikh) #7016
  • [60c50468e3] - repl: Failed to save editor mode text in .save (Prince J Wesley) #8145
  • [ffb2db8285] - _Revert_ "repl,util: insert carriage returns in output" (Evan Lucas) #8143
  • [4118598dbb] - src: don't include a null character in the WriteConsoleW call (Nikolai Vavilov) #7764
  • [d863619a30] - src: clean up PER_ISOLATE_STRING_PROPERTIES, v2 (Ben Noordhuis) #8207
  • [d3950a2013] - src: clean up PER_ISOLATE_STRING_PROPERTIES, v1 (Ben Noordhuis) #8207
  • [8f9fb8154d] - src: updating references to the old node.js file (Daniel Bevenius) #8092
  • [091ba2c511] - src: fix build break for !NODE_USE_V8_PLATFORM (Kunal Pathak) #8114
  • [1bf80a0a3f] - stream: avoid caching prepend check (Calvin Metcalf) #8018
  • [cda8bfc3c8] - test: fix tests after V8 upgrade (Ali Ijaz Sheikh) #6482
  • [441e8fe566] - test: refactor test-timers-linked-list.js (Rich Trott) #8193
  • [bb6d6a677c] - test: fix flaky test-child-process-pass-fd (Santiago Gimeno) #8212
  • [b0619e8dff] - test: comparison operator now more strict (Jason Hedrick) #8190
  • [923a61774d] - test: refactor test-tick-processor (Rich Trott) #8180
  • [b9b762f308] - test: add test for invalid cert string (Rich Trott) #8179
  • [a6f83797df] - test: add assert.notDeepStrictEqual() tests (Rich Trott) #8177
  • [29a71965c0] - test: favor === over == in crypto tests (Rich Trott) #8176
  • [c568dfad39] - test: refactor pummel/test-dtrace-jsstack (Rich Trott) #8175
  • [cfbafd7c7d] - test: favor strict equality in test-exec (Rich Trott) #8173
  • [b8f5a2b789] - test: favor === over == in vm test (jun-oka) #8191
  • [498238f462] - test: test sending over a closed IPC channel (cjihrig) #8160
  • [15bd48986b] - test: add test for attempted multiple IPC channels (cjihrig) #8159
  • [4deb05434f] - test: add assert.notDeepEqual() tests (Rich Trott) #8156
  • [3d0cf9e4f1] - test: add missing assert.deepEqual() test case (Rich Trott) #8152
  • [6abbe17ab2] - test: favor strict equality in http tests (Rich Trott) #8151
  • [cc9bb34120] - test: favor strict equality in pummel net tests (Rich Trott) #8135
  • [4b6ed24f02] - test: confirm that assert truncates long values (Rich Trott) #8134
  • [e5a8790727] - test: favor === over == in test-timers.js (Rich Trott) #8131
  • [086e57f404] - test: favor strict equality check (Rich Trott) #8130
  • [9a393a7ff4] - test: fix assertion in test-watch-file.js (Rich Trott) #8129
  • [4f09886dce] - test: fix flaky fs-watch tests (Santiago Gimeno) #8115
  • [d401e5575a] - test: add an zlib binding addon test (Anna Henningsen) #8039
  • [6bdc0e54b4] - test: use strict equality in regression test (Rich Trott) #8098
  • [be41f584f3] - test: remove extraneous space (Rich Trott) #8097
  • [853f605de4] - test: add test for assert.notStrictEqual() (Rich Trott) #8091
  • [f4698f3568] - test: add uncaught exception test for debugger (Rich Trott) #8087
  • [c26b9af1e2] - tls: copy the Buffer object before using (Sakthipriyan Vairamani) #8055
  • [cdcf23ab7f] - tools: update ESLint to 3.3.0 and enable rules (Rich Trott) #8097
  • [14c7dcbbcd] - url: fix inconsistent port in url.resolveObject (Ilkka Myller) #8214
  • [1f9fbade4c] - util: fix deprecated class prototype (Bryan English) #8105
  • [44f781d06a] - v8: warn in Template::Set() on improper use (Ben Noordhuis) #6277
  • [a146e683dd] - win,msi: add zh-CN translations for the installer (Minqi Pan) #2569

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JLHwung reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 24, 2016
@evanlucas

evanlucas commented Aug 24, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3820/
CITGM: https://ci.nodejs.org/view/All/job/citgm-smoker/369/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123

Fishrock123 commented Aug 24, 2016

Copy link
Copy Markdown
Contributor

meta: add Josh Gavant to collaborators (Josh Gavant) #8146

Probably not so relevant to the people consuming the release notes. :)

I think we should just keep those in the commits.
joshgav reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123

Fishrock123 commented Aug 24, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

win,msi: add zh-CN translations for the installer (Minqi Pan) #2569

Isn't this like the third time this has shown up...? I'm confused.

Edit: It says a146e683dd is already on v6.x

Did you use changelog-maker or branch-diff to get this list?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex mscdex added the v6.x label Aug 24, 2016
@Fishrock123

Fishrock123 commented Aug 25, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@evanlucas when do you plan on releasing this? (assuming you plan on doing it)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas

evanlucas commented Aug 25, 2016

Copy link
Copy Markdown
Contributor Author

Was planning on today but got tied up. Will get it done tomorrow
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas

evanlucas commented Aug 25, 2016

Copy link
Copy Markdown
Contributor Author

@Fishrock123 That commit showed up with both changelog-maker and branch-diff. I'll look more into it. I'll get the other comments fixed up as well
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Aug 25, 2016

Copy link
Copy Markdown
Member

@evanlucas it looks like #8054, which is marked semver-minor, has landed in v6.x.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas

evanlucas commented Aug 25, 2016

Copy link
Copy Markdown
Contributor Author

@richardlau yea I saw that thanks. I'll get this updated tonight with all of the changes that have landed on v6.x.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas
evanlucas force-pushed the v6.4.1-proposal branch from 99c9a6b to fc16dea Compare August 26, 2016 02:32
evanlucas added a commit that referenced this pull request Aug 26, 2016
@evanlucas
2016-08-26, Version 6.5.0 (Current)
fc16dea 
Notable changes:

* **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154
* **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054
* **inspector**:
  * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021
  * add support for uncaught exception (Aleksei Koziatinskii) #8043
* **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145
* ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143

PR-URL: #8253
@evanlucas evanlucas changed the title 2016-08-24, Version 6.4.1 (Current) 2016-08-26, Version 6.5.0 (Current) Aug 26, 2016
@evanlucas

evanlucas commented Aug 26, 2016

Copy link
Copy Markdown
Contributor Author

Ok, back up to date now.

CI: https://ci.nodejs.org/job/node-test-pull-request/3839/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/370/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas
2016-08-26, Version 6.5.0 (Current)
4c5315c 
Notable changes:

* **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154
* **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054
* **inspector**:
  * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021
  * add support for uncaught exception (Aleksei Koziatinskii) #8043
* **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145
* ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143

PR-URL: #8253
@evanlucas
evanlucas force-pushed the v6.4.1-proposal branch from fc16dea to 4c5315c Compare August 26, 2016 10:59
@evanlucas
Working on v6.5.1
862610f 
PR-URL: #8253
@MylesBorins

MylesBorins commented Aug 26, 2016

Copy link
Copy Markdown
Contributor

None of the failures on citgm look new to me

citgm of v6.3.1 for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/371/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Aug 26, 2016

Copy link
Copy Markdown
Contributor

failures are almost identical on 6.3.1

there was a failure for uglify, but it appears to be a timeout

/cc @phated for vinyl-fs failures
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arthurschreiber arthurschreiber mentioned this pull request Aug 26, 2016
NodeJS 6.4.0 Empty String Range Error tediousjs/tedious#431
Closed
@evanlucas

evanlucas commented Aug 26, 2016

Copy link
Copy Markdown
Contributor Author

ok, binaries were built, the two OS X machines built the same thing, so we didn't get a tarball with the binary, only the tarballs with the source. Trying again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Aug 26, 2016

Copy link
Copy Markdown
Contributor

ohhh that fun bug! /cc @nodejs/build

On Fri, Aug 26, 2016, 3:17 PM Evan Lucas [email protected] wrote:

ok, binaries were built, the two OS X machines built the same thing, so we
didn't get a tarball with the binary, only the tarballs with the source.
Trying again

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#8253 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV1WvH4hSyv44_p1izik3OxxeWbsxks5qjwODgaJpZM4JsCnL
.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas

evanlucas commented Aug 26, 2016

Copy link
Copy Markdown
Contributor Author

yay, that worked. Just waiting on the others now :]
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas
evanlucas merged commit 862610f into v6.x Aug 26, 2016
evanlucas added a commit that referenced this pull request Aug 26, 2016
@evanlucas
2016-08-26, Version 6.5.0 (Current)
0482d6d 
Notable changes:

* **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) #8154
* **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) #8054
* **inspector**:
  * fix inspector hang while disconnecting (Aleksei Koziatinskii) #8021
  * add support for uncaught exception (Aleksei Koziatinskii) #8043
* **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) #8145
* ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) #8143

PR-URL: #8253
@addaleax addaleax mentioned this pull request Aug 27, 2016
fs: refactor "options" processing as a function #7165
Closed
2 tasks done
@addaleax

addaleax commented Aug 27, 2016

Copy link
Copy Markdown
Member

(what’s the status of this? released?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Aug 27, 2016

Copy link
Copy Markdown
Member

Not yet... it was tagged on Friday but @evanlucas did not have ready access to the key to promote, so, from what I understand, he'll be promoting on Monday.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Aug 27, 2016

Copy link
Copy Markdown
Member

@jasnell Thanks for explaining :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas

evanlucas commented Aug 27, 2016

Copy link
Copy Markdown
Contributor Author

@addaleax @jasnell is correct. Sorry!!!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Aug 27, 2016

Copy link
Copy Markdown
Member

@evanlucas no need to apologize! I was just a bit confused by not seeing any release out there :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Aug 27, 2016

Copy link
Copy Markdown
Contributor

he'll be promoting on Monday.

I was told not to release on Mondays. While I think that Monday releases are fine, I just wanted to point it out.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas
evanlucas deleted the v6.4.1-proposal branch August 29, 2016 14:04
@evanlucas

evanlucas commented Aug 29, 2016

Copy link
Copy Markdown
Contributor Author

The binaries have been promoted (https://nodejs.org/dist/v6.5.0/). I sincerely apologize for the mess up on my part with this one. Won't happen again :]. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mathiasbynens added a commit to tibiamaps/tibia-map-data that referenced this pull request Aug 29, 2016
@mathiasbynens
Fix CI builds
2036599 
In Node.js v6.4.0, writing an empty string out of the buffer bounds throws an exception. This will be fixed in Node.js v6.5.0 but for now we’re going to have to stick to v6.3.1, which doesn’t have this issue.

nodejs/node#8127
nodejs/node#8253
richardlau
richardlau reviewed Aug 30, 2016
View reviewed changes
Comment thread doc/changelogs/CHANGELOG_V6.md
### Notable changes

* **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) [#8154](https://github.com/nodejs/node/pull/8154)
* **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) [#8054](https://github.com/nodejs/node/pull/8054)

@richardlau richardlau Aug 30, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like v6.5.0 actually ended up with V8 5.1.281.81.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins MylesBorins added dont-land-on-v4.x and removed dont-land-on-v4.x labels Sep 9, 2016
@gmcdowell gmcdowell mentioned this pull request Sep 15, 2016
Support for Node 6?? ldapjs/node-ldapjs#372
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@evanlucas @Fishrock123 @richardlau @MylesBorins @addaleax @jasnell @cjihrig @mscdex @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.