GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: favor strict equality check by Trott · Pull Request #8130 · nodejs/node

Conversation

@Trott

@Trott Trott commented Aug 16, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test tls

Description of change

Change use of != in assertion to assert.notStrictEqual() check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: favor strict equality check
e42d90d 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.
@Trott Trott added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 16, 2016
@addaleax

addaleax commented Aug 16, 2016

Copy link
Copy Markdown
Member

LGTM, CI: https://ci.nodejs.org/job/node-test-commit/4609/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Aug 17, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@jasnell

jasnell commented Aug 17, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit to Trott/io.js that referenced this pull request Aug 18, 2016
@Trott
test: favor strict equality check
7652ae9 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: nodejs#8130
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott

Trott commented Aug 18, 2016

Copy link
Copy Markdown
Member Author

Landed in 7652ae9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Aug 18, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: favor strict equality check
086e57f 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
2016-08-26, Version 6.5.0 (Current) #8253
Merged
@Trott Trott added the lts-watch-v4.x label Sep 9, 2016
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott Myles Borins
test: favor strict equality check
a194574 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Oct 10, 2016
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: favor strict equality check
345e272 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: favor strict equality check
af02d2a 
Change use of `!=` in assertion to `assert.notStrictEqual()` check.

PR-URL: #8130
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
V4.6.2 proposal #9298
Closed
@Trott
Trott deleted the memleak branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

test Issues and PRs related to Node.js core tests and test infrastructure. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @addaleax @targos @jasnell @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.