GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — child_process: reuse existing no-op function by cjihrig · Pull Request #8164 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Aug 18, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

child_process

Description of change

The internal/child_process module has an existing no-op function. This commit utilizes that function, instead of creating extraneous closures.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Aug 18, 2016
@jasnell

jasnell commented Aug 18, 2016

Copy link
Copy Markdown
Member

+1 LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@claudiorodriguez

claudiorodriguez commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@santigimeno

santigimeno commented Aug 18, 2016

Copy link
Copy Markdown
Member

LGTM.
CI: https://ci.nodejs.org/job/node-test-pull-request/3734/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig
child_process: reuse existing no-op function
ccbb3c7 
The internal/child_process module has an existing no-op
function. This commit utilizes that function, instead of
creating extraneous closures.

PR-URL: nodejs#8164
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@cjihrig
cjihrig force-pushed the nop branch from c49ab27 to ccbb3c7 Compare August 20, 2016 20:26
@cjihrig
cjihrig merged commit ccbb3c7 into nodejs:master Aug 20, 2016
@cjihrig
cjihrig deleted the nop branch August 20, 2016 20:27
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@cjihrig @evanlucas
child_process: reuse existing no-op function
71343b6 
The internal/child_process module has an existing no-op
function. This commit utilizes that function, instead of
creating extraneous closures.

PR-URL: #8164
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Claudio Rodriguez <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
2016-08-26, Version 6.5.0 (Current) #8253
Merged
@MylesBorins MylesBorins added the dont-land-on-v4.x label Sep 30, 2016
@MylesBorins

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

not landing cleanly, please feel free to manually backport
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@cjihrig @jasnell @claudiorodriguez @santigimeno @MylesBorins @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.