GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: refactor pummel/test-dtrace-jsstack by Trott · Pull Request #8175 · nodejs/node

Conversation

@Trott

@Trott Trott commented Aug 18, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • os.type() check -> common.isSunOS
  • != -> !==
  • == -> ===

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
test: refactor pummel/test-dtrace-jsstack
13acfd9 
* `os.type()` check -> `common.isSunOS`
* != -> !==
* == -> ===
@Trott Trott added test Issues and PRs related to Node.js core tests and test infrastructure. smartos Issues and PRs related to the SmartOS platform. labels Aug 18, 2016
@jasnell

jasnell commented Aug 18, 2016

Copy link
Copy Markdown
Member

LGTM if CI is green
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Aug 18, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Aug 22, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3781/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit to Trott/io.js that referenced this pull request Aug 22, 2016
@Trott
test: refactor pummel/test-dtrace-jsstack
25703dc 
* `os.type()` check -> `common.isSunOS`
* != -> !==
* == -> ===

PR-URL: nodejs#8175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott

Trott commented Aug 22, 2016

Copy link
Copy Markdown
Member Author

Landed in 25703dc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Aug 22, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: refactor pummel/test-dtrace-jsstack
c568dfa 
* `os.type()` check -> `common.isSunOS`
* != -> !==
* == -> ===

PR-URL: #8175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
2016-08-26, Version 6.5.0 (Current) #8253
Merged
@Trott Trott added the lts-watch-v4.x label Sep 9, 2016
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott Myles Borins
test: refactor pummel/test-dtrace-jsstack
451b5f9 
* `os.type()` check -> `common.isSunOS`
* != -> !==
* == -> ===

PR-URL: #8175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Oct 10, 2016
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: refactor pummel/test-dtrace-jsstack
d0dcee2 
* `os.type()` check -> `common.isSunOS`
* != -> !==
* == -> ===

PR-URL: #8175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: refactor pummel/test-dtrace-jsstack
11f761a 
* `os.type()` check -> `common.isSunOS`
* != -> !==
* == -> ===

PR-URL: #8175
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
V4.6.2 proposal #9298
Closed
@Trott
Trott deleted the dtrace-jsstack branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Trott @jasnell @cjihrig @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.