GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add `added:` information for util by lpinca · Pull Request #8206 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Aug 21, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to Node.js documentation. labels Aug 21, 2016
@lpinca
lpinca force-pushed the add/added-util branch from f3dd011 to e655efc Compare August 21, 2016 09:14
lpinca
lpinca reviewed Aug 21, 2016
View reviewed changes
Comment thread doc/api/util.md Outdated

@lpinca lpinca Aug 21, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is when the module has been renamed. It was called sys before, not sure if it's better to show when the method was added to sys.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fishrock123 Fishrock123 Aug 21, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Qard Qard Aug 22, 2016

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of the added marks as a reference for the user to understand "how far back can I expect this thing to be in this place", so existence elsewhere before then is kind of irrelevant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca
doc: add added: information for util
bcc68de 
PR-URL: nodejs#8206
@lpinca
lpinca force-pushed the add/added-util branch from e655efc to bcc68de Compare August 21, 2016 14:04
@silverwind

silverwind commented Aug 21, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
3 similar comments
@jasnell

jasnell commented Aug 21, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Qard

Qard commented Aug 22, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bengl

bengl commented Aug 23, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Aug 23, 2016
@lpinca @jasnell
doc: add added: information for util
16f4b8e 
PR-URL: #8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@jasnell

jasnell commented Aug 23, 2016

Copy link
Copy Markdown
Member

Landed in 16f4b8e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Aug 23, 2016
@lpinca
lpinca deleted the add/added-util branch August 23, 2016 18:37
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@lpinca @evanlucas
doc: add added: information for util
d9142b4 
PR-URL: #8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
2016-08-26, Version 6.5.0 (Current) #8253
Merged
@lpinca lpinca mentioned this pull request Aug 26, 2016
doc: add added: information for crypto #8281
Closed
2 tasks done
@sam-github sam-github mentioned this pull request Sep 8, 2016
docs do not state at what version an API was introduced (or deprecated) #6578
Closed
32 of 36 tasks
@MylesBorins MylesBorins added the dont-land-on-v4.x label Sep 30, 2016
@MylesBorins

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

This doesn't land cleanly on v4.x please feel free to manually backport
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca added a commit to lpinca/node that referenced this pull request Oct 1, 2016
@lpinca
doc: add added: information for util
eaa49f2 
PR-URL: nodejs#8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@lpinca lpinca mentioned this pull request Oct 1, 2016
v4.x backport: doc: add added: information for util #8881
Closed
MylesBorins pushed a commit that referenced this pull request Oct 4, 2016
@lpinca Myles Borins
doc: add added: information for util
7ac5aef 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@lpinca Myles Borins
doc: add added: information for util
383419f 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@lpinca @rvagg
doc: add added: information for util
b35dcbf 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@lpinca @MylesBorins
doc: add added: information for util
b92e3fc 
Ref: #8881

PR-URL: #8206
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
V4.6.2 proposal #9298
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@lpinca @silverwind @jasnell @Qard @bengl @MylesBorins @Fishrock123 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.