GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — don't leak GIT_* env into `npm install` for `language: node` by cbirkhold · Pull Request #3774 · pre-commit/pre-commit

Conversation

@cbirkhold

@cbirkhold cbirkhold commented Oct 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

resolves #3773

Regressed in 4.6.1 (b1cc920, #3719). Since then the node install runs npm install git+file://<store clone>, which clones and checks out with git. when the install happens from git commit inside a submodule, git has exported absolute GIT_DIR / GIT_INDEX_FILE, so the checkout overwrote the submodule's index.

With this change applied, the install runs with no_git_env(), as the initial clone in store.py already does. only the npm install call changes. The environment hooks run in is unchanged.

The new test fails without the change (the user repository's index ends up with bin/main.js and package.json) and passes with it. #3773 reproduces the issue in a Docker container. The same Dockerfile may be used to demonstrate the fix with:

docker build --build-arg PRE_COMMIT=git+https://github.com/cbirkhold/ext-pre-commit@node-no-git-env-npm-install -t pre-commit-submodule-repro:fix .
docker run --rm pre-commit-submodule-repro:fix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
chrikrah

This comment was marked as spam.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Tycorc Tycorc mentioned this pull request Oct 11, 2026
npm install git+file:// during hook install inside a submodule overwrites the submodule's index #3773
Closed
@cbirkhold @asottile
don't leak GIT_* env into npm install for language: node
860d07d 
When a node hook environment is installed from `git commit` inside a
submodule, git exports absolute GIT_DIR / GIT_INDEX_FILE paths.
`npm install git+file://<store clone>` inherited them, so npm's checkout
of the hook repository overwrote the submodule's index and the commit
failed with `fatal: unable to read <sha>`.

Run the install with no_git_env(), as is already done for the initial
clone in store.py.

Signed-off-by: Chris Birkhold <[email protected]>
@asottile
asottile force-pushed the node-no-git-env-npm-install branch from 8fd690a to 860d07d Compare October 12, 2026 20:26
asottile
asottile approved these changes Oct 12, 2026
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile
asottile merged commit 73926c1 into pre-commit:main Oct 12, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.
rlichtenwalter pushed a commit to rlichtenwalter/kdtree that referenced this pull request Oct 16, 2026
Dependency Updater @rlichtenwalter
chore: Update pre-commit hooks
177e0e7 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update |
|---|---|---|---|---|---|
| [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/pre-commit/4.7.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pre-commit/4.5.1/4.7.0?slim=true) |  | minor |
| [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/pre-commit%2fmirrors-clang-format/v23.1.3?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/pre-commit%2fmirrors-clang-format/v23.1.1/v23.1.3?slim=true) | repository | patch |
| [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/rbubley%2fmirrors-prettier/v3.9.10?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/rbubley%2fmirrors-prettier/v3.9.9/v3.9.10?slim=true) | repository | patch |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12)

[Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0)

\==================

##### Fixes

- Fix `language: node` hooks during commit with `-a` or inside a submodule.
  - Regressed in 4.6.1.
  - [#&#8203;3773](pre-commit/pre-commit#3773) issue by [@&#8203;cbirkhold](https://github.com/cbirkhold).
  - [#&#8203;3774](pre-commit/pre-commit#3774) PR by [@&#8203;cbirkhold](https://github.com/cbirkhold).

### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10)

[Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2)

\==================

##### Fixes

- Fix `language: node` hooks that contain `"scripts": {"build": ...}` with
  npm 11.x.
  - Regressed in 4.6.1.
  - [#&#8203;3737](pre-commit/pre-commit#3737) issue by [@&#8203;mheiges](https://github.com/mheiges).
  - [#&#8203;3743](pre-commit/pre-commit#3743) PR by [@&#8203;asottile](https://github.com/asottile).

### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21)

[Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1)

\==================

##### Fixes

- Install `language: node` hooks via `git`.
  - Fixes npm 12.x compatibility
  - [#&#8203;3719](pre-commit/pre-commit#3719) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3517](pre-commit/pre-commit#3517) issue by [@&#8203;ojob](https://github.com/ojob).
- Set `JULIA_DEPOT_PATH` for `language: julia`.
  - [#&#8203;3711](pre-commit/pre-commit#3711) PR by [@&#8203;damonbayer](https://github.com/damonbayer).
  - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@&#8203;damonbayer](https://github.com/damonbayer).
- Produce error on mistyped `--repo` for `pre-commit autoupdate`.
  - [#&#8203;3701](pre-commit/pre-commit#3701) PR by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;3695](pre-commit/pre-commit#3695) issue by [@&#8203;mxr](https://github.com/mxr).
- Improve performance of commit existence check in `pre-push`.
  - [#&#8203;3726](pre-commit/pre-commit#3726) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3604](pre-commit/pre-commit#3604) issue by [@&#8203;ptarjan](https://github.com/ptarjan).
- Avoid duplicating conflicted filenames during `pre-commit run --all-files`.
  - [#&#8203;3727](pre-commit/pre-commit#3727) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3706](pre-commit/pre-commit#3706) issue by [@&#8203;RomanValov](https://github.com/RomanValov).

### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21)

[Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0)

\==================

##### Features

- `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier
  usage with `git` 2.54+ git hooks.
  - [#&#8203;3662](pre-commit/pre-commit#3662) PR by [@&#8203;asottile](https://github.com/asottile).

##### Fixes

- `pre-commit hook-impl`: `--hook-type` is required.
  - [#&#8203;3661](pre-commit/pre-commit#3661) PR by [@&#8203;asottile](https://github.com/asottile).

</details>

<details>
<summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary>

### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

</details>

<details>
<summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary>

### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

[Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/Denver)

- Branch creation
  - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Reviewed-on: https://git.lichtenwalter.site/rlichten/kdtree/pulls/69
Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN
Co-authored-by: Dependency Updater <[email protected]>
rlichtenwalter pushed a commit to rlichtenwalter/mRMR that referenced this pull request Oct 16, 2026
Dependency Updater @rlichtenwalter
chore: Update pre-commit hooks
7502f47 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update |
|---|---|---|---|---|---|
| [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/pre-commit/4.7.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pre-commit/4.5.1/4.7.0?slim=true) |  | minor |
| [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/pre-commit%2fmirrors-clang-format/v23.1.3?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/pre-commit%2fmirrors-clang-format/v23.1.1/v23.1.3?slim=true) | repository | patch |
| [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/rbubley%2fmirrors-prettier/v3.9.10?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/rbubley%2fmirrors-prettier/v3.9.9/v3.9.10?slim=true) | repository | patch |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12)

[Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0)

\==================

##### Fixes

- Fix `language: node` hooks during commit with `-a` or inside a submodule.
  - Regressed in 4.6.1.
  - [#&#8203;3773](pre-commit/pre-commit#3773) issue by [@&#8203;cbirkhold](https://github.com/cbirkhold).
  - [#&#8203;3774](pre-commit/pre-commit#3774) PR by [@&#8203;cbirkhold](https://github.com/cbirkhold).

### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10)

[Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2)

\==================

##### Fixes

- Fix `language: node` hooks that contain `"scripts": {"build": ...}` with
  npm 11.x.
  - Regressed in 4.6.1.
  - [#&#8203;3737](pre-commit/pre-commit#3737) issue by [@&#8203;mheiges](https://github.com/mheiges).
  - [#&#8203;3743](pre-commit/pre-commit#3743) PR by [@&#8203;asottile](https://github.com/asottile).

### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21)

[Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1)

\==================

##### Fixes

- Install `language: node` hooks via `git`.
  - Fixes npm 12.x compatibility
  - [#&#8203;3719](pre-commit/pre-commit#3719) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3517](pre-commit/pre-commit#3517) issue by [@&#8203;ojob](https://github.com/ojob).
- Set `JULIA_DEPOT_PATH` for `language: julia`.
  - [#&#8203;3711](pre-commit/pre-commit#3711) PR by [@&#8203;damonbayer](https://github.com/damonbayer).
  - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@&#8203;damonbayer](https://github.com/damonbayer).
- Produce error on mistyped `--repo` for `pre-commit autoupdate`.
  - [#&#8203;3701](pre-commit/pre-commit#3701) PR by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;3695](pre-commit/pre-commit#3695) issue by [@&#8203;mxr](https://github.com/mxr).
- Improve performance of commit existence check in `pre-push`.
  - [#&#8203;3726](pre-commit/pre-commit#3726) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3604](pre-commit/pre-commit#3604) issue by [@&#8203;ptarjan](https://github.com/ptarjan).
- Avoid duplicating conflicted filenames during `pre-commit run --all-files`.
  - [#&#8203;3727](pre-commit/pre-commit#3727) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3706](pre-commit/pre-commit#3706) issue by [@&#8203;RomanValov](https://github.com/RomanValov).

### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21)

[Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0)

\==================

##### Features

- `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier
  usage with `git` 2.54+ git hooks.
  - [#&#8203;3662](pre-commit/pre-commit#3662) PR by [@&#8203;asottile](https://github.com/asottile).

##### Fixes

- `pre-commit hook-impl`: `--hook-type` is required.
  - [#&#8203;3661](pre-commit/pre-commit#3661) PR by [@&#8203;asottile](https://github.com/asottile).

</details>

<details>
<summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary>

### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

</details>

<details>
<summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary>

### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

[Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/Denver)

- Branch creation
  - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Reviewed-on: https://git.lichtenwalter.site/rlichten/mRMR/pulls/79
Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN
Co-authored-by: Dependency Updater <[email protected]>
rlichtenwalter pushed a commit to rlichtenwalter/popc that referenced this pull request Oct 16, 2026
Dependency Updater @rlichtenwalter
chore: Update pre-commit hooks
9b3e95a 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update |
|---|---|---|---|---|---|
| [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/pre-commit/4.7.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pre-commit/4.5.1/4.7.0?slim=true) |  | minor |
| [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/pre-commit%2fmirrors-clang-format/v23.1.3?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/pre-commit%2fmirrors-clang-format/v23.1.1/v23.1.3?slim=true) | repository | patch |
| [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/rbubley%2fmirrors-prettier/v3.9.10?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/rbubley%2fmirrors-prettier/v3.9.9/v3.9.10?slim=true) | repository | patch |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12)

[Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0)

\==================

##### Fixes

- Fix `language: node` hooks during commit with `-a` or inside a submodule.
  - Regressed in 4.6.1.
  - [#&#8203;3773](pre-commit/pre-commit#3773) issue by [@&#8203;cbirkhold](https://github.com/cbirkhold).
  - [#&#8203;3774](pre-commit/pre-commit#3774) PR by [@&#8203;cbirkhold](https://github.com/cbirkhold).

### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10)

[Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2)

\==================

##### Fixes

- Fix `language: node` hooks that contain `"scripts": {"build": ...}` with
  npm 11.x.
  - Regressed in 4.6.1.
  - [#&#8203;3737](pre-commit/pre-commit#3737) issue by [@&#8203;mheiges](https://github.com/mheiges).
  - [#&#8203;3743](pre-commit/pre-commit#3743) PR by [@&#8203;asottile](https://github.com/asottile).

### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21)

[Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1)

\==================

##### Fixes

- Install `language: node` hooks via `git`.
  - Fixes npm 12.x compatibility
  - [#&#8203;3719](pre-commit/pre-commit#3719) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3517](pre-commit/pre-commit#3517) issue by [@&#8203;ojob](https://github.com/ojob).
- Set `JULIA_DEPOT_PATH` for `language: julia`.
  - [#&#8203;3711](pre-commit/pre-commit#3711) PR by [@&#8203;damonbayer](https://github.com/damonbayer).
  - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@&#8203;damonbayer](https://github.com/damonbayer).
- Produce error on mistyped `--repo` for `pre-commit autoupdate`.
  - [#&#8203;3701](pre-commit/pre-commit#3701) PR by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;3695](pre-commit/pre-commit#3695) issue by [@&#8203;mxr](https://github.com/mxr).
- Improve performance of commit existence check in `pre-push`.
  - [#&#8203;3726](pre-commit/pre-commit#3726) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3604](pre-commit/pre-commit#3604) issue by [@&#8203;ptarjan](https://github.com/ptarjan).
- Avoid duplicating conflicted filenames during `pre-commit run --all-files`.
  - [#&#8203;3727](pre-commit/pre-commit#3727) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3706](pre-commit/pre-commit#3706) issue by [@&#8203;RomanValov](https://github.com/RomanValov).

### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21)

[Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0)

\==================

##### Features

- `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier
  usage with `git` 2.54+ git hooks.
  - [#&#8203;3662](pre-commit/pre-commit#3662) PR by [@&#8203;asottile](https://github.com/asottile).

##### Fixes

- `pre-commit hook-impl`: `--hook-type` is required.
  - [#&#8203;3661](pre-commit/pre-commit#3661) PR by [@&#8203;asottile](https://github.com/asottile).

</details>

<details>
<summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary>

### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

</details>

<details>
<summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary>

### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

[Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/Denver)

- Branch creation
  - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Reviewed-on: https://git.lichtenwalter.site/rlichten/popc/pulls/33
Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN
Co-authored-by: Dependency Updater <[email protected]>
rlichtenwalter pushed a commit to rlichtenwalter/vcp that referenced this pull request Oct 16, 2026
Dependency Updater @rlichtenwalter
chore: Update pre-commit hooks
134b5b8 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | Type | Update |
|---|---|---|---|---|---|
| [pre-commit](https://github.com/pre-commit/pre-commit) | `4.5.1` → `4.7.0` | ![age](https://developer.mend.io/api/mc/badges/age/pypi/pre-commit/4.7.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pre-commit/4.5.1/4.7.0?slim=true) |  | minor |
| [pre-commit/mirrors-clang-format](https://github.com/pre-commit/mirrors-clang-format) | `v23.1.1` → `v23.1.3` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/pre-commit%2fmirrors-clang-format/v23.1.3?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/pre-commit%2fmirrors-clang-format/v23.1.1/v23.1.3?slim=true) | repository | patch |
| [rbubley/mirrors-prettier](https://github.com/rbubley/mirrors-prettier) | `v3.9.9` → `v3.9.10` | ![age](https://developer.mend.io/api/mc/badges/age/github-tags/rbubley%2fmirrors-prettier/v3.9.10?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/rbubley%2fmirrors-prettier/v3.9.9/v3.9.10?slim=true) | repository | patch |

Note: The `pre-commit` manager in Renovate is not supported by the `pre-commit` maintainers or community. Please do not report any problems there, instead [create a Discussion in the Renovate repository](https://github.com/renovatebot/renovate/discussions/new) if you have any questions.

---

### Release Notes

<details>
<summary>pre-commit/pre-commit (pre-commit)</summary>

### [`v4.7.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#470---2026-10-12)

[Compare Source](pre-commit/pre-commit@v4.6.2...v4.7.0)

\==================

##### Fixes

- Fix `language: node` hooks during commit with `-a` or inside a submodule.
  - Regressed in 4.6.1.
  - [#&#8203;3773](pre-commit/pre-commit#3773) issue by [@&#8203;cbirkhold](https://github.com/cbirkhold).
  - [#&#8203;3774](pre-commit/pre-commit#3774) PR by [@&#8203;cbirkhold](https://github.com/cbirkhold).

### [`v4.6.2`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#462---2026-08-10)

[Compare Source](pre-commit/pre-commit@v4.6.1...v4.6.2)

\==================

##### Fixes

- Fix `language: node` hooks that contain `"scripts": {"build": ...}` with
  npm 11.x.
  - Regressed in 4.6.1.
  - [#&#8203;3737](pre-commit/pre-commit#3737) issue by [@&#8203;mheiges](https://github.com/mheiges).
  - [#&#8203;3743](pre-commit/pre-commit#3743) PR by [@&#8203;asottile](https://github.com/asottile).

### [`v4.6.1`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#461---2026-07-21)

[Compare Source](pre-commit/pre-commit@v4.6.0...v4.6.1)

\==================

##### Fixes

- Install `language: node` hooks via `git`.
  - Fixes npm 12.x compatibility
  - [#&#8203;3719](pre-commit/pre-commit#3719) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3517](pre-commit/pre-commit#3517) issue by [@&#8203;ojob](https://github.com/ojob).
- Set `JULIA_DEPOT_PATH` for `language: julia`.
  - [#&#8203;3711](pre-commit/pre-commit#3711) PR by [@&#8203;damonbayer](https://github.com/damonbayer).
  - [pre-commit-ci/runner-image#335](pre-commit-ci/runner-image#335) issue by [@&#8203;damonbayer](https://github.com/damonbayer).
- Produce error on mistyped `--repo` for `pre-commit autoupdate`.
  - [#&#8203;3701](pre-commit/pre-commit#3701) PR by [@&#8203;mxr](https://github.com/mxr).
  - [#&#8203;3695](pre-commit/pre-commit#3695) issue by [@&#8203;mxr](https://github.com/mxr).
- Improve performance of commit existence check in `pre-push`.
  - [#&#8203;3726](pre-commit/pre-commit#3726) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3604](pre-commit/pre-commit#3604) issue by [@&#8203;ptarjan](https://github.com/ptarjan).
- Avoid duplicating conflicted filenames during `pre-commit run --all-files`.
  - [#&#8203;3727](pre-commit/pre-commit#3727) PR by [@&#8203;asottile](https://github.com/asottile).
  - [#&#8203;3706](pre-commit/pre-commit#3706) issue by [@&#8203;RomanValov](https://github.com/RomanValov).

### [`v4.6.0`](https://github.com/pre-commit/pre-commit/blob/HEAD/CHANGELOG.md#460---2026-04-21)

[Compare Source](pre-commit/pre-commit@v4.5.1...v4.6.0)

\==================

##### Features

- `pre-commit hook-impl`: allow `--hook-dir` to be missing to enable easier
  usage with `git` 2.54+ git hooks.
  - [#&#8203;3662](pre-commit/pre-commit#3662) PR by [@&#8203;asottile](https://github.com/asottile).

##### Fixes

- `pre-commit hook-impl`: `--hook-type` is required.
  - [#&#8203;3661](pre-commit/pre-commit#3661) PR by [@&#8203;asottile](https://github.com/asottile).

</details>

<details>
<summary>pre-commit/mirrors-clang-format (pre-commit/mirrors-clang-format)</summary>

### [`v23.1.3`](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.2...v23.1.3)

### [`v23.1.2`](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

[Compare Source](pre-commit/mirrors-clang-format@v23.1.1...v23.1.2)

</details>

<details>
<summary>rbubley/mirrors-prettier (rbubley/mirrors-prettier)</summary>

### [`v3.9.10`](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

[Compare Source](rbubley/mirrors-prettier@v3.9.9...v3.9.10)

</details>

---

### Configuration

📅 **Schedule**: (in timezone America/Denver)

- Branch creation
  - Between 02:00 AM and 06:59 AM, only on Tuesday (`* 2-6 * * 2`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzIuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjEzMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Reviewed-on: https://git.lichtenwalter.site/rlichten/vcp/pulls/51
Claude-Session: https://claude.ai/code/session_016fdoaYYuKfcUK1CpBzCeBN
Co-authored-by: Dependency Updater <[email protected]>
@mvillmow mvillmow mentioned this pull request Oct 19, 2026
fix(ci): preserve the contribution index during cold hook setup HomericIntelligence/Hephaestus#3426
Merged
@felixonmars felixonmars mentioned this pull request Nov 7, 2026
updpatch: pre-commit 4.7.0-1 felixonmars/archriscv-packages#6433
Merged
felixonmars added a commit to felixonmars/archriscv-packages that referenced this pull request Nov 7, 2026
@felixonmars
updpatch: pre-commit 4.7.0-1
4d74f8b 
Refresh the bootstrap patch for upstream's contextlib.chdir migration and
the npm setup_cmd env argument.

Update the Perl fixture to Perl-Tidy 20250912, which fixes "Possible
attempt to escape whitespace in qw() list" appearing before its version
banner. Keep the strict assertion; no corresponding pre-commit fix was
found.

Use Node 18.20.8 for the RISC-V version test after 18.14.0 segfaulted while
querying npm on native mausholdv. Keep the Node 26.7.0 npm assertion where
that artifact exists; RISC-V uses 26.0.0 because nodeenv 1.12.0 ignores
the failed config-driven npm installation's return code.

Correct the stale bootstrap patch BLAKE2 digest that stopped source
validation on articuno. It matches the earlier November 5 local draft,
before the Node fixture adjustments, while SHA-512 already matches the
final committed patch. Comparing both drafts accounts for the payload
changes; this checksum correction changes neither patch payload. The
cached upstream archive matches both hashes in Arch's October 13 release
tag, with no upstream artifact replacement involved.

pre-commit/pre-commit@9905e88afc7d
pre-commit/pre-commit#3774
perltidy/perltidy#191
https://cpan.metacpan.org/authors/id/S/SH/SHANCOCK/Perl-Tidy-20250912.tar.gz
https://unofficial-builds.nodejs.org/download/release/v18.20.8/
https://github.com/ekalinin/nodeenv/blob/1.12.0/nodeenv.py
https://gitlab.archlinux.org/archlinux/packaging/packages/pre-commit/-/blob/4.7.0-1/PKGBUILD
https://archriscv.felixc.at/.status/logs/20261105174743-2f9fd6-pre-commit.log
https://archriscv.felixc.at/.status/logs/pre-commit/pre-commit-4.7.0-1.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes
+1 more reviewer
@chrikrah chrikrah chrikrah approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

npm install git+file:// during hook install inside a submodule overwrites the submodule's index

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cbirkhold @asottile @chrikrah
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.