Description

iritkatriel

opened on Mar 19, 2023

Issue body actions

shutil.rmtree accepts as onerror a callback to should expect an exc_info tuple. To move off this, I will add a new kwarg "onexc" which should expect just an exception object. onerror will continue to work for now, but be deprecated.

Linked PRs

• gh-102828: add onexc arg to shutil.rmtree. Deprecate onerror. #102829
• gh-102828: fix test failure (add missing skip instructions) #102835
• gh-102828: emit deprecation warning for onerror arg to shutil.rmtree #102850
• gh-102828: set stacklevel on deprecation warning #103422

Activity

1. iritkatriel

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Mar 19, 2023
2. iritkatriel

   added a commit that references this issue on Mar 19, 2023

   pythongh-102828: add onexc arg to shutil.rmtree. Deprecate onerror.

   86a1cea
3. iritkatriel

   closed this as completedin #102829on Mar 19, 2023
4. iritkatriel

   added 5 commits that reference this issue on Mar 19, 2023

   gh-102828: add onexc arg to shutil.rmtree. Deprecate onerror. (#102829)

   d51a6dc

   pythongh-102828: fix test failure (add missing skip instructions)

   b30b375

   gh-102828: fix test failure (add missing skip instructions) (#102835)

   40d4f15

   pythongh-102828: add deprecation warning for onerror arg to shutil.rm…

   ef0e4cd

   gh-102828: emit deprecation warning for onerror arg to shutil.rmtree (#…

   7f760c2
5. Fidget-Spinner

   added 3 commits that reference this issue on Mar 27, 2023

   pythongh-102828: add onexc arg to shutil.rmtree. Deprecate onerror. (p…

   c8e62e7

   pythongh-102828: fix test failure (add missing skip instructions) (py…

   5699276

   pythongh-102828: emit deprecation warning for onerror arg to shutil.r…

   6776fb1
6. iritkatriel

   added a commit that references this issue on Apr 11, 2023

   gh-102828: set stacklevel on deprecation warning (#103422)

   8026cda
7. warsaw

   added 3 commits that reference this issue on Apr 11, 2023

   pythongh-102828: add onexc arg to shutil.rmtree. Deprecate onerror. (p…

   7f3bf06

   pythongh-102828: fix test failure (add missing skip instructions) (py…

   ae76f91

   pythongh-102828: emit deprecation warning for onerror arg to shutil.r…

   033e424
8. 5 remaining items
9. pmisik

   added 8 commits that reference this issue on Dec 8, 2023

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   e056251

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   473a023

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   a5871c4

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   659b813

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   f39c458

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   99e25d9

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   d8679e2

   tests: Address deprecation warning in shutil.rmtree(onerror=...)

   652535c
10. p12tic

    added a commit that references this issue on Dec 22, 2023

    tests: Address deprecation warning in shutil.rmtree(onerror=...)

    16140c0
11. pmisik

    added 2 commits that reference this issue on Dec 22, 2023

    tests: Address deprecation warning in shutil.rmtree(onerror=...)

    8262e42

    tests: Address deprecation warning in shutil.rmtree(onerror=...)

    0f13029
12. p12tic

    added 2 commits that reference this issue on Dec 26, 2023

    tests: Address deprecation warning in shutil.rmtree(onerror=...)

    1e4b142

    tests: Address deprecation warning in shutil.rmtree(onerror=...)

    967a862
13. kfsone commented on Jul 1, 2024

    

    kfsone

    on Jul 1, 2024

    More actions

    What is the urgency in removing the 'onerror' parameter? A concern about shutil.rmtree performance of accepting both arguments? Or is it just part of the core-python lemming-suicide pact to drive users away by making python as consistently self-incompatible as possible?
14. iritkatriel commented on Jul 1, 2024

    

    iritkatriel

    on Jul 1, 2024

    MemberAuthor

    More actions

    What is the urgency in removing the 'onerror' parameter?

    Nobody indicated any urgency. You made that up just so you can entertain us with your witty insult.

    Reacted by Hugo van Kemenade

    Reacted by João Gonçalves

Issue actions