Description

chrstphrchvz

opened on Apr 25, 2023

Issue body actions

Bug report

On X11, vertical scrolling is conventionally done using events for mouse “buttons” 4 and 5. But on Win32 and Aqua, which have a dedicated event for scrolling (<MouseWheel> in Tk), buttons 4 and 5 correspond to additional hardware buttons present on some mice. Tk 8.6 and earlier do not abstract away these platform differences, so bindings in IDLE for scrolling should ignore buttons 4 and 5 on non-X11.

Accordingly, idlelib.idle_test.test_sidebar.ShellSidebarTest.test_mousewheel should be revised to check the windowing system, so that it correctly distinguishes between Aqua and XQuartz (which sys.platform == 'darwin' does not do), sends button 4/5 events on X11 only, and sends <MouseWheel> with the correct sign for delta on Aqua.

Tk 8.7 (TIP 474) will change mouse events to be consistent across windowing systems. This requires further revisions, but I imagine it is better to separately address issues for Tk ≤ 8.6 first.

Linked PRs

• gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11 #103821
• [3.12] gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11 (GH-103821) #114901
• [3.11] gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11 (GH-103821) #114902

Activity

1. chrstphrchvz

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Apr 25, 2023
2. terryjreedy

   added

   topic-IDLE

   on Apr 25, 2023
3. terryjreedy

   added this to IDLE Issueson Apr 25, 2023
4. terryjreedy commented on Apr 25, 2023

   

   terryjreedy

   on Apr 25, 2023

   Member

   More actions

   The topic-IDLE label makes sure I get notified.
5. serhiy-storchaka

   added a commit that references this issue on Feb 2, 2024

   gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11 (…

   d25d4ee
6. miss-islington

   added 2 commits that reference this issue on Feb 2, 2024

   pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

   f588c72

   pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

   d5f5373
7. serhiy-storchaka

   added 2 commits that reference this issue on Feb 2, 2024

   [3.12] gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on …

   564d848

   [3.11] gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on …

   e995c58
8. serhiy-storchaka

   closed this as completedon Feb 2, 2024
9. github-project-automation

   moved this to Done in IDLE Issueson Feb 2, 2024
10. serhiy-storchaka commented on Feb 2, 2024

    

    serhiy-storchaka

    on Feb 2, 2024

    Member

    More actions

    Thank you for your contribution @chrstphrchvz. For this issue and for others, whose turn has not yet come to me.

    Reacted by Christopher Chavez
11. aisk

    added a commit that references this issue on Feb 11, 2024

    pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

    4318f4b
12. fsc-eriker

    added a commit that references this issue on Feb 14, 2024

    pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

    7f2daa2

Issue actions