GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11 by chrstphrchvz · Pull Request #103821 · python/cpython

Conversation

chrstphrchvz commented Apr 25, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Tested as a patch for 3.11.3 with Tk 8.6.13 (for both Aqua and XQuartz).

Issue: IDLE bindings for scrolling using buttons 4 and 5 should only apply to X11 #103820

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

chrstphrchvz added 2 commits

April 24, 2023 21:41


          Revise test_mousewheel

c6ab214


          Revise IDLE bindings for scrolling

4c6d5bc

chrstphrchvz requested a review from terryjreedy as a code owner

April 25, 2023 03:04

bedevere-bot mentioned this pull request

Apr 25, 2023

IDLE bindings for scrolling using buttons 4 and 5 should only apply to X11 #103820

Closed

bedevere-bot added the awaiting review label

Apr 25, 2023

chrstphrchvz commented Apr 25, 2023

Copy link

Copy Markdown

Contributor Author

Note that, as an alternative to testing with unusual hardware, utilities like Karabiner Elements, AutoHotKey, and xdotool are useful for emulating mouse and keyboard events.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev added the topic-IDLE label

Apr 26, 2023

This comment was marked as outdated.

chrstphrchvz marked this pull request as draft

May 2, 2023 07:25


          Merge branch 'main' into patch-103820

010519b

chrstphrchvz mentioned this pull request

May 2, 2023

gh-88496: IDLE - fix another test on macOS #104075

Merged


          test_mousewheel: Do not skip test

2e27a94

…which was broken due to incorrect delta on Aqua and XQuartz,
and probably not because of `.update_idletasks()`.

chrstphrchvz marked this pull request as ready for review

May 2, 2023 09:17

chrstphrchvz added 2 commits

October 18, 2023 13:08


          Merge branch 'main' into patch-103820

b96e475


          Merge branch 'main' into patch-103820

1ac1202

serhiy-storchaka changed the title ~~gh-103820: Do not interpret buttons 4/5 as scrolling on non-X11~~ gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on non-X11

Feb 2, 2024


          Merge branch 'main' into patch-103820

f504718

serhiy-storchaka approved these changes

Feb 2, 2024

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Feb 2, 2024

serhiy-storchaka enabled auto-merge (squash)

February 2, 2024 10:18

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Feb 2, 2024

serhiy-storchaka merged commit d25d4ee into python:main

Feb 2, 2024

miss-islington-app Bot commented Feb 2, 2024

Copy link

Copy Markdown

Thanks @chrstphrchvz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Feb 2, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 2, 2024


          pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

f588c72

…on-X11 (pythonGH-103821)

Also fix test_mousewheel: do not skip a check which was broken due to incorrect
delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
(cherry picked from commit d25d4ee)

Co-authored-by: Christopher Chavez <[email protected]>

bedevere-app Bot commented Feb 2, 2024

Copy link

Copy Markdown

GH-114901 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Feb 2, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 2, 2024


          pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

d5f5373

…on-X11 (pythonGH-103821)

Also fix test_mousewheel: do not skip a check which was broken due to incorrect
delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
(cherry picked from commit d25d4ee)

Co-authored-by: Christopher Chavez <[email protected]>

bedevere-app Bot commented Feb 2, 2024

Copy link

Copy Markdown

GH-114902 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Feb 2, 2024

serhiy-storchaka pushed a commit that referenced this pull request

Feb 2, 2024


          [3.12] gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on …

564d848

…non-X11 (GH-103821) (GH-114901)

Also fix test_mousewheel: do not skip a check which was broken due to incorrect
delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
(cherry picked from commit d25d4ee)

Co-authored-by: Christopher Chavez <[email protected]>

serhiy-storchaka pushed a commit that referenced this pull request

Feb 2, 2024


          [3.11] gh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on …

e995c58

…non-X11 (GH-103821) (GH-114902)

Also fix test_mousewheel: do not skip a check which was broken due to incorrect
delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.
(cherry picked from commit d25d4ee)

Co-authored-by: Christopher Chavez <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

4318f4b

…on-X11 (pythonGH-103821)

Also fix test_mousewheel: do not skip a check which was broken due to incorrect
delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.

chrstphrchvz deleted the patch-103820 branch

February 14, 2024 13:18

fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request

Feb 14, 2024


          pythongh-103820: IDLE: Do not interpret buttons 4/5 as scrolling on n…

7f2daa2

…on-X11 (pythonGH-103821)

Also fix test_mousewheel: do not skip a check which was broken due to incorrect
delta on Aqua and XQuartz, and probably not because of `.update_idletasks()`.

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

terryjreedy

Awaiting requested review from terryjreedy

terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-IDLE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

chrstphrchvz commented Apr 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrstphrchvz commented Apr 25, 2023

Uh oh!

This comment was marked as outdated.

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Feb 2, 2024

Uh oh!

bedevere-app Bot commented Feb 2, 2024

Uh oh!

bedevere-app Bot commented Feb 2, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chrstphrchvz commented Apr 25, 2023 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.