Description

samschott

opened on May 4, 2023

Issue body actions

Feature or enhancement

Allow urllib.request.getproies() to detect SOCKS proxies configured in macOS system settings.

Pitch

urllib.request.getproies() is widely used, for example by requests, to detect proxy configurations from environment variables, macOS System Settings or the Windows Systems Registry. On macOS, however, it does not support reading SOCKS proxy configurations. This is supported on Windows, see #26307.

I'm not sure if this is intentional or just an oversight, but the difference is certainly not documented in https://docs.python.org/3/library/urllib.request.html#urllib.request.getproxies. It would be nice to have feature parity here.

Linked PRs

• gh-104180: Read SOCKS proxies from macOS System Configuration #104181

Activity

1. samschott

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on May 4, 2023
2. samschott

   changed the title [-]Support detecting SOCKS proxy configuration in[/-] [+]Support detecting SOCKS proxy configuration on macOS[/+] on May 4, 2023
3. gaogaotiantian

   added

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   on May 4, 2023
4. ned-deily

   added

   OS-mac

   on May 5, 2023
5. ronaldoussoren commented on May 5, 2023

   

   ronaldoussoren

   on May 5, 2023

   Contributor

   More actions

   Not having SOCKS support is an oversight. At the time I didn't know urllib supported SOCKS, and my use-case when adding this was an environment with a regular HTTP proxy.
6. ronaldoussoren

   added a commit that references this issue on May 9, 2023

   gh-104180: Read SOCKS proxies from macOS System Configuration (#104181)

   9a9b176
7. carljm

   added 4 commits that reference this issue on May 9, 2023

   Merge branch 'main' into inlinecomp2

   95401fe

   Merge branch 'main' into fixsendfamily

   a614216

   Merge branch 'main' into supermon

   c48eee3

   Merge branch 'main' into fixloadsuperspec

   cf11908
8. ronaldoussoren commented on May 14, 2023

   

   ronaldoussoren

   on May 14, 2023

   Contributor

   More actions

   @samschott : Thanks for the PR.

   Closing the issue as the PR is merged and this is a feature change that cannot be back ported.
9. ronaldoussoren

   closed this as completedon May 14, 2023

Issue actions