GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42627: Fix wrong parsing of Windows registry proxy settings by CrazyBoyFeng · Pull Request #26307 · python/cpython

Conversation

@CrazyBoyFeng

@CrazyBoyFeng CrazyBoyFeng commented May 22, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In Windows registry proxy settings, https=host:456 does not mean that the proxy server communicates with the client through the HTTPS protocol, but it means that the proxy server proxies the client's traffic to the HTTPS website. The proxy server itself communicates with the client through the HTTP protocol by default.

fix pypa/pip#9568 fix pypa/pip#9614 fix urllib3/urllib3#2164 fix psf/requests#5740

https://bugs.python.org/issue42627

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kotori2, keuin, jiasli, gfxonline, FantasqueX, Zxilly, and zhoudachan reacted with thumbs up emoji
All reactions
  • 👍 7 reactions
@CrazyBoyFeng
bpo-42627: Fix wrong parsing of Windows registry proxy settings
8ca4f5a 
https://bugs.python.org/issue42627
@the-knights-who-say-ni

the-knights-who-say-ni commented May 22, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@CrazyBoyFeng

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label May 22, 2021
@bedevere-bot bedevere-bot added the awaiting review label May 22, 2021
@blurb-it
📜🤖 Added by blurb_it.
5b7d88c
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels May 24, 2021
@CrazyBoyFeng
CrazyBoyFeng marked this pull request as ready for review May 24, 2021 13:48
@the-knights-who-say-ni

the-knights-who-say-ni commented May 28, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@testinguser

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added CLA not signed and removed CLA signed labels May 28, 2021
CrazyBoyFeng and others added 3 commits May 28, 2021 14:17
@CrazyBoyFeng
Remove support for multi proxy per one protocol
dc2e781 
Keep backward compatibility
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
2edd42a
@CrazyBoyFeng
Use SOCKS proxy for HTTP(S) protocols
33f07b2 
To compat with customary formats from software such as `requests[socks]`
keuin
keuin reviewed Jun 8, 2021
View reviewed changes
Comment thread Lib/urllib/request.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
CrazyBoyFeng added 2 commits June 8, 2021 18:45
@CrazyBoyFeng
Fix ValueError
37fd713
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
116e7eb
@cubercsl cubercsl mentioned this pull request Jul 3, 2021
Bug Report: python pip异常 Qv2ray/Qv2ray#1581
Closed
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
793fead
zooba
zooba reviewed Sep 7, 2021
View reviewed changes
Comment thread Lib/urllib/request.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@CrazyBoyFeng
Fix ValueError
e74efd8 
#26307 (comment)
@CrazyBoyFeng
CrazyBoyFeng requested a review from zooba September 8, 2021 09:31
@jiasli jiasli mentioned this pull request Sep 15, 2021
az login fails with "ssl.SSLEOFError: EOF occurred in violation of protocol" Azure/azure-cli#19456
Closed
@zooba

zooba commented Sep 16, 2021

Copy link
Copy Markdown
Member

@CrazyBoyFeng Looks like you're going to hit a known error in CI right now. Merging the latest from master should fix it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
3e4cd4b
@CrazyBoyFeng

CrazyBoyFeng commented Sep 17, 2021

Copy link
Copy Markdown
Contributor Author

I've synced the branch to the latest, hope this works.
gfxonline reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CrazyBoyFeng added 2 commits September 17, 2021 21:58
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
cf3ca0c
@CrazyBoyFeng
Merge branch 'python:main' into fix-issue-42627
e12cfa5
@bedevere-bot bedevere-bot removed the awaiting review label May 11, 2022
@zooba zooba added OS-windows needs backport to 3.9 needs backport to 3.11 only security fixes labels May 11, 2022
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor

Thanks @CrazyBoyFeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor

Thanks @CrazyBoyFeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor

Thanks @CrazyBoyFeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2022
@CrazyBoyFeng @miss-islington
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
cefa718 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label May 11, 2022
@bedevere-bot

bedevere-bot commented May 11, 2022

Copy link
Copy Markdown

GH-92684 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2022
@CrazyBoyFeng @miss-islington
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
702dacf 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label May 11, 2022
@bedevere-bot

bedevere-bot commented May 11, 2022

Copy link
Copy Markdown

GH-92685 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2022
@CrazyBoyFeng @miss-islington
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
c067672 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 11, 2022
@bedevere-bot

bedevere-bot commented May 11, 2022

Copy link
Copy Markdown

GH-92686 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 11, 2022
@miss-islington @CrazyBoyFeng
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (G…
5a33643 
…H-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
miss-islington added a commit that referenced this pull request May 11, 2022
@miss-islington @CrazyBoyFeng
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (G…
65d2dfd 
…H-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
zooba pushed a commit that referenced this pull request May 12, 2022
@miss-islington @CrazyBoyFeng
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (G…
9743524 
…H-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
@findix findix mentioned this pull request May 27, 2022
点击下载按钮之后没有反应怎么解决？ findix/ArtStationDownloader#25
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @CrazyBoyFeng @hello-adam
bpo-42627: Fix incorrect parsing of Windows registry proxy settings (p…
ac9fdc2 
…ythonGH-26307)

(cherry picked from commit b69297e)

Co-authored-by: 狂男风 <[email protected]>
@Myoufer Myoufer mentioned this pull request Dec 4, 2022
Critical Error A critical error occurred while processing the node data returned by the backend. Error: Failed to fetch chaiNNer-org/chaiNNer#1335
Closed
@dyhkwong dyhkwong mentioned this pull request Dec 20, 2022
Fix windows proxy SagerNet/sing-box#285
Closed
@akynazh akynazh mentioned this pull request Feb 19, 2023
[Bug]: translators.server.TranslatorError: Unable to connect the Internet. UlionTse/translators#110
Closed
2 tasks done
@LaoshuBaby LaoshuBaby mentioned this pull request Apr 16, 2023
[Feature Request] Add proxy support enzet/map-machine#151
Open
@samschott samschott mentioned this pull request May 4, 2023
Support detecting SOCKS proxy configuration on macOS #104180
Closed
@cyfex

cyfex commented May 8, 2023

Copy link
Copy Markdown

In Ubuntu 22.04, pip 23.1.2, python 3.10, this issue is still an issue. It seems not to be able to handle socks5 proxy properly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented May 8, 2023

Copy link
Copy Markdown
Member

Please file a new issue. It's no good commenting on an already completed PR that had nothing to do with your concern.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@python python locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zooba zooba zooba left review comments
+1 more reviewer
@keuin keuin keuin left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTTP only system proxy not working properly on Windows --cert and global.cert not working SSL certificate error with pip 21.0.1 Unable to use system proxy with HTTPS connection on Windows and Python 3.9

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@CrazyBoyFeng @the-knights-who-say-ni @zooba @gfxonline @sethmlarson @miss-islington @bedevere-bot @cyfex @keuin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.