Description

chrstphrchvz

opened on May 15, 2023

Issue body actions

Tk 8.7 (as of https://core.tcl-lang.org/tk/info/2991150c09f6) adds quotes around window pathnames in a few error messages, including those triggered by two Tkinter tests, causing them to fail:

======================================================================
FAIL: test_pack_configure_in (test.test_tkinter.test_geometry_managers.PackTest.test_pack_configure_in)
----------------------------------------------------------------------
_tkinter.TclError: can't pack ".pack.a" inside itself

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/user/git/cpython/Lib/test/test_tkinter/test_geometry_managers.py", line 111, in test_pack_configure_in
    with self.assertRaisesRegex(TclError,
AssertionError: "can't pack .pack.a inside itself" does not match "can't pack ".pack.a" inside itself"

======================================================================
FAIL: test_place_configure_in (test.test_tkinter.test_geometry_managers.PlaceTest.test_place_configure_in)
----------------------------------------------------------------------
_tkinter.TclError: can't place ".!toplevel2.!frame2" relative to itself

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/user/git/cpython/Lib/test/test_tkinter/test_geometry_managers.py", line 295, in test_place_configure_in
    with self.assertRaisesRegex(TclError, "can't place %s relative to "
AssertionError: "can't place \.!toplevel2\.!frame2 relative to itself" does not match "can't place ".!toplevel2.!frame2" relative to itself"

Linked PRs

• gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors #104495
• [3.11] gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (GH-104495) #104569

Activity

1. chrstphrchvz

   added a commit that references this issue on May 15, 2023

   pythongh-104494: Update Tkinter tests for Tk 8.7 errors

   c753ae2
2. terryjreedy

   added

   topic-tkinter

   on May 15, 2023
3. chrstphrchvz

   changed the title [-]Tkinter: Tk 8.7 quotes pathnames in error messages[/-] [+]Tkinter: Tk 8.7 quotes pathnames in certain error messages[/+] on May 15, 2023
4. terryjreedy commented on May 15, 2023

   

   terryjreedy

   on May 15, 2023

   Member

   More actions

   I have asked on the triager-coredev discord whether these prevent-future-bug issues should be considered enhancements or bugfixes (and eligible to be backported). Even if we decide not an issue for 3.11, this will matter soon for 3.12, when 3.12.0b1 is released (a week?) and 'main' becomes the future 3.13.0.
5. erlend-aasland commented on May 15, 2023

   

   erlend-aasland

   on May 15, 2023

   Contributor

   More actions

   Adjusting tests for Tk 8.7 compatibility is fine. This happens for other extension modules with third party deps as well (for example the sqlite3 module). I'd be fine to backport the test adjustments to 3.11. (3.10 is out of the question, since it only accepts security fixes).
6. terryjreedy

   added a commit that references this issue on May 15, 2023

   gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (#…

   3cba61f
7. terryjreedy commented on May 15, 2023

   

   terryjreedy

   on May 15, 2023

   Member

   More actions

   Some of the adjustments will be to _tkinter or tkinter code, not tests. Example in
   #104496.
8. terryjreedy

   closed this as completedon May 15, 2023
9. carljm

   added 2 commits that reference this issue on May 15, 2023

   Merge branch 'main' into supermon

   343867a

   Merge branch 'main' into cached_property_docs

   452d9f5
10. terryjreedy commented on May 16, 2023

    

    terryjreedy

    on May 16, 2023

    Member

    More actions

    I now agree that we should backport all tests. See new tracking issue #104568. Will immediately backport the PR here.

    Reacted by Erlend E. Aasland
11. miss-islington

    added a commit that references this issue on May 16, 2023

    pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 e…

    ba797a6
12. terryjreedy

    added a commit that references this issue on May 17, 2023

    [3.11] gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 …

    dece9c0

Issue actions