GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors by chrstphrchvz · Pull Request #104495 · python/cpython

Conversation

@chrstphrchvz

@chrstphrchvz chrstphrchvz commented May 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Tkinter: Tk 8.7 quotes pathnames in certain error messages #104494

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chrstphrchvz
pythongh-104494: Update Tkinter tests for Tk 8.7 errors
c753ae2
@bedevere-bot bedevere-bot added the awaiting review label May 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 15, 2023
Tkinter: Tk 8.7 quotes pathnames in certain error messages #104494
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label May 15, 2023
@terryjreedy terryjreedy added topic-tkinter and removed topic-tkinter labels May 15, 2023
terryjreedy
terryjreedy requested changes May 15, 2023
View reviewed changes
Comment thread Lib/test/test_tkinter/test_geometry_managers.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_tkinter/test_geometry_managers.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels May 15, 2023
@bedevere-bot

bedevere-bot commented May 15, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrstphrchvz @terryjreedy
Apply suggestions from code review
56f2b32 
Co-authored-by: Terry Jan Reedy <[email protected]>
@chrstphrchvz

chrstphrchvz commented May 15, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels May 15, 2023
@bedevere-bot

bedevere-bot commented May 15, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from terryjreedy May 15, 2023 04:39
terryjreedy
terryjreedy approved these changes May 15, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels May 15, 2023
@terryjreedy

terryjreedy commented May 15, 2023

Copy link
Copy Markdown
Member

@ambv CLA is frozen. Worked on a previous PR by Christopher that I merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev arhadthedev closed this May 15, 2023
@arhadthedev arhadthedev reopened this May 15, 2023
@terryjreedy
Merge branch 'main' into patch-104494
0117586
erlend-aasland
erlend-aasland reviewed May 15, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2023-05-15-02-22-44.gh-issue-104494.Bkrbfn.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy @erlend-aasland
Update Misc/NEWS.d/next/Tests/2023-05-15-02-22-44.gh-issue-104494.Bkr…
96b5243 
…bfn.rst

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland
erlend-aasland approved these changes May 15, 2023
View reviewed changes
@terryjreedy
terryjreedy merged commit 3cba61f into python:main May 15, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label May 15, 2023
@terryjreedy

terryjreedy commented May 15, 2023

Copy link
Copy Markdown
Member

Will backport to 3.11 only if we decide that all these 8.7 fixes should be.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrstphrchvz
chrstphrchvz deleted the patch-104494 branch May 15, 2023 09:03
carljm added a commit to carljm/cpython that referenced this pull request May 15, 2023
@carljm
Merge branch 'main' into supermon
343867a 
* main: (29 commits)
  pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
  pythongh-101819: Isolate `_io` (python#101948)
  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
  pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
  pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
  pythongh-104490: Consistently define phony make targets (python#104491)
  pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
  pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
  pythongh-101282: move BOLT config after PGO (pythongh-104493)
  pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
  pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
  pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
  pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)
  Minor improvements to typing docs (python#104465)
  pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
  pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
  pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
  pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
  pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
  ...
carljm added a commit to carljm/cpython that referenced this pull request May 15, 2023
@carljm
Merge branch 'main' into cached_property_docs
452d9f5 
* main: (204 commits)
  pythongh-101819: Fix _io clinic input for unused base class method stubs (python#104418)
  pythongh-101819: Isolate `_io` (python#101948)
  Bump mypy from 1.2.0 to 1.3.0 in /Tools/clinic (python#104501)
  pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (python#104495)
  pythongh-104050: Run mypy on `clinic.py` in CI (python#104421)
  pythongh-104490: Consistently define phony make targets (python#104491)
  pythongh-67056: document that registering/unregistering an atexit func from within an atexit func is undefined (python#104473)
  pythongh-104487: PYTHON_FOR_REGEN must be minimum Python 3.10 (python#104488)
  pythongh-101282: move BOLT config after PGO (pythongh-104493)
  pythongh-104469 Convert _testcapi/float.c to use AC (pythongh-104470)
  pythongh-104456: Fix ref leak in _ctypes.COMError (python#104457)
  pythongh-98539: Make _SSLTransportProtocol.abort() safe to call when closed (python#104474)
  pythongh-104337: Clarify random.gammavariate doc entry  (python#104410)
  Minor improvements to typing docs (python#104465)
  pythongh-87092: avoid gcc warning on uninitialized struct field in assemble.c (python#104460)
  pythonGH-71383: IDLE - Document testing subsets of modules (python#104463)
  pythongh-104454: Fix refleak in AttributeError_reduce (python#104455)
  pythongh-75710: IDLE - add docstrings and comments to editor module (python#104446)
  pythongh-91896: Revert some very noisy DeprecationWarnings for `ByteString` (python#104424)
  Add a mention of PYTHONBREAKPOINT to breakpoint() docs (python#104430)
  ...
@terryjreedy terryjreedy added the needs backport to 3.11 only security fixes label May 16, 2023
@miss-islington

miss-islington commented May 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @chrstphrchvz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 16, 2023

Copy link
Copy Markdown

GH-104569 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2023
@chrstphrchvz @terryjreedy
@erlend-aasland @miss-islington
pythongh-104494: Update certain Tkinter pack/place tests for Tk 8.7 e…
ba797a6 
…rrors (pythonGH-104495)

(cherry picked from commit 3cba61f)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 16, 2023
terryjreedy added a commit that referenced this pull request May 17, 2023
@miss-islington @chrstphrchvz
@terryjreedy @erlend-aasland
[3.11] gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 …
dece9c0 
…errors (GH-104495) (#104569)

gh-104494: Update certain Tkinter pack/place tests for Tk 8.7 errors (GH-104495)
(cherry picked from commit 3cba61f)

Co-authored-by: Christopher Chavez <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@chrstphrchvz @bedevere-bot @terryjreedy @miss-islington @erlend-aasland @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.