GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms by encukou · Pull Request #105092 · python/cpython

Conversation

@encukou

@encukou encukou commented May 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: stable_abi.py --all fails on Windows #105091

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on ot…
a4687da 
…her platforms
@encukou encukou added skip issue skip news build The build process and cross-build labels May 30, 2023
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2023
@AlexWaygood AlexWaygood removed the skip issue label May 30, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 30, 2023
stable_abi.py --all fails on Windows #105091
Closed
@encukou
encukou merged commit 0656d23 into python:main May 30, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label May 30, 2023
@encukou
encukou deleted the unixy-unixy branch May 30, 2023 15:46
@AlexWaygood

AlexWaygood commented May 30, 2023

Copy link
Copy Markdown
Member

This should probably be backported to 3.12, right?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm added a commit to carljm/cpython that referenced this pull request May 30, 2023
@carljm
Merge branch 'main' into superbadgetattro
24e1159 
* main:
  CI: Temporarily skip paths with spaces to avoid error (python#105110)
  pythongh-105071: add missing versionadded directive (python#105097)
  pythongh-80064: Fix is_valid_wide_char() return type (python#105099)
  Small speedup for dataclass __eq__ and __repr__ (python#104904)
  pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)
  pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
@encukou encukou added the needs backport to 3.12 only security fixes label May 31, 2023
@miss-islington

miss-islington commented May 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2023
@encukou @miss-islington
pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on ot…
56ec4a7 
…her platforms (pythonGH-105092)

(cherry picked from commit 0656d23)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-bot

bedevere-bot commented May 31, 2023

Copy link
Copy Markdown

GH-105133 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label May 31, 2023
encukou added a commit that referenced this pull request May 31, 2023
@miss-islington @encukou
[3.12] gh-105091: stable_abi.py: Remove "Unixy" check from --all on o…
4729100 
…ther platforms (GH-105092) (GH-105133)

gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (GH-105092)
(cherry picked from commit 0656d23)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
@encukou

encukou commented May 31, 2023

Copy link
Copy Markdown
Member Author

It won't hurt, but I hope we can avoid poking the stable ABI in 3.12 :)
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jun 6, 2023
3.12 backport gh 105236 #105358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build The build process and cross-build skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @AlexWaygood @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.