Description

serhiy-storchaka

opened on Jun 23, 2023

Issue body actions

• PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
• PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
• Refleak in get_suggestions_for_name_error.
• Use of borrowed pointer after possible freeing (self).
• Add some missing error checks.

Linked PRs

• gh-106030: Miscellaneous fixes in Python/suggestions.c #106031
• [3.12] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106031) #106036
• [3.11] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106… #106039

Reacted by Erlend E. Aasland

Activity

1. serhiy-storchaka

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Jun 23, 2023
2. serhiy-storchaka

   added 2 commits that reference this issue on Jun 23, 2023

   pythongh-106030: Miscaleous fixes in Python/suggestions.c

   3d6655d

   pythongh-106030: Miscaleous fixes in Python/suggestions.c

   c82f8b8
3. AlexWaygood

   changed the title [-]Miscaleous fixes in Python/suggestions.c[/-] [+]Miscellaneous fixes in Python/suggestions.c[/+] on Jun 23, 2023
4. serhiy-storchaka

   added a commit that references this issue on Jun 23, 2023

   gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106031)

   c8c162e
5. miss-islington

   added a commit that references this issue on Jun 23, 2023

   pythongh-106030: Miscellaneous fixes in Python/suggestions.c (pythonG…

   1e9fb9d
6. serhiy-storchaka

   added 3 commits that reference this issue on Jun 23, 2023

   [3.11] pythongh-106030: Miscellaneous fixes in Python/suggestions.c (p…

   de2160e

   [3.11] pythongh-106030: Miscellaneous fixes in Python/suggestions.c (p…

   f8ca034

   [3.11] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106… (

   26d87fd
7. serhiy-storchaka

   closed this as completedon Jun 23, 2023
8. hauntsaninja

   added a commit that references this issue on Jun 27, 2023

   [3.12] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106031

   1bb2bf7

Issue actions