GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106030: Miscellaneous fixes in Python/suggestions.c by serhiy-storchaka · Pull Request #106031 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and should not be used.
  • PyUnicode_CompareWithASCIIString() only works if the second argument is ASCII string.
  • Refleak in get_suggestions_for_name_error.
  • Use of borrowed pointer after possible freeing (self).
  • Add some missing error checks.
  • Issue: Miscellaneous fixes in Python/suggestions.c #106030

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Jun 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 23, 2023
Miscellaneous fixes in Python/suggestions.c #106030
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 23, 2023
gh-106025: Fix incorrect usage of PyUnicode_CompareWithASCIIString in suggestions.c #106026
Closed
@serhiy-storchaka
serhiy-storchaka requested a review from pablogsal June 23, 2023 15:02
@serhiy-storchaka
pythongh-106030: Miscaleous fixes in Python/suggestions.c
c82f8b8 
* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks.
@serhiy-storchaka
serhiy-storchaka force-pushed the suggestions branch from 3d6655d to c82f8b8 Compare June 23, 2023 15:04
@AlexWaygood AlexWaygood changed the title gh-106030: Miscaleous fixes in Python/suggestions.c gh-106030: Miscellaneous fixes in Python/suggestions.c Jun 23, 2023
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 23, 2023
pablogsal
pablogsal approved these changes Jun 23, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 23, 2023
@serhiy-storchaka
serhiy-storchaka merged commit c8c162e into python:main Jun 23, 2023
@miss-islington

miss-islington commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 23, 2023
@serhiy-storchaka
serhiy-storchaka deleted the suggestions branch June 23, 2023 16:53
@miss-islington

miss-islington commented Jun 23, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c8c162ef5294cddb7ac75fe93ab918e5661c68ee 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Jun 23, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 23, 2023
@serhiy-storchaka @miss-islington
pythongh-106030: Miscellaneous fixes in Python/suggestions.c (pythonG…
1e9fb9d 
…H-106031)

* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks.
(cherry picked from commit c8c162e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 23, 2023

Copy link
Copy Markdown

GH-106036 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 23, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 23, 2023
@serhiy-storchaka
[3.11] pythongh-106030: Miscellaneous fixes in Python/suggestions.c (p…
de2160e 
…ythonGH-106031)

* PyDict_GetItem() and PyObject_HasAttr() suppress arbitrary errors and
  should not be used.
* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Use of borrowed pointer after possible freeing (self).
* Add some missing error checks..
(cherry picked from commit c8c162e)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 23, 2023
@serhiy-storchaka
[3.11] pythongh-106030: Miscellaneous fixes in Python/suggestions.c (p…
f8ca034 
…ythonGH-106031)

* PyUnicode_CompareWithASCIIString() only works if the second argument
  is ASCII string.
* Refleak in get_suggestions_for_name_error.
* Add some missing error checks..
(cherry picked from commit c8c162e)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 23, 2023

Copy link
Copy Markdown

GH-106039 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 23, 2023
hauntsaninja pushed a commit that referenced this pull request Jun 27, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-106030: Miscellaneous fixes in Python/suggestions.c (GH-106031
1bb2bf7 
) (#106036)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.