GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — C API: Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName()? · Issue #107149 · python/cpython

C API: Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName()? #107149

New issue
Copy link
New issue
Copy link
Closed
Closed
C API: Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName()?#107149
Copy link
Labels
topic-C-APItype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@vstinner
vstinner
opened on Jul 23, 2023
Issue body actions

Python 3.13 added _PyUnstable_GetUnaryIntrinsicName() and _PyUnstable_GetBinaryIntrinsicName() to the C API. I don't get the _PyUnstable prefix: PEP 689 – Unstable C API tier uses PyUnstable_ prefix.

Is it just a typo, or is the API private on purpose? If it's private, why does its name look like as if it's part of the Unstable C API?

cc @brandtbucher @iritkatriel @encukou

Linked PRs

  • gh-107149: Make PyUnstable_ExecutableKinds public #108440
  • gh-107149: Rename _PyUnstable_GetUnaryIntrinsicName() function #108441
  • gh-107149: Rename PyUnstable_ExecutableKinds to _Py_ExecutableKinds #108651
  • gh-107149: make new opcode util functions private rather than public and unstable #112042

Activity

Next
  1. vstinner
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    topic-C-API
    on Jul 23, 2023
  2. vstinner
    added 3 commits that reference this issue on Aug 24, 2023

    pythongh-107149: Make PyUnstable_ExecutableKinds public

    20e5c13

    pythongh-107149: Make PyUnstable_ExecutableKinds public

    21cad67

    pythongh-107149: Rename _PyUnstable_GetUnaryIntrinsicName() function

    1f77904
  3. iritkatriel commented on Aug 28, 2023

    @iritkatriel
    iritkatriel
    on Aug 28, 2023
    Member
    More actions

    I doubt there was a reason for the _. Probably just a habit.

  4. vstinner
    added 6 commits that reference this issue on Aug 28, 2023

    gh-107149: Rename _PyUnstable_GetUnaryIntrinsicName() function (#108441)

    0b6a4cb

    pythongh-107149: Make PyUnstable_ExecutableKinds public

    cdf9ab3

    pythongh-107149: Rename PyUnstable_ExecutableKinds to _Py_ExecutableK…

    07af9da

    pythongh-107149: Rename PyUnstable_ExecutableKinds to _Py_ExecutableK…

    bbb0c48

    pythongh-107149: Make PyUnstable_ExecutableKinds public

    cc026df

    gh-107149: Make PyUnstable_ExecutableKinds public (#108440)

    9c03215
  5. vstinner commented on Aug 31, 2023

    @vstinner
    vstinner
    on Aug 31, 2023
    MemberAuthor
    More actions

    At the end, all APIs discussed here are public and exposed with the PyUnstable prefix in the public C API (in Include/cpython/).

  6. vstinner
    closed this as completedon Aug 31, 2023
  7. encukou commented on Aug 31, 2023

    @encukou
    encukou
    on Aug 31, 2023
    Member
    More actions

    Unstable API needs documentation and tests.

    Reacted by Erlend E. Aasland
  8. 2 remaining items

  9. vstinner commented on Nov 8, 2023

    @vstinner
    vstinner
    on Nov 8, 2023
    MemberAuthor
    More actions

    @erlend-aasland:

    Perhaps #105481 (which added the APIs in question) should be reopened instead.

    Ok, I closed this issue and reopened gh-105481 instead.

  10. vstinner
    closed this as completedon Nov 8, 2023
  11. iritkatriel commented on Nov 12, 2023

    @iritkatriel
    iritkatriel
    on Nov 12, 2023
    Member
    More actions

    @erlend-aasland:

    Perhaps #105481 (which added the APIs in question) should be reopened instead.

    Ok, I closed this issue and reopened gh-105481 instead.

    It's not easy to see on that issue what you mean (which unstable APIs? That issue contained several large PRs that change many things). I think it actually works better to finish it off on this issue or create a new one than to report a large old issue.

  12. iritkatriel commented on Nov 12, 2023

    @iritkatriel
    iritkatriel
    on Nov 12, 2023
    Member
    More actions

    Also, PyUnstable_ExecutableKinds was not added in #105481.

  13. iritkatriel commented on Nov 13, 2023

    @iritkatriel
    iritkatriel
    on Nov 13, 2023
    Member
    More actions

    Reopening. See #105481 (comment).

  14. iritkatriel
    reopened this on Nov 13, 2023
  15. iritkatriel
    added 2 commits that reference this issue on Nov 13, 2023

    pythongh-107149: make new opcode utils private

    1dd0bf5

    pythongh-107149: make new opcode utils private

    11fc9d7
  16. vstinner
    added
    skip news
    and removed
    skip news
    on Nov 13, 2023
  17. iritkatriel
    added a commit that references this issue on Nov 14, 2023

    gh-107149: make new opcode util functions private rather than public …

    36aab34
  18. vstinner commented on Dec 15, 2023

    @vstinner
    vstinner
    on Dec 15, 2023
    MemberAuthor
    More actions

    Reopening. See #105481 (comment).

    Change implemented by 36aab34. I close again the issue.

  19. vstinner
    closed this as completedon Dec 15, 2023
  20. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-107149: make new opcode util functions private rather than p…

    0e1c4df
  21. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-107149: make new opcode util functions private rather than p…

    ce1ed61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic-C-APItype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.