GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107149: make new opcode util functions private rather than public and unstable by iritkatriel · Pull Request #112042 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Nov 13, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName()? #107149

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-107149: make new opcode utils private
11fc9d7
@iritkatriel iritkatriel added interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API labels Nov 13, 2023
@iritkatriel
iritkatriel requested a review from vstinner November 13, 2023 15:52
@iritkatriel
iritkatriel requested a review from markshannon as a code owner November 13, 2023 15:52
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 13, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 13, 2023
C API: Rename _PyUnstable_GetUnaryIntrinsicName() to PyUnstable_GetUnaryIntrinsicName()? #107149
Closed
vstinner
vstinner reviewed Nov 13, 2023
View reviewed changes
Comment thread Include/cpython/compile.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Nov 13, 2023
@vstinner

vstinner commented Nov 13, 2023

Copy link
Copy Markdown
Member

vstinner added the skip news label Nov 13, 2023

Since functions are new in Python 3.13, there is no need to document these changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
add comment
269f2f5
arhadthedev
arhadthedev reviewed Nov 13, 2023
View reviewed changes
Comment thread Include/cpython/compile.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 2 commits November 13, 2023 20:35
@iritkatriel @arhadthedev
Update Include/cpython/compile.h
da3a3dd 
Co-authored-by: Oleg Iarygin <[email protected]>
@iritkatriel
move most declarations to /Include/internal..
fd24584
iritkatriel
iritkatriel commented Nov 13, 2023
View reviewed changes
Comment thread Include/cpython/compile.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
move the rest
7cb1e37
vstinner
vstinner approved these changes Nov 13, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for moving definitions to pycore_compile.h.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/cpython/compile.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 13, 2023
@iritkatriel
whitespace
b14458a
@iritkatriel
iritkatriel enabled auto-merge (squash) November 14, 2023 00:09
@iritkatriel
iritkatriel merged commit 36aab34 into python:main Nov 14, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 14, 2023
@vstinner

vstinner commented Nov 14, 2023

Copy link
Copy Markdown
Member

Thanks @iritkatriel. It's better to keep the API private for now, and only consider making it public if we have a clear user request to make it public (even if it's as an "unstable" API).
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-107149: make new opcode util functions private rather than p…
0e1c4df 
…ublic and unstable (python#112042)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-107149: make new opcode util functions private rather than p…
ce1ed61 
…ublic and unstable (python#112042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@vstinner vstinner vstinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @vstinner @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.