Description

AlexWaygood

opened on Oct 9, 2023

Issue body actions

Feature or enhancement

Proposal:

As @erlend-aasland and I have worked on adding type hints to Argument Clinic over the last few months, and applied various other modernisations to Tools/clinic/, running pyflakes on the code on a regular basis has caught numerous small bugs that periodically crept in due to a refactoring. Pyflakes has an extremely low number of false positives, so it would be great to have this run as part of CI to catch these issues before they're merged in.

Following #109161, we now run ruff in CI on the Lib/test/ directory, and ruff has implementations of all the pyflakes error codes. I propose that we add a CI check that runs the full set of pyflakes checks (via ruff) on Tools/clinic/.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

• gh-110558: Run ruff on Argument Clinic in CI #110559
• [3.12] gh-110558: Run ruff on Argument Clinic in CI (#110559) #110598
• gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic #110603
• [3.12] gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic (GH-110603) #110609

Reacted by Erlend E. Aasland, Łukasz Langa and Kirill Podoprigora

Activity

1. AlexWaygood

   added

   type-featureA feature request or enhancementA feature request or enhancement

   topic-argument-clinic

   on Oct 9, 2023
2. AlexWaygood

   self-assigned this

   on Oct 9, 2023
3. AlexWaygood

   added 5 commits that reference this issue on Oct 9, 2023

   pythongh-110558: Run ruff on Argument Clinic in CI

   dec89bc

   gh-110558: Run ruff on Argument Clinic in CI (#110559)

   7b2764e

   [3.12] pythongh-110558: Run ruff on Argument Clinic in CI (python#110559

   da73e4c

   pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…

   b1beca0

   pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…

   f943a83
4. hugovk

   added a commit that references this issue on Oct 10, 2023

   [3.12] gh-110558: Run ruff on Argument Clinic in CI (#110559) (#110598)

   3688672
5. AlexWaygood

   added a commit that references this issue on Oct 10, 2023

   gh-110558: Enable ruff's pyupgrade rules when running on Argument Cli…

   fc811c8
6. miss-islington

   added a commit that references this issue on Oct 10, 2023

   pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…

   50c3fd6
7. AlexWaygood

   added a commit that references this issue on Oct 10, 2023

   [3.12] gh-110558: Enable ruff's pyupgrade rules when running on Argum…

   55d6076
8. AlexWaygood

   closed this as completedon Oct 10, 2023
9. Glyphack

   added 2 commits that reference this issue on Sep 2, 2024

   pythongh-110558: Run ruff on Argument Clinic in CI (python#110559)

   a3db2eb

   pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…

   eccbdfe

Issue actions