GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic by AlexWaygood · Pull Request #110603 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Oct 10, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

These are more opinionated, lint-style checks than the existing pyflakes rules that we currently have enabled on Argument Clinic, following #110559. The full list of pyupgrade rules is at https://docs.astral.sh/ruff/rules/#pyupgrade-up.

Thoughts? Is this a useful addition?

  • Issue: Run ruff on Argument Clinic in CI #110558

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
f943a83 
…nt Clinic
@AlexWaygood AlexWaygood added the needs backport to 3.12 only security fixes label Oct 10, 2023
@AlexWaygood
AlexWaygood requested review from erlend-aasland and hugovk as code owners October 10, 2023 08:54
@bedevere-app bedevere-app Bot added the awaiting review label Oct 10, 2023
@AlexWaygood AlexWaygood added skip news and removed awaiting review labels Oct 10, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
Run ruff on Argument Clinic in CI #110558
Closed
hugovk
hugovk approved these changes Oct 10, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 10, 2023
erlend-aasland
erlend-aasland approved these changes Oct 10, 2023
View reviewed changes
@AlexWaygood

AlexWaygood commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

Thanks, both! I chatted with @hugovk at the sprint (you're missed @erlend-aasland 😢), and I think there probably aren't any other rules that are worth enabling right now (but feel free to propose any more that that you think would be useful!)
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood enabled auto-merge (squash) October 10, 2023 09:14
@erlend-aasland

erlend-aasland commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Thanks, both! I chatted with @hugovk at the sprint (you're missed @erlend-aasland 😢), and I think there probably aren't any other rules that are worth enabling right now (but feel free to propose any more that that you think would be useful!)

For these DevOps things, I fully trust you two! :) It is very nice that we're getting more automated machinery in place in the CPython repo; I love it! I wish I was in Brno with y'all; it is a very nice city IMO.
AlexWaygood and hugovk reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood merged commit fc811c8 into python:main Oct 10, 2023
@AlexWaygood
AlexWaygood deleted the ruff-pyupgrade-argclinic branch October 10, 2023 09:35
@miss-islington

miss-islington commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 10, 2023
@bedevere-app

bedevere-app Bot commented Oct 10, 2023

Copy link
Copy Markdown

GH-110609 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 10, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2023
@AlexWaygood @miss-islington
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
50c3fd6 
…nt Clinic (pythonGH-110603)

(cherry picked from commit fc811c8)

Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood added a commit that referenced this pull request Oct 10, 2023
@miss-islington @AlexWaygood
[3.12] gh-110558: Enable ruff's pyupgrade rules when running on Argum…
55d6076 
…ent Clinic (GH-110603) (#110609)

gh-110558: Enable ruff's pyupgrade rules when running on Argument Clinic (GH-110603)
(cherry picked from commit fc811c8)

Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-110558: Enable ruff's pyupgrade rules when running on Argume…
eccbdfe 
…nt Clinic (python#110603)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @erlend-aasland @miss-islington @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.