Description

seberg

opened on Oct 31, 2023

Issue body actions

In NumPy we use _Py_HashDouble for our floating point hashing needs and that seems like a pretty good candiate for the unstable API to me: #91744 (comment) and #101101 (comment).

However, the function is currently removed rather than made unstable (to my understanding). While it should probably be easy enough to vendor what we needed, I would prefer the unstable API tier, it gives a better sense of having the required identical hashing.

NumPy issue: numpy/numpy#25035

Originally reported by @ngoldbaum in #111418 (comment)

Linked PRs

• gh-111545: Add Include/cpython/pyhash.h header file #112063
• gh-111545: Add PyHash_Double() function #112095
• gh-111545: Add Py_HashPointer() function #112096
• gh-111545: Test PyHash_GetFuncDef() function #112098
• gh-111545: Add Py_HashDouble() function #112449
• [DO NOT MERGE][BENCHMARK] gh-111545: Benchmark PyHash_Double() #112476
• gh-111545: Mention PEP 456 in PyHash_GetFuncDef() doc #112647
• gh-111545: Add Py_HashDouble() function #113115

Reacted by Vasily Ryabov

Activity

1. AlexWaygood

   added

   type-featureA feature request or enhancementA feature request or enhancement

   topic-C-API

   on Oct 31, 2023
2. encukou commented on Nov 2, 2023

   

   encukou

   on Nov 2, 2023

   Member

   More actions

   cc @vstinner, per the What's New
3. vstinner commented on Nov 2, 2023

   

   vstinner

   on Nov 2, 2023

   Member

   More actions

   In NumPy we use _Py_HashDouble for our floating point hashing needs and that seems like a pretty good candiate for the unstable API to me: #91744 (comment) and #101101 (comment).

   I would prefer a public API rather than a private API. I don't expect Py_HashDouble() API to be unstable.

   See also issue #111389.

   cc @vstinner, per the What's New

   Thanks. I'm trying to keep track of these issues under #111481 meta issue.

   Reacted by Sebastian Berg
4. vstinner

   added 11 commits that reference this issue on Nov 14, 2023

   pythongh-111545: Add Include/cpython/pyhash.h header file

   554780b

   pythongh-111545: Add Include/cpython/pyhash.h header file

   f436654

   gh-111545: Add Include/cpython/pyhash.h header file (#112063)

   62802b6

   pythongh-111545: Add Py_HashDouble() function

   1e132f8

   pythongh-111545: Add PyHash_Double() function

   a8c4cb2

   pythongh-111545: Add PyHash_Double() function

   96be42d

   pythongh-111545: Add PyHash_Double() function

   3b6ab5f

   pythongh-111545: Add PyHash_Pointer() function

   f0a0d5c

   pythongh-111545: Add PyHash_Pointer() function

   24d08b7

   pythongh-111545: Test PyHash_GetFuncDef() function

   5b4046b

   gh-111545: Test PyHash_GetFuncDef() function (#112098)

   55f3cce
5. 27 remaining items
6. vstinner

   added 5 commits that reference this issue on Dec 5, 2023

   pythongh-111545: Add Py_HashPointer() function

   c0356a2

   gh-111545: Add Py_HashPointer() function (#112096)

   828451d

   pythongh-111545: Add Py_HashDouble() function

   155764a

   pythongh-111545: Add Py_HashDouble() function

   250c3e1

   pythongh-111545: Add Py_HashDouble() function

   9b00e3e
7. aisk

   added 4 commits that reference this issue on Feb 11, 2024

   pythongh-111545: Add Include/cpython/pyhash.h header file (python#112063

   abbd148

   pythongh-111545: Test PyHash_GetFuncDef() function (python#112098)

   99fb366

   pythongh-111545: Mention PEP 456 in PyHash_GetFuncDef() doc (python#1…

   9b49671

   pythongh-111545: Add Py_HashPointer() function (python#112096)

   7569396
8. vstinner commented on May 19, 2024

   

   vstinner

   on May 19, 2024

   Member

   More actions

   It was decided to not add a public API for now: capi-workgroup/decisions#2 (comment)
9. vstinner

   closed this as completedon May 19, 2024
10. Glyphack

    added 4 commits that reference this issue on Sep 2, 2024

    pythongh-111545: Add Include/cpython/pyhash.h header file (python#112063

    ed7702e

    pythongh-111545: Test PyHash_GetFuncDef() function (python#112098)

    fb6fb57

    pythongh-111545: Mention PEP 456 in PyHash_GetFuncDef() doc (python#1…

    0ef2b75

    pythongh-111545: Add Py_HashPointer() function (python#112096)

    c305506

Issue actions