GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112088: Run autoreconf in GHA check_generated_files by vstinner · Pull Request #112090 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 14, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the unstable quay.io server.

  • Issue: Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Nov 14, 2023
Consider avoiding the dependency on quay.io server in the GitHub Action "Check if generated files are up to date" job #112088
Closed
@vstinner vstinner added the skip news label Nov 14, 2023
@vstinner
vstinner force-pushed the avoid_quay_io branch from 026ed0e to 7f3e933 Compare November 14, 2023 22:41
@vstinner
vstinner marked this pull request as ready for review November 14, 2023 23:36
@vstinner
vstinner requested review from corona10, erlend-aasland, ezio-melotti and hugovk as code owners November 14, 2023 23:36
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 14, 2023
gpshead
gpshead approved these changes Nov 15, 2023
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea. It doesn't appear there is any reason for the quay.io image anymore given ubuntu-22.04 has a sufficiently good autoconf.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 15, 2023
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

cc @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Nov 15, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update https://github.com/python/cpython/blob/d4f83e1e3a19e2f881115f20d58ae6a019ddb48f/Doc/using/configure.rst#generated-files as well.

And backport?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Makefile.pre.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner force-pushed the avoid_quay_io branch from cc67cbd to e713876 Compare November 15, 2023 12:47
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 15, 2023
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

@hugovk: I completed the PR to address your review. Would you mind to review the updated PR?

Let's update https://github.com/python/cpython/blob/d4f83e1e3a19e2f881115f20d58ae6a019ddb48f/Doc/using/configure.rst#generated-files as well.

Done.

And backport?

I added the backport to 3.11 and 3.12 labels.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

The main point of this PR is that Tools/build/regen-configure.sh now uses the same container image than the GitHub Action job, so the job doesn't have to run autoreconf in a container, but can run it directly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-112088: Run autoreconf in GHA check_generated_files
4f8987f 
The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.
@vstinner
vstinner force-pushed the avoid_quay_io branch from 96437cb to 4f8987f Compare November 15, 2023 13:05
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

Oh, there is a fix in the Changelog entry causing the Docs job to fail: fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Nov 15, 2023
View reviewed changes
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland: It would be nice if you could review this change, since you made many configure changes last months ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Also, the devguide must be updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Nov 15, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. (I'm a little bit puzzled by the aclocal.m4 and configure changes, but they are also fine.)

Thanks for doing this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland

erlend-aasland commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

IIRC, we did the autoconf version bump before the 3.12 freeze, so IMO we should backport this to 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner removed the needs backport to 3.11 only security fixes label Nov 15, 2023
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

This looks good to me. (I'm a little bit puzzled by the aclocal.m4 and configure changes, but they are also fine.)

I'm not sure if I picked the wrong pkg-config package. But well, for now, my main worry is more to make the whole Python workflow more reliable by avoiding depending on the external quay.io server which had multiple outages in several days.

With my change, the Python workflow no longer pulls an external container image, but simply reuse what's available on Ubuntu 22.04 in the GitHub Action.

IIRC, we did the autoconf version bump before the 3.12 freeze, so IMO we should backport this to 3.12.

Oh. So we cannot backport this change to 3.11?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit d9fd33a into python:main Nov 15, 2023
@vstinner
vstinner deleted the avoid_quay_io branch November 15, 2023 20:47
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 15, 2023
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 15, 2023
@vstinner @miss-islington
pythongh-112088: Run autoreconf in GHA check_generated_files (pythonG…
fa50d69 
…H-112090)

The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.
(cherry picked from commit d9fd33a)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

This comment was marked as outdated.

Sign in to view
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 15, 2023
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

Merged. Thanks for reviews. Let's start with a backport to 3.12.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Oh. So we cannot backport this change to 3.11?

No, 3.11 uses a patched Autoconf 2.69 from Alpine Linux, not a vanilla 2.69 installation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware zware mentioned this pull request Nov 15, 2023
Use manifest for quay.io/tiran/cpython_autoconf instead of tag python/release-tools#75
Closed
@sethmlarson

sethmlarson commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

@vstinner I was doing some work on release-tools adjacent to this, @zware pointed me to this PR. What are your thoughts on backporting the regen-configure makefile target to all supported versions so that release-tools can depend on it being there?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Nov 15, 2023

Copy link
Copy Markdown
Member

For 3.11 and earlier autoconf version configure generation udpates, ask the release managers (@pablogsal and @ambv) for those branches. (it makes sense for 3.12)
sethmlarson and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit to vstinner/cpython that referenced this pull request Nov 16, 2023
@vstinner
pythongh-112088: Run autoreconf in GHA check_generated_files (python#…
216b01c 
…112090)

The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.

(cherry picked from commit d9fd33a)
@bedevere-app

This comment was marked as outdated.

Sign in to view
1 similar comment
@bedevere-app

This comment was marked as duplicate.

Sign in to view
vstinner added a commit that referenced this pull request Nov 16, 2023
@vstinner
[3.12] gh-112088: Run autoreconf in GHA check_generated_files (GH-112090
a498433 
) (#112159)

gh-112088: Run autoreconf in GHA check_generated_files (#112090)

The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.

(cherry picked from commit d9fd33a)
@sethmlarson sethmlarson mentioned this pull request Nov 16, 2023
Backport regen-configure target to supported branches #112160
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@vstinner @aisk
pythongh-112088: Run autoreconf in GHA check_generated_files (python#…
52b93a4 
…112090)

The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-112088: Run autoreconf in GHA check_generated_files (python#…
2882f6b 
…112090)

The "Check if generated files are up to date" job of GitHub Actions
now runs the "autoreconf -ivf -Werror" command instead of the "make
regen-configure" command to avoid depending on the external quay.io
server.

Add Tools/build/regen-configure.sh script to regenerate the configure
with an Ubuntu container image. The
"quay.io/tiran/cpython_autoconf:271" container image
(https://github.com/tiran/cpython_autoconf) is no longer used.
@efimov-mikhail

efimov-mikhail commented Oct 14, 2024

Copy link
Copy Markdown
Member

I can see using of aclocal 1.16.5 in this PR.
But in docs we write "Autoconf 2.71 and aclocal 1.16.4 are required to regenerate the configure script". (https://docs.python.org/3.14/using/configure.html#build-requirements).

Should we provide some changes to docs for update them?
@vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

Should we provide some changes to docs for update them?

Yes. Do you want to propose a PR to update the doc?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efimov-mikhail

efimov-mikhail commented Oct 14, 2024

Copy link
Copy Markdown
Member

Yes. Do you want to propose a PR to update the doc?

Yes, I do.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@hugovk hugovk hugovk approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @erlend-aasland @sethmlarson @gpshead @efimov-mikhail @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.