Description

tacaswell

opened on Mar 13, 2024

Issue body actions

Bug report

Bug description:

Attempting to build numpy fails with the errors that look like:

FAILED: numpy/_core/_struct_ufunc_tests.cpython-313-x86_64-linux-gnu.so
cc  -o numpy/_core/_struct_ufunc_tests.cpython-313-x86_64-linux-gnu.so numpy/_core/_struct_ufunc_tests.cpython-313-x86_64-linux-gnu.so.p/src_umath__struct_ufunc_tests.c.o -Wl,--as-needed -Wl,--allow-shlib-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group -lm -Wl,--end-group -Wall -O2 -pipe -fomit-frame-pointer -fno-strict-aliasing -Wmaybe-uninitialized -Wdeprecated-declarations -Wimplicit-function-declaration -march=native -DCYTHON_FAST_THREAD_STATE=0 @LIBPYTHON@
/usr/bin/ld: cannot find @LIBPYTHON@: No such file or directory

I bisected this back to

#115780

and found that there were still two instances of @LIBPYTHON@ left in the repo. I will open a PR shortly.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

• gh-116745: remove all internal usage of @LIBPYTHON@ #116746

Activity

1. tacaswell

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Mar 13, 2024
2. tacaswell

   added a commit that references this issue on Mar 13, 2024

   pythongh-116745: remove all internal usage of @LIBPYTHON@

   3a44865
3. befeleme commented on Mar 20, 2024

   

   befeleme

   on Mar 20, 2024

   Contributor

   More actions

   This issue has caused a lot of build failures in Fedora Python packages.
4. befeleme

   added a commit that references this issue on Mar 20, 2024

   00424: pythongh-116745: remove all internal usage of @LIBPYTHON@

   dddd390
5. erlend-aasland

   added a commit that references this issue on Mar 21, 2024

   gh-116745: Remove all internal usage of @LIBPYTHON@ (#116746)

   c4bf58a
6. erlend-aasland

   closed this as completedon Mar 21, 2024
7. erlend-aasland commented on Mar 21, 2024

   

   erlend-aasland

   on Mar 21, 2024

   Contributor

   More actions

   Thanks for the report and the fix!

   Reacted by Thomas A Caswell
8. adorilson

   added a commit that references this issue on Mar 25, 2024

   pythongh-116745: Remove all internal usage of @LIBPYTHON@ (python#116746

   9b138d5
9. NGRsoftlab

   added 2 commits that reference this issue on Apr 2, 2024

   Squashed commit of the following:

   1b5fe4c

   Squashed commit of the following:

   a016a54
10. diegorusso

    added a commit that references this issue on Apr 17, 2024

    pythongh-116745: Remove all internal usage of @LIBPYTHON@ (python#116746

    dddd4a5
11. eli-schwartz commented on Jul 28, 2024

    

    eli-schwartz

    on Jul 28, 2024

    Contributor

    More actions

    Attempting to build numpy fails with the errors that look like:

    This issue report is sort of wrong, and the fix is wrong IMHO. Downstream projects are specifically looking up sysconfig.get_config_var('LIBPYTHON') by absolute name -- deleting it from the Makefile entirely, does not mean that the correct information is accessed.

    In particular, for your use case you'll now start linking to libpython when you don't want to AFAICT. :)

    This is better than linking to @LIBPYTHON@ but still basically goes against #65735.

    Reacted by Erlend E. Aasland
12. mhsmith commented on Aug 6, 2024

    

    mhsmith

    on Aug 6, 2024

    Member

    More actions

    Thanks – I've created #122764 to rename the variable back to LIBPYTHON.

    Also, it turns out there was one more instance that I missed: Misc/python-config.in.

    Reacted by Ralf Gommers and Erlend E. Aasland

Issue actions