Description

nohlson

opened on Aug 13, 2024

Issue body actions

Bug report

Bug description:

With the inclusion of build_msi into the Change detection job of test workflow in #121778 it isn't possible to manually run the workflow anymore:

This seems to be because the Ana06/get-changed-files action doesn't support workflow_dispatch:

This type of error apparently does block CI.

I think the fix would be as simple as adding a condition that github.event_name == 'pull_request' to the Get a list of the MSI installer-related files step of the Compute changed files job.

Attn: @webknjaz

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux, macOS

Linked PRs

• gh-122965: Fix reusable-change-detection.yml on workflow_dispatch #122966
• [3.13] gh-122965: Fix reusable-change-detection.yml on workflow_dispatch (GH-122966) #123008
• [3.12] gh-122965: Fix reusable-change-detection.yml on workflow_dispatch (GH-122966) #123009

Activity

1. nohlson

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Aug 13, 2024
2. sobolevn

   added a commit that references this issue on Aug 13, 2024

   pythongh-122965: Fix `reusable-change-detection.yml` on `workflow_dis…

   fbd5a7e
3. hugovk

   added a commit that references this issue on Aug 14, 2024

   gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (…

   6ae942f
4. miss-islington

   added 2 commits that reference this issue on Aug 14, 2024

   pythongh-122965: Fix `reusable-change-detection.yml` on `workflow_dis…

   5a6d226

   pythongh-122965: Fix `reusable-change-detection.yml` on `workflow_dis…

   741474b
5. sobolevn

   added 2 commits that reference this issue on Aug 14, 2024

   [3.12] gh-122965: Fix `reusable-change-detection.yml` on `workflow_di…

   ecf9971

   [3.13] gh-122965: Fix `reusable-change-detection.yml` on `workflow_di…

   8644014
6. picnixz commented on Aug 16, 2024

   

   picnixz

   on Aug 16, 2024

   Member

   More actions

   Closing as this was completed in #122966.

   Reacted by Nate Ohlson
7. picnixz

   closed this as completedon Aug 16, 2024
8. blhsing

   added a commit that references this issue on Aug 22, 2024

   pythongh-122965: Fix `reusable-change-detection.yml` on `workflow_dis…

   36c5102

Issue actions