GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` by sobolevn · Pull Request #122966 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We no longer skip Docs and Windows MSI jobs on workflow_trigger but instead they are now always executed on manual runs.

Refs #122336

  • Issue: "test" GitHub Action workflow cannot be run manually #122965

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
fbd5a7e
…patch`
@sobolevn
sobolevn requested review from ezio-melotti and hugovk as code owners August 13, 2024 09:11
@bedevere-app bedevere-app Bot mentioned this pull request Aug 13, 2024
"test" GitHub Action workflow cannot be run manually #122965
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 13, 2024
@sobolevn sobolevn added skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Aug 13, 2024
@sobolevn

sobolevn commented Aug 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

My manual run: https://github.com/sobolevn/cpython/actions/runs/10366976128

Снимок экрана 2024-08-13 в 12 17 43
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Aug 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

One more point to consider: maybe instead we always need to run docs and windows msi jobs on workflow_dispatch: and not skip them?

Basically I propose to think about this change, from:

    - name: Check for docs changes
      if: >-
        github.event_name == 'pull_request'
        && steps.changed-docs-files.outputs.added_modified_renamed != ''
      id: docs-changes
      run: |
        echo "run-docs=true" >> "${GITHUB_OUTPUT}"

to:

    - name: Check for docs changes
      if: >-
        (github.event_name == 'pull_request'
           && steps.changed-docs-files.outputs.added_modified_renamed != '')
        || github.event_name == 'workflow_dispatch'
      id: docs-changes
      run: |
        echo "run-docs=true" >> "${GITHUB_OUTPUT}"

and the same for - name: Check for changes in MSI installer-related files

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

webknjaz
webknjaz reviewed Aug 13, 2024
View reviewed changes
Comment thread .github/workflows/reusable-change-detection.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Don't skip MSI and Docs jobs and workflow_dispatch
3cf547f
hugovk
hugovk reviewed Aug 13, 2024
View reviewed changes
Comment thread .github/workflows/reusable-change-detection.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread .github/workflows/reusable-change-detection.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Fix Docs build
6d04e6d
@sobolevn

sobolevn commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

Docs job didn't really work out:

https://github.com/sobolevn/cpython/actions/runs/10368635188/job/28702683326

Снимок экрана 2024-08-13 в 14 19 10

So, I addapted it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk reviewed Aug 13, 2024
View reviewed changes
Comment thread .github/workflows/reusable-docs.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

The last version worked: https://github.com/sobolevn/cpython/actions/runs/10368788774/job/28703154687

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Address review
4aadb4a
@sobolevn

sobolevn commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

Done, @hugovk! Thanks for your quick and helpful review! 👍

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

webknjaz
webknjaz reviewed Aug 13, 2024
View reviewed changes
Comment thread .github/workflows/reusable-change-detection.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@webknjaz

webknjaz commented Aug 13, 2024

Copy link
Copy Markdown
Member

Looks like the PR title/description needs updating.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

webknjaz
webknjaz reviewed Aug 13, 2024
View reviewed changes
Comment thread .github/workflows/reusable-docs.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Address review
e20a1c4
@sobolevn

sobolevn commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

Failures are unrelated, GitHub was down. Re-running.

The manual build was succesful: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn
Merge branch 'main' into issue-122965
0c234b0
@sobolevn

sobolevn commented Aug 13, 2024

Copy link
Copy Markdown
Member Author

This looks complete now! GitHub re-run worked, local manual tests passed: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891

Thanks everyone!

nohlson reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk
hugovk approved these changes Aug 14, 2024
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 14, 2024
@hugovk
hugovk merged commit 6ae942f into python:main Aug 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 14, 2024
@miss-islington-app

miss-islington-app Bot commented Aug 14, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2024
@sobolevn @miss-islington
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
5a6d226
…patch` (pythonGH-122966)

(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 14, 2024

Copy link
Copy Markdown

GH-123008 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 14, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 14, 2024
@sobolevn @miss-islington
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
741474b
…patch` (pythonGH-122966)

(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 14, 2024

Copy link
Copy Markdown

GH-123009 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Aug 14, 2024
sobolevn added a commit that referenced this pull request Aug 14, 2024
@miss-islington @sobolevn
[3.12] gh-122965: Fix reusable-change-detection.yml on `workflow_di…
ecf9971
…spatch` (GH-122966) (#123009)

gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (GH-122966)
(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <[email protected]>
@hugovk

hugovk commented Aug 14, 2024

Copy link
Copy Markdown
Member

After merging, I tested a manual trigger and looks good: https://github.com/python/cpython/actions/runs/10387198512 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn added a commit that referenced this pull request Aug 14, 2024
@miss-islington @sobolevn
[3.13] gh-122965: Fix reusable-change-detection.yml on `workflow_di…
8644014
…spatch` (GH-122966) (#123008)

gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` (GH-122966)
(cherry picked from commit 6ae942f)

Co-authored-by: sobolevn <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@sobolevn @blhsing
pythongh-122965: Fix reusable-change-detection.yml on `workflow_dis…
36c5102
…patch` (python#122966)
@AA-Turner AA-Turner mentioned this pull request Feb 3, 2025
Convert change detection to a Python script #129627
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz left review comments
@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @webknjaz @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.