GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-122965: Fix `reusable-change-detection.yml` on `workflow_dispatch` by sobolevn · Pull Request #122966 · python/cpython Conversation
|
|
My manual run: https://github.com/sobolevn/cpython/actions/runs/10366976128
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
One more point to consider: maybe instead we always need to run docs and windows msi jobs on Basically I propose to think about this change, from: - name: Check for docs changes if: >- github.event_name == 'pull_request' && steps.changed-docs-files.outputs.added_modified_renamed != '' id: docs-changes run: | echo "run-docs=true" >> "${GITHUB_OUTPUT}" to: - name: Check for docs changes if: >- (github.event_name == 'pull_request' && steps.changed-docs-files.outputs.added_modified_renamed != '') || github.event_name == 'workflow_dispatch' id: docs-changes run: | echo "run-docs=true" >> "${GITHUB_OUTPUT}" and the same for |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
https://github.com/sobolevn/cpython/actions/runs/10368635188/job/28702683326
So, I addapted it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
The last version worked: https://github.com/sobolevn/cpython/actions/runs/10368788774/job/28703154687 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Done, @hugovk! Thanks for your quick and helpful review! 👍 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Looks like the PR title/description needs updating. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Failures are unrelated, GitHub was down. Re-running. The manual build was succesful: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This looks complete now! GitHub re-run worked, local manual tests passed: https://github.com/sobolevn/cpython/actions/runs/10370346404/job/28708436891 Thanks everyone! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…patch` (pythonGH-122966) (cherry picked from commit 6ae942f) Co-authored-by: sobolevn <[email protected]>
|
GH-123008 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…patch` (pythonGH-122966) (cherry picked from commit 6ae942f) Co-authored-by: sobolevn <[email protected]>
|
GH-123009 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
After merging, I tested a manual trigger and looks good: https://github.com/python/cpython/actions/runs/10387198512 👍 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.